[deps] rev package:lints; address 'unnecessary_underscores' lints

Change-Id: I866bf007f50eafcc3c2e61d49895a0244c14eff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412760
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: devoncarew

DEPS

@@ -129,7 +129,7 @@ vars = {
   ### /third_party/pkg dependencies
   # 'tools/rev_sdk_deps.dart' will rev pkg dependencies to their latest; put an
   # EOL comment after a dependency to instead pin at the current revision.
-  "core_rev": "0b2bd3fcd7f3e082f4cc9b14c19ffa93894b85ae",
+  "core_rev": "15c7fe9958b95998ba2f5a4ad1beab66b9d815fb",
   "dartdoc_rev": "34561d6ebf5fa89ca1f93b981de96a75ff573562",
   "ecosystem_rev": "06bbbffc1dae26164ee0a9603d0a30af620b84d0",
   "flute_rev": "e4ea0459a7debae5e9592c85141707b01fac86c9",

pkg/compiler/lib/src/phase/load_kernel.dart

@@ -186,7 +186,7 @@ void _doTransformsOnKernelLoad(
     final classHierarchy = ir.ClassHierarchy(
       component,
       coreTypes,
-      onAmbiguousSupertypes: (_, __, ___) {},
+      onAmbiguousSupertypes: (_, _, _) {},
     );
     ir.TypeEnvironment typeEnvironment = ir.TypeEnvironment(
       coreTypes,

pkg/compiler/pubspec.yaml

@@ -3,8 +3,9 @@
 name: compiler
 # This package is not intended for consumption on pub.dev. DO NOT publish.
 publish_to: none
+
 environment:
-  sdk: '^3.7.0'
+  sdk: ^3.7.0
 
 # Use 'any' constraints here; we get our versions from the DEPS file.
 dependencies:

tools/pubspec.yaml

@@ -1,5 +1,6 @@
 name: sdk_tools
 description: Internal tools for building and working on the sdk.
+
 environment:
   sdk: ^3.5.0
 

tools/run_offsets_extractor.dart

@@ -21,8 +21,11 @@ void main(List<String> args) async {
   final footer = old.substring(old.lastIndexOf('\n#endif '));
 
   // Build all configurations
-  await forAllConfigurationsMode(
-      (String buildDir, String mode, String arch) async {
+  await forAllConfigurationsMode((
+    String buildDir,
+    String mode,
+    String arch,
+  ) async {
     print('Building $buildDir');
     await run([
       'tools/build.py',
@@ -31,19 +34,20 @@ void main(List<String> args) async {
       '-m$mode',
       '--no-rbe',
       'offsets_extractor',
-      'offsets_extractor_aotruntime'
+      'offsets_extractor_aotruntime',
     ]);
     print('Building $buildDir - done');
   });
 
-  final (jit, aot) = await (
-    forAllConfigurationsMode((String buildDir, _, __) async {
-      return await run(['$buildDir/offsets_extractor']);
-    }).then<String>((lines) => lines.join('\n')),
-    forAllConfigurationsMode((String buildDir, _, __) async {
-      return await run(['$buildDir/offsets_extractor_aotruntime']);
-    }).then<String>((lines) => lines.join('\n')),
-  ).wait;
+  final (jit, aot) =
+      await (
+        forAllConfigurationsMode((String buildDir, _, _) async {
+          return await run(['$buildDir/offsets_extractor']);
+        }).then<String>((lines) => lines.join('\n')),
+        forAllConfigurationsMode((String buildDir, _, _) async {
+          return await run(['$buildDir/offsets_extractor_aotruntime']);
+        }).then<String>((lines) => lines.join('\n')),
+      ).wait;
 
   if (exitCode == 0) {
     final output = StringBuffer();
@@ -59,7 +63,8 @@ void main(List<String> args) async {
 }
 
 Future<List<T>> forAllConfigurationsMode<T>(
-    Future<T> Function(String buildDir, String mode, String arch) fun) async {
+  Future<T> Function(String buildDir, String mode, String arch) fun,
+) async {
   final archs = [
     'simarm',
     'x64',
@@ -81,8 +86,11 @@ Future<List<T>> forAllConfigurationsMode<T>(
 }
 
 Future<String> run(List<String> args) async {
-  final result =
-      await Process.run(args.first, args.skip(1).toList(), runInShell: true);
+  final result = await Process.run(
+    args.first,
+    args.skip(1).toList(),
+    runInShell: true,
+  );
   if (result.exitCode != 0) {
     exitCode = result.exitCode;
     print('Running ${args.join(' ')} has failed with exit code $exitCode:');