analyzer: Fix remaining comment reference issues

Change-Id: I345c8d25e9f27dedffc596a2040cd89e059eb46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408880
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/dart/analysis/results.dart

@@ -105,7 +105,7 @@ abstract class FileResult implements SomeFileResult, AnalysisResult {
   /// Whether the file is a library.
   ///
   /// A file can't be both a library and a part, so when this getter returns
-  /// `true`, the getters [isPart] and [isMacroPart] return `false`.
+  /// `true`, the getter [isPart] returns `false`.
   bool get isLibrary;
 
   /// Whether the file is a part.

pkg/analyzer/lib/src/dart/resolver/resolution_result.dart

@@ -8,11 +8,11 @@ import 'package:analyzer/src/dart/element/type.dart';
 
 /// The result of attempting to resolve an identifier to elements.
 class ResolutionResult extends SimpleResolutionResult {
-  /// If `true`, then the [getter] is `null`, and this is an error that has
+  /// If `true`, then the [getter2] is `null`, and this is an error that has
   /// not yet been reported, and the client should report it.
   ///
-  /// If `false`, then the [getter] is valid. Usually this means that the
-  /// correct target has been found. But the [getter] still might be `null`,
+  /// If `false`, then the [getter2] is valid. Usually this means that the
+  /// correct target has been found. But the [getter2] still might be `null`,
   /// when there was an error, and it has already been reported (e.g. when
   /// ambiguous extension);  or when `null` is the only possible result (e.g.
   /// when `dynamicTarget.foo`, or `functionTyped.call`).
@@ -21,11 +21,11 @@ class ResolutionResult extends SimpleResolutionResult {
   /// If `true`, the result type must be invalid.
   final bool isGetterInvalid;
 
-  /// If `true`, then the [setter] is `null`, and this is an error that has
+  /// If `true`, then the [setter2] is `null`, and this is an error that has
   /// not yet been reported, and the client should report it.
   ///
-  /// If `false`, then the [setter] is valid. Usually this means that the
-  /// correct target has been found. But the [setter] still might be `null`,
+  /// If `false`, then the [setter2] is valid. Usually this means that the
+  /// correct target has been found. But the [setter2] still might be `null`,
   /// when there was an error, and it has already been reported (e.g. when
   /// ambiguous extension);  or when `null` is the only possible result (e.g.
   /// when `dynamicTarget.foo`).

pkg/analyzer/lib/src/error/unused_local_elements_verifier.dart

@@ -1111,18 +1111,18 @@ class UnusedLocalElementsVerifier extends RecursiveAstVisitor<void> {
   }
 }
 
-/// A container with sets of used [Element]s.
+/// A container with sets of used [Element2]s.
 /// All these elements are defined in a single compilation unit or a library.
 class UsedLocalElements {
   /// Resolved, locally defined elements that are used or potentially can be
   /// used.
   final HashSet<Element2> elements = HashSet<Element2>();
 
-  /// [LocalVariableElement]s that represent exceptions in [CatchClause]s.
+  /// [LocalVariableElement2]s that represent exceptions in [CatchClause]s.
   final HashSet<LocalVariableElement2> catchExceptionElements =
       HashSet<LocalVariableElement2>();
 
-  /// [LocalVariableElement]s that represent stack traces in [CatchClause]s.
+  /// [LocalVariableElement2]s that represent stack traces in [CatchClause]s.
   final HashSet<LocalVariableElement2> catchStackTraceElements =
       HashSet<LocalVariableElement2>();
 

pkg/analyzer/lib/src/test_utilities/mock_sdk.dart

@@ -1668,7 +1668,7 @@ final List<MockSdkLibrary> _LIBRARIES = [
   _LIB_WASM,
 ];
 
-/// Create a reduced approximation of Dart SDK in the [path].
+/// Creates a reduced approximation of Dart SDK in the [root].
 ///
 /// It has enough libraries to run analyzer and analysis server tests,
 /// but some libraries, classes, and methods are missing.

pkg/analyzer/lib/src/utilities/cancellation.dart

@@ -39,9 +39,9 @@ class NotCancelableToken extends CancellationToken {
 /// A cancellable wrapper over another cancellation token.
 ///
 /// This token will be considered cancelled if either it is itself cancelled,
-/// or if [child] is cancelled.
+/// or if [_child] is cancelled.
 ///
-/// Cancelling this token will also cancel [child] if it is a cancelable
+/// Cancelling this token will also cancel [_child] if it is a cancelable
 /// token.
 class _WrappedCancelableToken extends CancelableToken {
   final CancellationToken _child;

pkg/analyzer/lib/src/utilities/completion_matcher.dart

@@ -2,6 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+/// @docImport 'package:analysis_server/src/services/completion/dart/completion_manager.dart';
+library;
+
 /// A matcher that is used in completion to filter out suggestions. The criteria
 /// used to filter is specified in the implementations of the matchers.
 abstract class CompletionMatcher {
@@ -12,7 +15,7 @@ abstract class CompletionMatcher {
 }
 
 /// A [NoPrefixMatcher] will be used when there is no prefix specified in the
-/// [CompletionRequest].
+/// [DartCompletionRequest].
 final class NoPrefixMatcher extends CompletionMatcher {
   @override
   double score(String candidate) {

pkg/analyzer/lib/src/utilities/extensions/flutter.dart

@@ -126,7 +126,7 @@ extension AstNodeExtension on AstNode? {
     return null;
   }
 
-  /// Whether the given [node] is the Flutter class `Widget`, or its subtype.
+  /// Whether this [AstNode] is the Flutter class `Widget`, or its subtype.
   bool get isWidgetExpression {
     return switch (this) {
       null => false,

pkg/analyzer/lib/src/wolf/ir/scope_analyzer.dart

@@ -58,7 +58,7 @@ base class ScopeAnalyzerEventListener {
   /// This call back is invoked before more specific callbacks like [onAlloc].
   void onInstruction(int address) {}
 
-  /// Called when [scopeAnalyzer] is about to process a "begin" instruction.
+  /// Called when [_scopeAnalyzer] is about to process a "begin" instruction.
   void onPushScope({required int address, required int scope}) {}
 
   /// Records that the value of a state variable was potentially affected.
@@ -110,7 +110,7 @@ class Scopes {
   /// Computes the innermost ancestor of [scope] (or [scope] itself), whose
   /// [endAddress] is greater than or equal to [address].
   ///
-  /// This method may be used in conjunction with [lastScopeBefore] to find the
+  /// This method may be used in conjunction with `lastScopeBefore` to find the
   /// innermost scope containing an instruction, according to the formula:
   ///
   ///     var scope = ancestorContainingAddress(

pkg/analyzer/lib/src/workspace/blaze_watcher.dart

@@ -92,7 +92,7 @@ class BlazeFilePoller {
   /// Tries polling all the possible paths.
   ///
   /// Will set [_validPath] and return its modified time if a file is found.
-  /// Returns [null] if nothing is found.
+  /// Returns `null` if nothing is found.
   FileInfo? _pollAll() {
     assert(_validPath == null);
     for (var path in _candidates) {
@@ -267,9 +267,7 @@ class BlazeFileWatcherIsolate {
 /// instantiating [BlazeFileWatcherService] is very cheap.
 ///
 /// The protocol when communicating with the isolate:
-/// 1. The watcher isolate sends to the main one a [BlazeWatcherIsolateStarted]
-///    and expects a [BlazeWatcherInitializeIsolate] to be sent from the main
-///    isolate as a reply.
+/// 1. The watcher isolate sends to the main one a [BlazeWatcherIsolateStarted].
 /// 2. The main isolate can request to start watching a file by sending
 ///    [BlazeWatcherStartWatching] request. There is no response expected.
 /// 3. The watcher isolate will send a [BlazeWatcherEvents] notification when

pkg/analyzer/lib/src/workspace/pub.dart

@@ -96,8 +96,8 @@ class PackageConfigFileUriResolver extends ResourceUriResolver {
   }
 }
 
-/// The [UriResolver] that can resolve `package` URIs in
-/// [PackageBuildWorkspace].
+/// The [UriResolver] that can resolve `package` URIs in a
+/// [PackageConfigWorkspace].
 class PackageConfigPackageUriResolver extends UriResolver {
   final PackageConfigWorkspace _workspace;
   final UriResolver _normalUriResolver;