Revert "[diagnostics] fix removed_lint reporting"

This reverts commit a9f288a.

Reason for revert: Flutter roll blocking

Original change's description:
> [diagnostics] fix `removed_lint` reporting
>
> Bug: #59869
> Change-Id: I0b69f4380e0b556f6612294a3c6485cebd5e56fd
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407621
> Reviewed-by: Brian Wilkerson <[email protected]>
> Commit-Queue: Phil Quitslund <[email protected]>

Bug: #59869
Change-Id: I70063e64bd5c5792c57e8194416a4a0d2e6df8ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/408400
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>

Author: pq

pkg/analyzer/lib/src/lint/options_rule_validator.dart

@@ -40,17 +40,9 @@ class LinterRuleOptionsValidator extends OptionsValidator {
   bool isDeprecatedInCurrentSdk(DeprecatedState state) =>
       currentSdkAllows(state.since);
 
-  bool isRemovedInCurrentOrEarlierSdk(State state) {
+  bool isRemovedInCurrentSdk(State state) {
     if (state is! RemovedState) return false;
-
-    var removed = state.since;
-    // No "since" applies to all SDKs.
-    if (removed == null) return true;
-
-    return switch (sdkVersionConstraint) {
-      VersionRange(min: var min?) => removed <= min,
-      _ => false
-    };
+    return currentSdkAllows(state.since);
   }
 
   @override
@@ -124,7 +116,7 @@ class LinterRuleOptionsValidator extends OptionsValidator {
               arguments: [value],
             );
           }
-        } else if (isRemovedInCurrentOrEarlierSdk(state)) {
+        } else if (isRemovedInCurrentSdk(state)) {
           var since = state.since.toString();
           var replacedBy = (state as RemovedState).replacedBy;
           if (replacedBy != null) {

pkg/analyzer/test/src/options/options_rule_validator_test.dart

@@ -200,19 +200,6 @@ linter:
     );
   }
 
-  /// https://github.com/dart-lang/sdk/issues/59869
-  test_removed_rule_previousSdk() {
-    assertErrors(
-      '''
-linter:
-  rules:
-    - removed_in_2_12_lint
-''',
-      [AnalysisOptionsWarningCode.REMOVED_LINT],
-      sdk: dart3_3,
-    );
-  }
-
   test_replaced_rule() {
     assertErrors(
       '''