Enable no_literal_bool_comparisons in the analyzer.

Change-Id: Ib6d534331ab91fe03f9d8292c2aa946d5599387a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440202
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/analysis_options.yaml

@@ -55,6 +55,7 @@ linter:
     - avoid_unused_constructor_parameters
     - discarded_futures
     - flutter_style_todos
+    - no_literal_bool_comparisons
     - unawaited_futures
     - unnecessary_breaks
     - unnecessary_final

pkg/analyzer/lib/src/dart/analysis/search.dart

@@ -1752,7 +1752,7 @@ class _LocalReferencesVisitor extends RecursiveAstVisitor<void> {
   }
 
   void _addResult(SyntacticEntity entity, SearchResultKind kind) {
-    bool isQualified = entity is AstNode ? entity.parent is Label : false;
+    bool isQualified = entity is AstNode && entity.parent is Label;
     var enclosingFragment = _getEnclosingFragment(
       enclosingLibraryFragment,
       entity.offset,

pkg/analyzer/lib/src/dart/ast/constant_evaluator.dart

@@ -244,7 +244,7 @@ class ConstantEvaluator extends GeneralizingAstVisitor<Object> {
   }
 
   @override
-  Object? visitBooleanLiteral(BooleanLiteral node) => node.value ? true : false;
+  Object? visitBooleanLiteral(BooleanLiteral node) => node.value;
 
   @override
   Object? visitDoubleLiteral(DoubleLiteral node) => node.value;

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -695,7 +695,7 @@ class ConstantVisitor extends UnifyingAstVisitor<Constant> {
       }
       return _dartObjectComputer.lazyOr(node, leftResult, computeRightOperand);
     } else if (operatorType == TokenType.QUESTION_QUESTION) {
-      if (leftResult.isNull != true) {
+      if (!leftResult.isNull) {
         var error = _reportNotPotentialConstants(node.rightOperand);
         if (error is InvalidConstant) {
           return error;

pkg/analyzer/lib/src/dart/element/type_algebra.dart

@@ -369,7 +369,7 @@ abstract class _TypeSubstitutor
   int useCounter = 0;
 
   _TypeSubstitutor(this.outer) {
-    covariantContext = outer == null ? true : outer!.covariantContext;
+    covariantContext = outer == null || outer!.covariantContext;
   }
 
   void bumpCountersUntil(_TypeSubstitutor target) {

pkg/analyzer/lib/src/error/null_safe_api_verifier.dart

@@ -50,7 +50,7 @@ class NullSafeApiVerifier {
 
     var targetClass = targetType.element;
 
-    if (targetClass.library.isDartAsync == true &&
+    if (targetClass.library.isDartAsync &&
         targetClass.name == 'Completer' &&
         node.methodName.name == 'complete') {
       _checkTypes(

pkg/analyzer/lib/src/fasta/doc_comment_builder.dart

@@ -929,9 +929,7 @@ final class _BlockDocDirectiveBuilder {
   /// Whether this doc directive's opening tag is the opposing tag for [tag].
   bool matches(DocDirectiveTag tag) {
     var openingTag = this.openingTag;
-    return openingTag == null
-        ? false
-        : openingTag.type.opposingName == tag.type.name;
+    return openingTag != null && openingTag.type.opposingName == tag.type.name;
   }
 
   void push(DocDirective docDirective) => innerDocDirectives.add(docDirective);

pkg/analyzer/lib/src/generated/ffi_verifier.dart

@@ -1376,9 +1376,8 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
     } else if (nativeReturnType == _PrimitiveDartType.bool) {
       return dartType.isDartCoreBool;
     } else if (nativeReturnType == _PrimitiveDartType.void_) {
-      return direction == _FfiTypeCheckDirection.dartToNative
-          ? true
-          : dartType is VoidType;
+      return direction == _FfiTypeCheckDirection.dartToNative ||
+          dartType is VoidType;
     } else if (dartType is VoidType) {
       // Don't allow other native subtypes if the Dart return type is void.
       return nativeReturnType == _PrimitiveDartType.void_;