Fine. Record const/final/late for fields and top-level variables

Teach the fine-grained manifest to capture field/variable modifiers that
affect API shape and const semantics. Add `isConst`, `isFinal`, and
`isLate` to `InstanceItemFieldItem` and `TopLevelVariableItem`, and
thread them through encoding, decoding, and matching.

- Add the three flags to the two item types and populate them from element properties.
- Persist the flags in summaries (read/write three booleans) and compare
  them in `match()` to detect modifier-only changes that impact the API
  (e.g. `final` vs `var` alters setter presence; `const` affects
  constantness).
- Correct the serialization tag for `InstanceItemFieldItem` to write
  `_InstanceItemMemberItemKind.field` (it previously wrote `getter`).
- Bump `AnalysisDriver.DATA_VERSION` to 529 to invalidate stale caches.

This makes manifest matching reflect modifier-driven API differences
more accurately and prevents incorrect bundle reuse when only
`const`/`final`/ `late` change.

Change-Id: I4249456fefdd5763adc5ba294cbf25e32f86511f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447943
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 528;
+  static const int DATA_VERSION = 529;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -492,13 +492,19 @@ sealed class InstanceItem<E extends InstanceElementImpl>
 }
 
 class InstanceItemFieldItem extends InstanceItemMemberItem<FieldElementImpl> {
+  final bool isConst;
+  final bool isFinal;
+  final bool isLate;
   final ManifestType type;
   final ManifestNode? constInitializer;
 
   InstanceItemFieldItem({
     required super.id,
     required super.metadata,
     required super.isStatic,
+    required this.isConst,
+    required this.isFinal,
+    required this.isLate,
     required this.type,
     required this.constInitializer,
   });
@@ -512,6 +518,9 @@ class InstanceItemFieldItem extends InstanceItemMemberItem<FieldElementImpl> {
       id: id,
       metadata: ManifestMetadata.encode(context, element.metadata),
       isStatic: element.isStatic,
+      isConst: element.isConst,
+      isFinal: element.isFinal,
+      isLate: element.isLate,
       type: element.type.encode(context),
       constInitializer: element.constantInitializer?.encode(context),
     );
@@ -522,6 +531,9 @@ class InstanceItemFieldItem extends InstanceItemMemberItem<FieldElementImpl> {
       id: ManifestItemId.read(reader),
       metadata: ManifestMetadata.read(reader),
       isStatic: reader.readBool(),
+      isConst: reader.readBool(),
+      isFinal: reader.readBool(),
+      isLate: reader.readBool(),
       type: ManifestType.read(reader),
       constInitializer: ManifestNode.readOptional(reader),
     );
@@ -530,20 +542,26 @@ class InstanceItemFieldItem extends InstanceItemMemberItem<FieldElementImpl> {
   @override
   bool match(MatchContext context, FieldElementImpl element) {
     return super.match(context, element) &&
+        isConst == element.isConst &&
+        isFinal == element.isFinal &&
+        isLate == element.isLate &&
         type.match(context, element.type) &&
         constInitializer.match(context, element.constantInitializer);
   }
 
   @override
   void write(BufferedSink sink) {
     super.write(sink);
+    sink.writeBool(isConst);
+    sink.writeBool(isFinal);
+    sink.writeBool(isLate);
     type.write(sink);
     constInitializer.writeOptional(sink);
   }
 
   @override
   void writeKind(BufferedSink sink) {
-    sink.writeEnum(_InstanceItemMemberItemKind.getter);
+    sink.writeEnum(_InstanceItemMemberItemKind.field);
   }
 
   static Map<LookupName, InstanceItemFieldItem> readMap(
@@ -1323,12 +1341,18 @@ class TopLevelSetterItem extends TopLevelItem<SetterElementImpl> {
 }
 
 class TopLevelVariableItem extends TopLevelItem<TopLevelVariableElementImpl> {
+  final bool isConst;
+  final bool isFinal;
+  final bool isLate;
   final ManifestType type;
   final ManifestNode? constInitializer;
 
   TopLevelVariableItem({
     required super.id,
     required super.metadata,
+    required this.isConst,
+    required this.isFinal,
+    required this.isLate,
     required this.type,
     required this.constInitializer,
   });
@@ -1341,6 +1365,9 @@ class TopLevelVariableItem extends TopLevelItem<TopLevelVariableElementImpl> {
     return TopLevelVariableItem(
       id: id,
       metadata: ManifestMetadata.encode(context, element.metadata),
+      isConst: element.isConst,
+      isFinal: element.isFinal,
+      isLate: element.isLate,
       type: element.type.encode(context),
       constInitializer: element.constantInitializer?.encode(context),
     );
@@ -1350,6 +1377,9 @@ class TopLevelVariableItem extends TopLevelItem<TopLevelVariableElementImpl> {
     return TopLevelVariableItem(
       id: ManifestItemId.read(reader),
       metadata: ManifestMetadata.read(reader),
+      isConst: reader.readBool(),
+      isFinal: reader.readBool(),
+      isLate: reader.readBool(),
       type: ManifestType.read(reader),
       constInitializer: ManifestNode.readOptional(reader),
     );
@@ -1358,13 +1388,19 @@ class TopLevelVariableItem extends TopLevelItem<TopLevelVariableElementImpl> {
   @override
   bool match(MatchContext context, TopLevelVariableElementImpl element) {
     return super.match(context, element) &&
+        isConst == element.isConst &&
+        isFinal == element.isFinal &&
+        isLate == element.isLate &&
         type.match(context, element.type) &&
         constInitializer.match(context, element.constantInitializer);
   }
 
   @override
   void write(BufferedSink sink) {
     super.write(sink);
+    sink.writeBool(isConst);
+    sink.writeBool(isFinal);
+    sink.writeBool(isLate);
     type.write(sink);
     constInitializer.writeOptional(sink);
   }