Skip to content

Commit 51fee27

Browse files
nshahanCommit Queue
authored andcommitted
[ddc] Update DDC snapshot training target
Specify package_config.json when running DDC JIT snapshot training. This allows the build to succeed in environments where the running compiler would go searching for the package_config.json and find one in some parent directory. This should fix local web engine builds in Flutter which likely broke when the repo was migrated to a pub workspace. Change-Id: Ifb5b6357cbf40f04069020ab1b4aee099d0945ed Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438602 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>
1 parent a3b7c6f commit 51fee27

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

build/rbe/rewrapper_dart.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -433,6 +433,8 @@ def parse_dartdevc(self):
433433
self.rebase(self.optarg.replace('.js', '.dill')))
434434
elif self.get_option(['--dart-sdk-summary']):
435435
self.extra_paths.add(self.rebase(self.optarg))
436+
elif self.get_option(['--packages']):
437+
self.extra_paths.add(self.rebase(self.optarg))
436438
elif self.get_option([
437439
'--multi-root-scheme', '--multi-root-output-path',
438440
'--modules'

utils/ddc/BUILD.gn

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ application_snapshot("dartdevc") {
4040
main_dart = "../../pkg/dev_compiler/bin/dartdevc.dart"
4141

4242
training_args = [
43+
"--packages",
44+
rebase_path("../../.dart_tool/package_config.json"),
4345
"--dart-sdk-summary",
4446
rebase_path(sdk_outline_dill),
4547
"-o",

0 commit comments

Comments
 (0)