[DAS] Fixes extension instance member occurrences

Fixes: #60626
Change-Id: Ia1050fe54f9c2ff208092b00ecccce678b7e616a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424688
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart

@@ -306,8 +306,10 @@ class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor<void> {
     Element? canonicalElement = element;
     if (canonicalElement is FieldFormalParameterElement) {
       canonicalElement = canonicalElement.field2;
-    } else if (canonicalElement is PropertyAccessorElement) {
-      canonicalElement = canonicalElement.variable3;
+    } else if (canonicalElement case PropertyAccessorElement(
+      :var variable3?,
+    ) when !variable3.isSynthetic) {
+      canonicalElement = variable3;
     }
     return canonicalElement?.baseElement;
   }

pkg/analysis_server/test/analysis/notification_occurrences_test.dart

@@ -177,7 +177,7 @@ void f(E e) {
   }
 
   Future<void> test_enum_getter() async {
-    await assertOccurrences(kind: ElementKind.FIELD, '''
+    await assertOccurrences(kind: ElementKind.GETTER, '''
 enum E {
   v;
   int get /*[0*/foo/*0]*/ => 0;
@@ -203,7 +203,7 @@ void f(E e) {
   }
 
   Future<void> test_enum_setter() async {
-    await assertOccurrences(kind: ElementKind.FIELD, '''
+    await assertOccurrences(kind: ElementKind.SETTER, '''
 enum E {
   v;
   set /*[0*/foo/*0]*/(int _) {}
@@ -227,6 +227,35 @@ extension /*[1*/E/*1]*/<ThisType> on ThisType {
 ''');
   }
 
+  Future<void> test_extensionMember() async {
+    await assertOccurrences(kind: ElementKind.GETTER, '''
+extension on int {
+  int get /*[0*/foo/*0]*/ => 0;
+}
+
+void f(int v) {
+  v./*[1*/foo/*1]*/;
+}
+''');
+  }
+
+  Future<void> test_extensionMember_diferenciation() async {
+    await assertOccurrences(kind: ElementKind.GETTER, '''
+extension on String {
+  int get foo => 0;
+}
+
+extension on int {
+  int get /*[0*/foo/*0]*/ => 0;
+}
+
+void f(int v, String s) {
+  v./*[1*/foo/*1]*/;
+  s.foo;
+}
+''');
+  }
+
   Future<void> test_extensionType() async {
     await assertOccurrences(kind: ElementKind.EXTENSION_TYPE, '''
 extension type /*[0*/E/*0]*/(int it) {}
@@ -266,7 +295,7 @@ void f() {
   }
 
   Future<void> test_extensionType_getter() async {
-    await assertOccurrences(kind: ElementKind.FIELD, '''
+    await assertOccurrences(kind: ElementKind.GETTER, '''
 extension type E(int it) {
   int get /*[0*/foo/*0]*/ => 0;
 }
@@ -290,7 +319,7 @@ void f(E e) {
   }
 
   Future<void> test_extensionType_setter() async {
-    await assertOccurrences(kind: ElementKind.FIELD, '''
+    await assertOccurrences(kind: ElementKind.SETTER, '''
 extension type E(int it) {
   set /*[0*/foo/*0]*/(int _) {}
 }
@@ -524,7 +553,7 @@ void f() {
   }
 
   Future<void> test_pattern_object_fieldName() async {
-    await assertOccurrences(kind: ElementKind.FIELD, '''
+    await assertOccurrences(kind: ElementKind.GETTER, '''
 double calculateArea(Shape shape) =>
   switch (shape) {
     Square(/*[0*/length/*0]*/: var l) => l * l,