Elements. Remove LocalVariableFragment.nameOffset

It was deprecated in https://dart-review.googlesource.com/c/sdk/+/440141

Change-Id: Id63129f32baf1efe778d5be20e13b11f5224b69a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440120
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart

@@ -636,7 +636,7 @@ class _ParametersCollector extends RecursiveAstVisitor<void> {
         );
       }
     } else if (element is LocalVariableElement) {
-      if (!expressionRange.contains(element.firstFragment.nameOffset)) {
+      if (!expressionRange.contains(element.firstFragment.nameOffset2!)) {
         if (node.inSetterContext()) {
           status.addError("Write to '$elementName' cannot be extracted.");
         } else {

pkg/analyzer/CHANGELOG.md

@@ -8,6 +8,7 @@
 * Remove deprecated `PromotableElement` and `PromotableFragment`.
 * Remove deprecated `LocalVariableElement.hasInitializer`.
 * Remove deprecated `LocalVariableFragment.hasInitializer`.
+* Remove deprecated `LocalVariableFragment.nameOffset`.
 * `LibraryFragment` is not `Annotatable` anymore.
 * Stop implementing `ConstantEvaluationTarget` by `ElementAnnotation`.
   This is an internal interface that should not have been exposed.

pkg/analyzer/api.txt

@@ -3913,7 +3913,6 @@ package:analyzer/dart/element/element.dart:
   LocalVariableFragment (class extends Object implements VariableFragment, LocalFragment):
     new (constructor: LocalVariableFragment Function())
     element (getter: LocalVariableElement)
-    nameOffset (getter: int)
     nextFragment (getter: LocalVariableFragment?)
     previousFragment (getter: LocalVariableFragment?)
   Metadata (class extends Object):

pkg/analyzer/lib/dart/element/element.dart

@@ -3069,9 +3069,6 @@ abstract class LocalVariableFragment
   @override
   LocalVariableElement get element;
 
-  /// The offset of the name in this element.
-  int get nameOffset;
-
   @override
   LocalVariableFragment? get nextFragment;
 

pkg/analyzer/lib/src/dart/element/element.dart

@@ -7278,9 +7278,6 @@ class LocalVariableFragmentImpl extends NonParameterVariableFragmentImpl
   @override
   MetadataImpl get metadata2 => metadata;
 
-  @override
-  int get nameOffset => firstTokenOffset!;
-
   @override
   LocalVariableFragmentImpl? get nextFragment => null;