[dart2js, ddc] Remove LEGACY support from rti.

- Remove support for `JS_GET_FLAG('LEGACY')` from backends
- Remove `kindStar` Rtis
- Remove `Recipe.wrapStar`

Bug: #60327
Change-Id: I2ec9b0afc9f3cd99fc6167600e6d908c9771af1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416101
Reviewed-by: Nicholas Shahan <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>

Author: fishythefish

pkg/compiler/lib/src/kernel/transformations/global/js_get_flag_lowering.dart

@@ -58,7 +58,6 @@ class JsGetFlagLowering {
     'USE_CONTENT_SECURITY_POLICY' =>
       _options.features.useContentSecurityPolicy.isEnabled,
     'VARIANCE' => _options.enableVariance,
-    'LEGACY' => _options.useLegacySubtyping,
     _ => null,
   };
 

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -776,7 +776,6 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     if (_isBuildingSdk) {
       var prerequisiteRtiTypes = [
         _coreTypes.objectNullableRawType,
-        NeverType.legacy()
       ];
       prerequisiteRtiTypes.forEach((type) {
         var recipe = _typeRecipeGenerator
@@ -6152,9 +6151,6 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
           var value = flag.value;
           return switch (value) {
             'DEV_COMPILER' => js.boolean(true),
-            // TODO(nshahan): Delete 'LEGACY' after uses are deleted from
-            // dart:_rti.
-            'LEGACY' => js.boolean(false),
             'MINIFIED' => js.boolean(false),
             'VARIANCE' =>
               // Variance is turned on by default, but only interfaces that have

pkg/dev_compiler/lib/src/kernel/compiler_new.dart

@@ -953,7 +953,6 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     if (_isSdkInternalRuntime(_currentLibrary!)) {
       var prerequisiteRtiTypes = [
         _coreTypes.objectNullableRawType,
-        NeverType.legacy()
       ];
       prerequisiteRtiTypes.forEach((type) {
         var recipe = _typeRecipeGenerator
@@ -6600,9 +6599,6 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
           var value = flag.value;
           return switch (value) {
             'DEV_COMPILER' => js.boolean(true),
-            // TODO(nshahan): Delete 'LEGACY' after uses are deleted from
-            // dart:_rti.
-            'LEGACY' => js.boolean(false),
             'MINIFIED' => js.boolean(false),
             'VARIANCE' =>
               // Variance is turned on by default, but only interfaces that have

pkg/dev_compiler/lib/src/kernel/type_recipe_generator.dart

@@ -565,7 +565,7 @@ class _TypeRecipeVisitor extends DartTypeVisitor<String> {
       case Nullability.nonNullable:
         return '';
       case Nullability.legacy:
-        return Recipe.wrapStarString;
+        throw UnsupportedError('Legacy nullability.');
     }
   }
 

pkg/js_shared/lib/synced/recipe_syntax.dart

@@ -28,8 +28,6 @@ abstract class Recipe {
   static const int pushVoid = _tilde;
   static const String pushVoidString = _tildeString;
 
-  static const int wrapStar = _asterisk;
-  static const String wrapStarString = _asteriskString;
   static const int wrapQuestion = _question;
   static const String wrapQuestionString = _questionString;
   static const int wrapFutureOr = _slash;
@@ -187,7 +185,6 @@ abstract class Recipe {
     test("pushErased", pushErased, pushErasedString);
     test("pushDynamic", pushDynamic, pushDynamicString);
     test("pushVoid", pushVoid, pushVoidString);
-    test("wrapStar", wrapStar, wrapStarString);
     test("wrapQuestion", wrapQuestion, wrapQuestionString);
     test("wrapFutureOr", wrapFutureOr, wrapFutureOrString);
     test("startTypeArguments", startTypeArguments, startTypeArgumentsString);

sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart

@@ -604,7 +604,7 @@ _checkAndCall(f, ftype, obj, typeArgs, args, named, displayName) {
       for (var i = 0; i < typeParameterCount; i++) {
         var bound = JS<rti.Rti>('!', '#[#]', typeParameterBounds, i);
         var typeArg = JS<rti.Rti>('!', '#[#]', typeArgs, i);
-        if (bound != typeArg && !rti.isSoundTopType(bound)) {
+        if (bound != typeArg && !rti.isTopType(bound)) {
           var instantiatedBound = rti.substitute(bound, typeArgs);
           var validSubtype = rti.isSubtype(
             JS_EMBEDDED_GLOBAL('', RTI_UNIVERSE),

sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/runtime.dart

@@ -66,8 +66,8 @@ import 'dart:_rti'
         interfaceTypeRecipePropertyName,
         isGenericFunctionType,
         isRecordType,
-        isSoundTopType,
         isSubtype,
+        isTopType,
         Rti,
         rtiToString,
         substitute;

sdk/lib/_internal/js_runtime/lib/internal_patch.dart

@@ -13,10 +13,7 @@ import 'dart:typed_data' show Uint8List;
 
 @patch
 @pragma('dart2js:tryInline')
-bool typeAcceptsNull<T>() {
-  bool isLegacySubtyping = JS_GET_FLAG('LEGACY');
-  return isLegacySubtyping || null is T;
-}
+bool typeAcceptsNull<T>() => null is T;
 
 @patch
 class Symbol implements core.Symbol {

sdk/lib/_internal/js_runtime/lib/js_array.dart

@@ -121,13 +121,19 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
   @pragma('dart2js:prefer-inline')
   static List<T> markFixedList<T>(List<T> list) {
     return JS(
-        'JSFixedArray', '#', HArrayFlagsSet(list, ArrayFlags.fixedLength));
+      'JSFixedArray',
+      '#',
+      HArrayFlagsSet(list, ArrayFlags.fixedLength),
+    );
   }
 
   @pragma('dart2js:prefer-inline')
   static List<T> markUnmodifiableList<T>(List list) {
-    return JS('JSUnmodifiableArray', '#',
-        HArrayFlagsSet(list, ArrayFlags.unmodifiable));
+    return JS(
+      'JSUnmodifiableArray',
+      '#',
+      HArrayFlagsSet(list, ArrayFlags.unmodifiable),
+    );
   }
 
   static bool isFixedLength(JSArray a) {
@@ -149,7 +155,12 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
   checkMutable(String operation, String verb) {
     final int flags = HArrayFlagsGet(this);
     HArrayFlagsCheck(
-        this, flags, ArrayFlags.unmodifiableCheck, operation, verb);
+      this,
+      flags,
+      ArrayFlags.unmodifiableCheck,
+      operation,
+      verb,
+    );
   }
 
   checkGrowable(String operation, String verb) {
@@ -623,9 +634,8 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
     // with an assignment like `a[i] = a[j]`.
 
     int undefineds = 0;
-    // The element type might exclude the possibility of there being `null`s,
-    // but only in sound null safety mode.
-    if (JS_GET_FLAG('LEGACY') || null is E) {
+    // The element type might exclude the possibility of there being `null`s.
+    if (null is E) {
       for (int i = 0; i < length; i++) {
         final E element = JS('', '#[#]', this, i);
         if (JS('', '# === void 0', element)) {
@@ -726,9 +736,10 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
   List<E> toList({bool growable = true}) =>
       growable ? _toListGrowable() : _toListFixed();
 
-  List<E> _toListGrowable() =>
-      // slice(0) is slightly faster than slice()
-      JSArray<E>.markGrowable(JS('', '#.slice(0)', this));
+  List<E> _toListGrowable() {
+    // slice(0) is slightly faster than slice()
+    return JSArray<E>.markGrowable(JS('', '#.slice(0)', this));
+  }
 
   List<E> _toListFixed() => JSArray<E>.markFixed(JS('', '#.slice(0)', this));
 
@@ -768,8 +779,10 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
   void _setLengthUnsafe(int newLength) {
     assert(newLength is int, throw ArgumentError.value(newLength, 'newLength'));
 
-    assert(newLength >= 0,
-        throw RangeError.range(newLength, 0, null, 'newLength'));
+    assert(
+      newLength >= 0,
+      throw RangeError.range(newLength, 0, null, 'newLength'),
+    );
 
     // JavaScript with throw a RangeError for numbers that are too big. The
     // message does not contain the value.
@@ -785,8 +798,12 @@ class JSArray<E> extends JavaScriptObject implements List<E>, JSIndexable<E> {
 
   void operator []=(int index, E value) {
     final int flags = HArrayFlagsGet(this);
-    final checked =
-        HArrayFlagsCheck(this, flags, ArrayFlags.unmodifiableCheck, '[]=');
+    final checked = HArrayFlagsCheck(
+      this,
+      flags,
+      ArrayFlags.unmodifiableCheck,
+      '[]=',
+    );
 
     if (index is! int) throw diagnoseIndexError(this, index);
     // This form of the range test correctly rejects NaN.
@@ -864,9 +881,9 @@ class ArrayIterator<E> implements Iterator<E> {
   E? _current;
 
   ArrayIterator(JSArray<E> iterable)
-      : _iterable = iterable,
-        _length = iterable.length,
-        _index = 0;
+    : _iterable = iterable,
+      _length = iterable.length,
+      _index = 0;
 
   E get current => _current as E;