Remove deprecated RecordType.positionalTypes/sortedNamedTypes

Change-Id: I9fd4768abe3956a7e82291de3f8a2f0b9f606959
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423602
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/CHANGELOG.md

@@ -1,6 +1,8 @@
 ## 8.0.0-dev
 * Remove deprecated element model V1.
 * Remove deprecated `DartType.isStructurallyEqualTo`.
+* Remove deprecated `RecordType.positionalTypes`.
+* Remove deprecated `RecordType.sortedNamedTypes`.
 
 ## 7.4.1
 * Restore `InstanceElement.augmented` getter.

pkg/analyzer/api.txt

@@ -3924,8 +3924,6 @@ package:analyzer/dart/element/type.dart:
     element3 (getter: Null)
     namedFields (getter: List<RecordTypeNamedField>)
     positionalFields (getter: List<RecordTypePositionalField>)
-    positionalTypes (getter: List<DartType>, deprecated)
-    sortedNamedTypes (getter: List<RecordTypeNamedField>, deprecated)
   RecordTypeField (class extends Object):
     new (constructor: RecordTypeField Function())
     type (getter: DartType)

pkg/analyzer/lib/dart/element/type.dart

@@ -448,24 +448,6 @@ abstract class RecordType implements DartType {
 
   /// The positional fields (might be empty).
   List<RecordTypePositionalField> get positionalFields;
-
-  /// The types of the positional fields (might be empty).
-  ///
-  /// Deprecated: this getter is a part of the analyzer's private
-  /// implementation, and was exposed by accident (see
-  /// https://github.com/dart-lang/sdk/issues/59763). Please use
-  /// [positionalFields] instead.
-  @Deprecated('Use positionalFields instead')
-  List<DartType> get positionalTypes;
-
-  /// All the named fields, sorted by name (might be empty).
-  ///
-  /// Deprecated: this getter is a part of the analyzer's private
-  /// implementation, and was exposed by accident (see
-  /// https://github.com/dart-lang/sdk/issues/59763). Please use [namedFields]
-  /// instead.
-  @Deprecated('Use namedFields instead')
-  List<RecordTypeNamedField> get sortedNamedTypes;
 }
 
 /// A field in a [RecordType].

pkg/analyzer/lib/src/dart/element/type.dart

@@ -1231,7 +1231,7 @@ class RecordTypeImpl extends TypeImpl implements RecordType, SharedRecordType {
   final NullabilitySuffix nullabilitySuffix;
 
   @override
-  late final List<TypeImpl> positionalTypes = [
+  late final List<TypeImpl> positionalTypesShared = [
     for (var field in positionalFields) field.type,
   ];
 
@@ -1274,13 +1274,7 @@ class RecordTypeImpl extends TypeImpl implements RecordType, SharedRecordType {
   List<RecordTypeNamedFieldImpl> get namedTypes => namedFields;
 
   @override
-  List<TypeImpl> get positionalTypesShared => positionalTypes;
-
-  @override
-  List<RecordTypeNamedFieldImpl> get sortedNamedTypes => namedTypes;
-
-  @override
-  List<SharedNamedType> get sortedNamedTypesShared => sortedNamedTypes;
+  List<SharedNamedType> get sortedNamedTypesShared => namedTypes;
 
   @override
   bool operator ==(Object other) {