Skip to content

Commit 571bdd6

Browse files
stereotype441Commit Queue
authored andcommitted
[messages] Remove frontendInternal entries.
Removes `frontEndInternal: true` entries from the front end `messages.yaml` file, and updates `messages_suite.dart` so that they are not permitted. These entries were left over from when we used to try to require all front end diagnostics to have a corresponding `analyzerCode`; they identified diagnostics for which no `analyzerCode` was needed. Now that we don't include any `analyzerCode`s in the front end `messages.yaml` file, they have no effect and aren't needed anymore. Change-Id: I6a6a6964f3fd6e5623e98b4b85382d3e96b4c92d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458063 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent b2f262a commit 571bdd6

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

pkg/front_end/messages.yaml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@
8686
# as well as internal documentation (comment), which will be included in
8787
# the code generated for the analyzer.
8888
#
89-
# In some cases a message is internal to the frontend, and no meaningful
90-
# analyzer code can be provided. In such cases set `frontendInternal: true`.
91-
#
9289
# ## Parameter Substitution in problemMessage and correctionMessage
9390
#
9491
# The fields `problemMessage` and `correctionMessage` are subject to parameter
@@ -4255,7 +4252,6 @@ InitializeFromDillNotSelfContained:
42554252
Either way, you should probably delete the file so it doesn't use unnecessary disk space.
42564253
42574254
severity: WARNING
4258-
frontendInternal: true
42594255
external: test/incremental_load_from_invalid_dill_test.dart
42604256

42614257
InitializeFromDillNotSelfContainedNoDump:
@@ -4267,7 +4263,6 @@ InitializeFromDillNotSelfContainedNoDump:
42674263
The Dart team would greatly appreciate it if you would take a moment to report this problem at http://dartbug.com/new.
42684264
42694265
severity: WARNING
4270-
frontendInternal: true
42714266
external: test/incremental_load_from_invalid_dill_test.dart
42724267

42734268
InitializeFromDillUnknownProblem:
@@ -4287,7 +4282,6 @@ InitializeFromDillUnknownProblem:
42874282
Either way, you should probably delete the file so it doesn't use unnecessary disk space.
42884283
42894284
severity: WARNING
4290-
frontendInternal: true
42914285
external: test/incremental_load_from_invalid_dill_test.dart
42924286

42934287
InitializeFromDillUnknownProblemNoDump:
@@ -4304,7 +4298,6 @@ InitializeFromDillUnknownProblemNoDump:
43044298
The Dart team would greatly appreciate it if you would take a moment to report this problem at http://dartbug.com/new.
43054299
43064300
severity: WARNING
4307-
frontendInternal: true
43084301
external: test/incremental_load_from_invalid_dill_test.dart
43094302

43104303
WebLiteralCannotBeRepresentedExactly:
@@ -4632,7 +4625,6 @@ RedirectingFactoryIncompatibleTypeArgument:
46324625
SyntheticToken:
46334626
parameters: none
46344627
problemMessage: "This couldn't be parsed."
4635-
frontendInternal: true
46364628

46374629
IncorrectTypeArgument:
46384630
parameters:
@@ -4787,7 +4779,6 @@ TypeOrigin:
47874779
Name name: undocumented
47884780
Uri uri: undocumented
47894781
problemMessage: "'#name' is from '#uri'."
4790-
frontendInternal: true
47914782
external: test/type_labeler_test.dart
47924783

47934784
TypeOriginWithFileUri:
@@ -4796,25 +4787,21 @@ TypeOriginWithFileUri:
47964787
Uri uri: undocumented
47974788
Uri uri2: undocumented
47984789
problemMessage: "'#name' is from '#uri' ('#uri2')."
4799-
frontendInternal: true
48004790
external: test/type_labeler_test.dart
48014791

48024792
ObjectExtends:
48034793
parameters: none
48044794
problemMessage: "The class 'Object' can't have a superclass."
4805-
frontendInternal: true
48064795
external: test/object_supertype_test.dart
48074796

48084797
ObjectImplements:
48094798
parameters: none
48104799
problemMessage: "The class 'Object' can't implement anything."
4811-
frontendInternal: true
48124800
external: test/object_supertype_test.dart
48134801

48144802
ObjectMixesIn:
48154803
parameters: none
48164804
problemMessage: "The class 'Object' can't use mixins."
4817-
frontendInternal: true
48184805
external: test/object_supertype_test.dart
48194806

48204807
InstanceAndSynthesizedStaticConflict:

pkg/front_end/test/messages_suite.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,9 +322,6 @@ class MessageTestSuite extends ChainContext {
322322
}
323323
break;
324324

325-
case "frontendInternal":
326-
break;
327-
328325
case "analyzerCode":
329326
if (value is! String) {
330327
throw new ArgumentError(

0 commit comments

Comments
 (0)