Elements. Getter/Setter names can be null.

Change-Id: I64b49f594c982b68c33891bb710ec9e66a70e260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390940
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart

@@ -7,6 +7,7 @@ import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
+import 'package:analyzer/src/utilities/extensions/collection.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 
@@ -87,7 +88,7 @@ class AddMissingEnumLikeCaseClauses extends ResolvedCorrectionProducer {
         if (expression is Identifier) {
           var element = expression.element;
           if (element is GetterElement) {
-            caseNames.add(element.name);
+            caseNames.addIfNotNull(element.name);
           }
         } else if (expression is PropertyAccess) {
           caseNames.add(expression.propertyName.name);

pkg/analysis_server/lib/src/services/correction/dart/extract_local_variable.dart

@@ -90,8 +90,16 @@ class ExtractLocalVariable extends ResolvedCorrectionProducer {
     required Expression target,
     required Element2? targetProperty,
   }) async {
-    if (targetProperty is GetterElement &&
-        typeSystem.isPotentiallyNullable(targetProperty.returnType)) {
+    if (targetProperty is! GetterElement) {
+      return;
+    }
+
+    var propertyName = targetProperty.name;
+    if (propertyName == null) {
+      return;
+    }
+
+    if (typeSystem.isPotentiallyNullable(targetProperty.returnType)) {
       AstNode? enclosingNode = target;
       while (true) {
         if (enclosingNode == null || enclosingNode is FunctionBody) {
@@ -121,7 +129,6 @@ class ExtractLocalVariable extends ResolvedCorrectionProducer {
               }
 
               await builder.addDartFileEdit(file, (builder) {
-                var propertyName = targetProperty.name;
                 builder.addInsertion(ifLineOffset, (builder) {
                   builder.write(prefix);
                   builder.writeln('final $propertyName = $initializerCode;');

pkg/analysis_server/lib/src/services/correction/dart/shadow_field.dart

@@ -35,6 +35,11 @@ class ShadowField extends ResolvedCorrectionProducer {
       return;
     }
 
+    var fieldName = accessor.name;
+    if (fieldName == null) {
+      return;
+    }
+
     if (accessor.enclosingElement2 is! InterfaceElement2) {
       // TODO(brianwilkerson): Should we also require that the getter be synthetic?
       return;
@@ -64,7 +69,6 @@ class ShadowField extends ResolvedCorrectionProducer {
       return;
     }
 
-    var fieldName = accessor.name;
     var offset = statement.offset;
     var prefix = utils.getLinePrefix(offset);
     //

pkg/analysis_server/lib/src/services/search/hierarchy.dart

@@ -327,7 +327,7 @@ String? _getBaseName(Element element) {
 String? _getBaseName2(Element2 element) {
   if (element is SetterElement) {
     var name = element.name;
-    return name.substring(0, name.length - 1);
+    return name?.substring(0, name.length - 1);
   }
   return element.name;
 }

pkg/analyzer/lib/dart/element/element2.dart

@@ -990,7 +990,7 @@ abstract class GetterElement implements ExecutableElement2, FragmentedElement {
   GetterFragment? get firstFragment;
 
   @override
-  String get name;
+  String? get name;
 
   /// The field or top-level variable associated with this getter.
   ///
@@ -1013,7 +1013,7 @@ abstract class GetterFragment implements ExecutableFragment {
   // GetterElement get element;
 
   @override
-  String get name;
+  String? get name;
 
   /// The field or top-level variable associated with this getter.
   ///
@@ -1951,7 +1951,7 @@ abstract class SetterElement implements ExecutableElement2, FragmentedElement {
   SetterFragment? get firstFragment;
 
   @override
-  String get name;
+  String? get name;
 
   /// The field or top-level variable associated with this setter.
   ///
@@ -1974,7 +1974,7 @@ abstract class SetterFragment implements ExecutableFragment {
   // SetterElement get element;
 
   @override
-  String get name;
+  String? get name;
 
   /// The field or top-level variable associated with this setter.
   ///

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5028,7 +5028,7 @@ class GetterElementImpl extends ExecutableElementImpl2
   ElementKind get kind => ElementKind.GETTER;
 
   @override
-  String get name => firstFragment.name;
+  String? get name => firstFragment.name;
 
   @override
   PropertyInducingElement2? get variable3 => firstFragment.variable2?.element;
@@ -9730,7 +9730,13 @@ class SetterElementImpl extends ExecutableElementImpl2
       firstFragment.correspondingGetter2?.element as GetterElement?;
 
   @override
-  String get displayName => name.substring(0, name.length - 1);
+  String get displayName {
+    if (name case var name?) {
+      return name.substring(0, name.length - 1);
+    } else {
+      return '<null-name>';
+    }
+  }
 
   @override
   Element2? get enclosingElement2 => firstFragment.enclosingFragment?.element;
@@ -9742,7 +9748,7 @@ class SetterElementImpl extends ExecutableElementImpl2
   ElementKind get kind => ElementKind.SETTER;
 
   @override
-  String get name => firstFragment.name;
+  String? get name => firstFragment.name;
 
   @override
   PropertyInducingElement2? get variable3 => firstFragment.variable2?.element;