You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switch setter manifest entries from a single `valueType` to the full
`ManifestFunctionType`. This captures parameter covariantness and
metadata, which were previously omitted, and aligns setters with methods
and constructors that already use function types.
Key changes:
- Encode and match setter items using `element.type` (function type)
rather than `valueFormalParameter.type`.
- Serialize setters via `functionType.writeNoTag(...)` and read with
`ManifestFunctionType.read(...)`.
- Update the result printer to display `functionType` for setters.
- Bump `AnalysisDriver.DATA_VERSION` to invalidate incompatible caches.
Why: Recording the full function signature ensures that manifest IDs
change when parameter covariance or annotations change, improving
fidelity of fine-grained dependency tracking and reuse decisions. The
representation is now consistent across executable members.
Impact: Slight increase in serialized size and comparison work for
setters; expected to be negligible. No behavioral changes to analysis,
only more accurate change detection and manifest output.
Change-Id: I2a753d0cf0d41176f46683e5f4a30e432f968d8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448060
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
0 commit comments