[dart2wasm] Omit details in TypeErrors in --minify mode

This avoids passing down information to slow paths, making type checks
smaller.

Change-Id: I7071849b5bf08bb0744c8d5592fb258b78cbcc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404565
Reviewed-by: Ömer Ağacan <[email protected]>
Commit-Queue: Martin Kustermann <[email protected]>

Author: mkustermann

sdk/lib/_internal/wasm/lib/core_patch.dart

@@ -14,6 +14,7 @@ import "dart:_internal"
         jsonEncode,
         ListIterator,
         Lists,
+        minify,
         mix64,
         patch,
         POWERS_OF_TEN,

sdk/lib/_internal/wasm/lib/error_utils.dart

@@ -185,3 +185,15 @@ class _ErrorWithoutDetails implements Error {
 
   String toString() => _message;
 }
+
+const _TypeErrorWithoutDetails typeErrorWithoutDetails =
+    _TypeErrorWithoutDetails();
+
+class _TypeErrorWithoutDetails implements TypeError {
+  const _TypeErrorWithoutDetails();
+
+  StackTrace? get stackTrace => null;
+
+  String toString() =>
+      'Runtime type check failed (details omitted due to --minify)';
+}

sdk/lib/_internal/wasm/lib/type.dart

@@ -1508,7 +1508,7 @@ void _asSubtype(Object? o, bool onlyNullabilityCheck, _Type t) {
           ? _isNullabilityCheck(o, t.isDeclaredNullable)
           : _isSubtype(o, t);
   if (success) return;
-  _TypeError._throwAsCheckError(o, t);
+  _throwAsCheckError(o, t);
 }
 
 @pragma("wasm:entry-point")
@@ -1592,11 +1592,12 @@ void _asInterfaceSubtype2(
 }
 
 @pragma('wasm:never-inline')
-void _throwInterfaceTypeAsCheckError0(
+Never _throwInterfaceTypeAsCheckError0(
   Object? o,
   bool isDeclaredNullable,
   WasmI32 tId,
 ) {
+  if (minify) throw typeErrorWithoutDetails;
   final typeArguments = const WasmArray<_Type>.literal([]);
   _TypeError._throwAsCheckError(
     o,
@@ -1606,12 +1607,13 @@ void _throwInterfaceTypeAsCheckError0(
 
 @pragma("wasm:entry-point")
 @pragma('wasm:never-inline')
-void _throwInterfaceTypeAsCheckError1(
+Never _throwInterfaceTypeAsCheckError1(
   Object? o,
   bool isDeclaredNullable,
   WasmI32 tId,
   _Type typeArgument0,
 ) {
+  if (minify) throw typeErrorWithoutDetails;
   final typeArguments = WasmArray<_Type>.literal([typeArgument0]);
   _TypeError._throwAsCheckError(
     o,
@@ -1621,13 +1623,14 @@ void _throwInterfaceTypeAsCheckError1(
 
 @pragma("wasm:entry-point")
 @pragma('wasm:never-inline')
-void _throwInterfaceTypeAsCheckError2(
+Never _throwInterfaceTypeAsCheckError2(
   Object? o,
   bool isDeclaredNullable,
   WasmI32 tId,
   _Type typeArgument0,
   _Type typeArgument1,
 ) {
+  if (minify) throw typeErrorWithoutDetails;
   final typeArguments = WasmArray<_Type>.literal([
     typeArgument0,
     typeArgument1,
@@ -1640,18 +1643,26 @@ void _throwInterfaceTypeAsCheckError2(
 
 @pragma("wasm:entry-point")
 @pragma('wasm:never-inline')
-void _throwInterfaceTypeAsCheckError(
+Never _throwInterfaceTypeAsCheckError(
   Object? o,
   bool isDeclaredNullable,
   WasmI32 tId,
   WasmArray<_Type> typeArguments,
 ) {
+  if (minify) throw typeErrorWithoutDetails;
   _TypeError._throwAsCheckError(
     o,
     _InterfaceType(tId, isDeclaredNullable, typeArguments),
   );
 }
 
+@pragma("wasm:entry-point")
+@pragma('wasm:never-inline')
+Never _throwAsCheckError(Object? o, _Type type) {
+  if (minify) throw typeErrorWithoutDetails;
+  _TypeError._throwAsCheckError(o, type);
+}
+
 @pragma("wasm:entry-point")
 bool _verifyOptimizedTypeCheck(
   bool result,