[analysis_server] Dot shorthands: Hover work and tests.

Added some extra logic for handling dot shorthands in hovers. They should show the same information in the hover as if we had added the type in front of `.`.

Added a new line "Declared in:" to show the containing class information.

Bug: #59836, #60864
Change-Id: If159d53b7c4443d8a8311125ceef66c441d39d4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431944
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analysis_server/lib/src/computer/computer_hover.dart

@@ -112,11 +112,14 @@ class DartUnitHoverComputer {
   String? _elementDisplayString(AstNode node, Element? element) {
     var displayString = element?.displayString2(multiline: true);
 
-    if (displayString != null &&
-        node is InstanceCreationExpression &&
-        node.keyword == null) {
-      var prefix = node.isConst ? '(const) ' : '(new) ';
-      displayString = prefix + displayString;
+    if (displayString != null) {
+      if (node is InstanceCreationExpression && node.keyword == null) {
+        var prefix = node.isConst ? '(const) ' : '(new) ';
+        displayString = prefix + displayString;
+      } else if (node is DotShorthandConstructorInvocation) {
+        var prefix = node.isConst ? '(const) ' : '(new) ';
+        displayString = prefix + displayString;
+      }
     }
 
     return displayString;
@@ -134,6 +137,8 @@ class DartUnitHoverComputer {
         offset: node.constructorName.offset,
         length: node.constructorName.length,
       );
+    } else if (node is DotShorthandConstructorInvocation) {
+      return (offset: node.offset, length: node.length);
     } else if (node is ConstructorDeclaration) {
       var offset = node.returnType.offset;
       var end = node.name?.end ?? node.returnType.end;
@@ -237,6 +242,9 @@ class DartUnitHoverComputer {
         parent is ConstructorDeclaration &&
         parent.name != null) {
       return parent;
+    } else if (node is SimpleIdentifier &&
+        parent is DotShorthandConstructorInvocation) {
+      return parent;
     }
     return node;
   }
@@ -258,6 +266,11 @@ class DartUnitHoverComputer {
       if (staticType != null && staticType is DynamicType) {
         staticType = null;
       }
+    } else if (parent is DotShorthandInvocation && parent.memberName == node) {
+      staticType = parent.staticInvokeType;
+      if (staticType != null && staticType is DynamicType) {
+        staticType = null;
+      }
     } else if (node is PatternFieldName && parent is PatternField) {
       staticType = parent.pattern.matchedValueType;
     } else if (node is DartPattern) {

pkg/analysis_server/lib/src/lsp/handlers/handler_hover.dart

@@ -87,6 +87,14 @@ class HoverHandler
         ..writeln();
     }
 
+    var containingClassDescription = hover.containingClassDescription;
+    if (containingClassDescription != null &&
+        containingClassDescription.isNotEmpty) {
+      content
+        ..writeln('Declared in: `$containingClassDescription`')
+        ..writeln();
+    }
+
     // Source library.
     var containingLibraryName = hover.containingLibraryName;
     if (containingLibraryName != null && containingLibraryName.isNotEmpty) {

pkg/analysis_server/test/lsp/hover_test.dart

@@ -163,6 +163,188 @@ class HoverTest extends AbstractLspAnalysisServerTest {
   Future<void> test_dartDocPreference_unset() =>
       assertDocumentation(null, includesSummary: true, includesFull: true);
 
+  Future<void> test_dotShorthand_constructor_named() async {
+    var content = '''
+class A {
+  A.named();
+}
+void f() {
+  A a = [!.nam^ed()!];
+}
+''';
+    var expected = '''
+```dart
+(new) A A.named()
+```
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_constructor_named_const() async {
+    var content = '''
+class A {
+  const A.named();
+}
+void f() {
+  const A a = [!.nam^ed()!];
+}
+''';
+    var expected = '''
+```dart
+(const) A A.named()
+```
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_constructor_unnamed() async {
+    var content = '''
+class A {}
+void f() {
+  A a = [!.ne^w()!];
+}
+''';
+    var expected = '''
+```dart
+(new) A A()
+```
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_constructor_unnamed_const() async {
+    var content = '''
+class A {
+  const A();
+}
+void f() {
+  const A a = [!.ne^w()!];
+}
+''';
+    var expected = '''
+```dart
+(const) A A()
+```
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_method() async {
+    var content = '''
+class A {
+  static A method() => A();
+}
+void f() {
+  A a = .[!meth^od!]();
+}
+''';
+    var expected = '''
+```dart
+A method()
+```
+Type: `A Function()`
+
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_method_subclass() async {
+    var content = '''
+class A {
+  static B method() => B();
+}
+
+class B extends A {}
+
+void g(A a) {}
+
+void f() {
+  g(.[!met^hod!]());
+}
+''';
+    var expected = '''
+```dart
+B method()
+```
+Type: `B Function()`
+
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_propertyAccess() async {
+    var content = '''
+class A {
+  static A field = A();
+}
+void f() {
+  A a = .[!fie^ld!];
+}
+''';
+    var expected = '''
+```dart
+A get field
+```
+Type: `A`
+
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_propertyAccess_enum() async {
+    var content = '''
+enum A { one }
+void f() {
+  A a = .[!on^e!];
+}
+''';
+    var expected = '''
+```dart
+A get one
+```
+Type: `A`
+
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
+  Future<void> test_dotShorthand_propertyAccess_extensionType() async {
+    var content = '''
+extension type A(int x) {
+  static A get getter => A(1);
+}
+void f() {
+  A a = .[!gette^r!];
+}
+''';
+    var expected = '''
+```dart
+A get getter
+```
+Type: `A`
+
+Declared in: `A`
+
+*package:test/main.dart*''';
+    await assertStringContents(content, equals(expected));
+  }
+
   Future<void> test_enum_member() async {
     var content = '''
 enum MyEnum { one }
@@ -177,6 +359,8 @@ MyEnum get one
 ```
 Type: `MyEnum`
 
+Declared in: `MyEnum`
+
 *package:test/main.dart*''';
     await assertStringContents(content, equals(expected));
   }
@@ -195,6 +379,8 @@ List<MyEnum> get values
 ```
 Type: `List<MyEnum>`
 
+Declared in: `MyEnum`
+
 *package:test/main.dart*''';
     await assertStringContents(content, equals(expected));
   }
@@ -212,6 +398,8 @@ int get _
 ```
 Type: `int`
 
+Declared in: `A`
+
 *package:test/main.dart*''';
     await assertStringContents(content, equals(expected));
   }
@@ -460,6 +648,8 @@ int _()
 ```
 Type: `int Function()`
 
+Declared in: `A`
+
 *package:test/main.dart*''';
     await assertStringContents(content, equals(expected));
   }
@@ -749,6 +939,8 @@ String? get myField
 ```
 Type: `String?`
 
+Declared in: `A`
+
 *package:test/main.dart*
 '''.trim();
 
@@ -771,6 +963,8 @@ String get myGetter
 ```
 Type: `String`
 
+Declared in: `A`
+
 *package:test/main.dart*
 '''.trim();
 
@@ -794,6 +988,8 @@ String? get myGetter
 ```
 Type: `String?`
 
+Declared in: `A`
+
 *package:test/main.dart*
 '''.trim();
 
@@ -818,6 +1014,8 @@ set mySetter(String value)
 ```
 Type: `String`
 
+Declared in: `A`
+
 *package:test/main.dart*
 '''.trim();
 
@@ -842,6 +1040,8 @@ set mySetter(String value)
 ```
 Type: `String`
 
+Declared in: `A`
+
 *package:test/main.dart*
 '''.trim();