Skip to content

Commit 5ae4277

Browse files
johnniwintherCommit Queue
authored andcommitted
[vm/wasm] Fix patches
Remove invalid @patch annotations and add explicit bound to Expando patches This is in preparation for a change in how the CFE handles patches as parts instead of libraries. TEST=ci Change-Id: Ie3f3e5053870ce4f131404200c64b536e647a7ca Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413220 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Johnni Winther <[email protected]>
1 parent 2d84bd8 commit 5ae4277

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

sdk/lib/_internal/vm/lib/concurrent_patch.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ base class _MutexImpl extends NativeFieldWrapperClass1 implements Mutex {
2222
@Native<Void Function(Handle)>(symbol: "Mutex_Initialize")
2323
external void _initialize();
2424

25-
@patch
2625
@Native<Handle Function(Handle, Handle)>(symbol: "Mutex_RunLocked")
2726
external Object _runLocked(Object action);
2827

@@ -48,15 +47,12 @@ base class _ConditionVariableImpl extends NativeFieldWrapperClass1
4847
@Native<Void Function(Handle)>(symbol: "ConditionVariable_Initialize")
4948
external void _initialize();
5049

51-
@patch
5250
@Native<Void Function(Handle, Handle)>(symbol: "ConditionVariable_Wait")
5351
external void wait(Mutex mutex);
5452

55-
@patch
5653
@Native<Void Function(Handle)>(symbol: "ConditionVariable_Notify")
5754
external void notify();
5855

59-
@patch
6056
@Native<Void Function(Handle)>(symbol: "ConditionVariable_NotifyAll")
6157
external void notifyAll();
6258
}

sdk/lib/_internal/vm/lib/expando_patch.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ void _rehashObjects(List objects) {
1616

1717
@patch
1818
@pragma("vm:entry-point")
19-
class Expando<T> {
19+
class Expando<T extends Object> {
2020
@patch
2121
Expando([String? name])
2222
: name = name,

sdk/lib/_internal/wasm/lib/weak_patch.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ void _checkValidWeakTarget(Object object) {
2626
}
2727

2828
@patch
29-
class Expando<T> {
29+
class Expando<T extends Object> {
3030
WasmExternRef? _jsWeakMap;
3131

3232
@patch

0 commit comments

Comments
 (0)