Fine. Don't include inherited private members.

When they are from different libraries, they can create conflicts.

But we don't need them even when they are from the same library.
If a library changes, we analyze its files anyway.

Change-Id: I4e57ebb605953694982b40f4a8e9a1c75dd87bc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424902
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -214,34 +214,40 @@ class LibraryManifestBuilder {
     // Must be created already.
     var item = declaredItems[element] as InterfaceItem;
 
-    var map = element.inheritanceManager.getInterface2(element).map2;
-    for (var entry in map.entries) {
-      var executable = entry.value.baseElement;
-
-      // Add only inherited.
-      if (executable.enclosingElement2 == element) {
-        continue;
-      }
+    var interface = element.inheritanceManager.getInterface2(element);
+    var inheritedExecutables = interface.map2.values
+        .map((e) => e.baseElement)
+        .where((e) => e.enclosingElement2 != element)
+        .toList(growable: false);
 
-      var lookupName = executable.lookupName?.asLookupName;
-      if (lookupName == null) {
-        continue;
-      }
+    for (var kindIndex = 0; kindIndex < 3; kindIndex++) {
+      for (var executable in inheritedExecutables) {
+        var lookupName = executable.lookupName?.asLookupName;
+        if (lookupName == null) {
+          continue;
+        }
 
-      var id = _getInterfaceElementMemberId(executable);
+        // We can see a private member only inside the library.
+        // But we reanalyze the library when one of its files changes.
+        if (lookupName.isPrivate) {
+          continue;
+        }
 
-      var baseName = lookupName.asBaseName;
-      switch (executable) {
-        case MethodElementImpl2():
-          if (lookupName.isIndexEq) {
-            item.members.addInheritedIndexEq(baseName, id);
-          } else {
-            item.members.addInheritedMethod(baseName, id);
-          }
-        case GetterElementImpl():
-          item.members.addInheritedGetter(baseName, id);
-        case SetterElementImpl():
-          item.members.addInheritedSetter(baseName, id);
+        var baseName = lookupName.asBaseName;
+        var id = _getInterfaceElementMemberId(executable);
+
+        switch ((kindIndex, executable)) {
+          case (0, MethodElementImpl2()):
+            if (lookupName.isIndexEq) {
+              item.members.addInheritedIndexEq(baseName, id);
+            } else {
+              item.members.addInheritedMethod(baseName, id);
+            }
+          case (1, GetterElementImpl()):
+            item.members.addInheritedGetter(baseName, id);
+          case (2, SetterElementImpl()):
+            item.members.addInheritedSetter(baseName, id);
+        }
       }
     }
   }