Separate allTargets variables for api.txt code generators.

This change removes the top level variable `allTargets` from
`pkg/analyzer_utilities/lib/tool/api.dart` and replaces it with a
method `allTargetsForPackage`, parameterized by the name of the
package for which an `api.txt` file is generated. The individual code
generators that make use of this function now all have their own top
level variable `allTargets`.

In addition to being conceptually clearer (since we no longer have a
single `allTargets` variable with different meanings depending on
where it's used), this paves the way for a CL I am working on that
will change the `GeneratedContent` based code generators so that they
use paths relative to the `pkg` directory. That in turn should make it
simpler to move some of the code generated files that have to do with
error messages from `pkg/analyzer` to `pkg/_fe_analyzer_shared`.

Change-Id: Id636ddbca27c46ae4242bbf8e4b6f7b8dae4d4e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438481
Reviewed-by: Samuel Rawlins <[email protected]>
Auto-Submit: Paul Berry <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: stereotype441

pkg/analysis_server_plugin/tool/api/generate.dart

@@ -14,6 +14,10 @@ Future<void> main() async {
   await GeneratedContent.generateAll(analyzerTestingPkgPath, allTargets);
 }
 
+/// A list of all targets generated by this code generator.
+final List<GeneratedContent> allTargets =
+    allTargetsForPackage('analysis_server_plugin');
+
 /// The path to the `analyzer_testing` package.
 final String analyzerTestingPkgPath = normalize(
   join(pkg_root.packageRoot, 'analysis_server_plugin'),

pkg/analysis_server_plugin/tool/api/generate_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that all files generated by `generate.dart` are up to
 // date.
 
-import 'package:analyzer_utilities/tool/api.dart';
 import 'package:analyzer_utilities/tools.dart';
 import 'package:path/path.dart';
 

pkg/analyzer/tool/api/generate.dart

@@ -14,6 +14,9 @@ Future<void> main() async {
   await GeneratedContent.generateAll(analyzerPkgPath, allTargets);
 }
 
+/// A list of all targets generated by this code generator.
+final List<GeneratedContent> allTargets = allTargetsForPackage('analyzer');
+
 /// The path to the `analyzer` package.
 final String analyzerPkgPath = normalize(
   join(pkg_root.packageRoot, 'analyzer'),

pkg/analyzer/tool/api/generate_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that all files generated by `generate.dart` are up to
 // date.
 
-import 'package:analyzer_utilities/tool/api.dart';
 import 'package:analyzer_utilities/tools.dart';
 import 'package:path/path.dart';
 

pkg/analyzer_testing/tool/api/generate.dart

@@ -14,6 +14,11 @@ Future<void> main() async {
   await GeneratedContent.generateAll(analyzerTestingPkgPath, allTargets);
 }
 
+/// A list of all targets generated by this code generator.
+final List<GeneratedContent> allTargets = allTargetsForPackage(
+  'analyzer_testing',
+);
+
 /// The path to the `analyzer_testing` package.
 final String analyzerTestingPkgPath = normalize(
   join(pkg_root.packageRoot, 'analyzer_testing'),

pkg/analyzer_testing/tool/api/generate_test.dart

@@ -5,7 +5,6 @@
 // This test verifies that all files generated by `generate.dart` are up to
 // date.
 
-import 'package:analyzer_utilities/tool/api.dart';
 import 'package:analyzer_utilities/tools.dart';
 import 'package:path/path.dart';
 

pkg/analyzer_utilities/lib/tool/api.dart

@@ -18,27 +18,23 @@ import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:analyzer_utilities/tools.dart';
 import 'package:collection/collection.dart';
 
-/// A list of all targets generated by this code generator.
-final List<GeneratedContent> allTargets = [
-  GeneratedFile('api.txt', computeApiTxtContents),
+/// Computes a list of all targets generated by this code generator for a given
+/// package.
+List<GeneratedContent> allTargetsForPackage(String pkgName) => [
+  GeneratedFile('api.txt', (pkgPath) async {
+    var provider = PhysicalResourceProvider.INSTANCE;
+    var collection = AnalysisContextCollection(
+      includedPaths: [pkgPath],
+      resourceProvider: provider,
+    );
+    var context = collection.contexts.first;
+    var publicApi = ApiDescription(pkgName);
+    var stringBuffer = StringBuffer();
+    _printNodes(stringBuffer, await publicApi.build(context));
+    return stringBuffer.toString();
+  }),
 ];
 
-/// Computes what should be written to the `api.txt` file.
-Future<String> computeApiTxtContents(String pkgPath) async {
-  var provider = PhysicalResourceProvider.INSTANCE;
-  var pathContext = provider.pathContext;
-  var pkgName = pathContext.basename(pkgPath);
-  var collection = AnalysisContextCollection(
-    includedPaths: [pkgPath],
-    resourceProvider: provider,
-  );
-  var context = collection.contexts.first;
-  var publicApi = ApiDescription(pkgName);
-  var stringBuffer = StringBuffer();
-  _printNodes(stringBuffer, await publicApi.build(context));
-  return stringBuffer.toString();
-}
-
 /// Outputs the contents of [nodes] to [sink], prepending [prefix] to every
 /// line.
 void _printNodes<SortKey extends Comparable<SortKey>>(