Skip to content

Commit 5c2fec9

Browse files
fishythefishCommit Queue
authored andcommitted
[ddc] Add line terminators to .map, .metadata, and .symbols
Standard utilities like `cat` expect files to be newline-terminated, so this change lets these files play nicely in build rules, for example. Change-Id: I6a6a6964b32dce7d2d73a402fa4eb2842b296621 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454540 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Mayank Patke <[email protected]>
1 parent d1a350a commit 5c2fec9

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

pkg/dev_compiler/lib/src/command/command.dart

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -549,18 +549,22 @@ Future<CompilerResult> _compile(
549549
outFiles.add(file.writeAsString(jsCode.code));
550550
if (jsCode.sourceMap != null) {
551551
outFiles.add(
552-
File('$output.map').writeAsString(json.encode(jsCode.sourceMap)),
552+
File('$output.map').writeAsString('${json.encode(jsCode.sourceMap)}\n'),
553553
);
554554
}
555555
if (jsCode.metadata != null) {
556556
outFiles.add(
557-
File('$output.metadata').writeAsString(json.encode(jsCode.metadata)),
557+
File(
558+
'$output.metadata',
559+
).writeAsString('${json.encode(jsCode.metadata)}\n'),
558560
);
559561
}
560562

561563
if (jsCode.symbols != null) {
562564
outFiles.add(
563-
File('$output.symbols').writeAsString(json.encode(jsCode.symbols)),
565+
File(
566+
'$output.symbols',
567+
).writeAsString('${json.encode(jsCode.symbols)}\n'),
564568
);
565569
}
566570
}

0 commit comments

Comments
 (0)