Skip to content

Commit 5c6f92f

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[test] Unskip many tests in reload stress testing.
Change-Id: I9ef008b00bb043b210d18659a49ee07fde081f67 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/409202 Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Siva Annamalai <[email protected]>
1 parent 413d9e9 commit 5c6f92f

File tree

7 files changed

+4
-56
lines changed

7 files changed

+4
-56
lines changed

tests/corelib/corelib.status

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,4 @@ regexp/global_test: Skip # Issue 21709
7373
regexp/pcre_test: Slow, Pass
7474

7575
[ $hot_reload || $hot_reload_rollback ]
76-
bigint_parse_radix_test: Skip # Issue 31659. Issue 34361.
77-
bigint_test: Skip # Issue 31659
78-
integer_parsed_mul_div_vm_test: Slow, Pass # Slow
76+
bigint_test: SkipSlow

tests/language/language.status

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,4 @@ function_type/*: Skip # Needs checked mode.
7474
identifier/built_in_type_annotation_test/set: Crash # Not supported by legacy VM front-end.
7575

7676
[ $hot_reload || $hot_reload_rollback ]
77-
macros/introspect/declaration_introspect_cycle_failure_test: Skip # Issue 54779
7877
regress/regress22780_test/01: Crash # Issue 29094
79-
vm/optimized_stacktrace_test: Slow, Pass

tests/language/language_kernel.status

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@ vm/no_such_args_error_message_vm_test: SkipByDesign # Looks for function name in
2727
vm/no_such_method_error_message_callable_vm_test: SkipByDesign # Expects unobfuscated method names
2828
vm/no_such_method_error_message_vm_test: SkipByDesign # Looks for unobfuscated name in error message
2929

30-
[ $compiler == dartk && $mode == debug && ($hot_reload || $hot_reload_rollback) ]
31-
enum/duplicate_test/02: Crash # Issue 34606
32-
enum/duplicate_test/none: Crash # Issue 34606
33-
enum/private_test/01: Crash # Issue 34606
34-
unsorted/inference_enum_list_test: Skip # Issue 35885
35-
3630
[ $compiler == dartk && $mode == product && $runtime == vm ]
3731
vm/lazy_async_exception_stack2_test: SkipByDesign
3832
vm/lazy_async_exception_stack_test: SkipByDesign

tests/lib/lib.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,12 +187,9 @@ isolate/static_function_test: Skip # Isolate.spawnUri
187187
isolate/unresolved_ports_test: Skip # Isolate.spawnUri
188188

189189
[ $hot_reload || $hot_reload_rollback ]
190-
convert/chunked_conversion_utf88_test: SkipSlow
191-
convert/utf85_test: SkipSlow
192190
isolate/deferred_in_isolate2_test: Crash # Requires deferred libraries
193191
isolate/deferred_in_isolate_test: Crash # Requires deferred libraries
194192
isolate/issue_21398_parent_isolate2_test: Crash # Requires deferred libraries
195-
isolate/spawn_uri_nested_vm_test: Crash # Issue 28192
196193
mirrors/closurization_equivalence_test: SkipByDesign # Method equality
197194
mirrors/deferred_constraints_constants_test: Crash # Requires deferred libraries
198195
mirrors/deferred_mirrors_metadata_test: Crash # Deferred loading
@@ -203,4 +200,3 @@ mirrors/library_import_deferred_loading_test: Crash # Deferred loading
203200
mirrors/library_imports_deferred_test: Crash # Deferred loading
204201
mirrors/load_library_test: Crash # Deferred loading
205202
mirrors/typedef_deferred_library_test: Crash # Deferred loading
206-
typed_data/zeroed_allocation_test: SkipSlow

tests/lib/lib_kernel.status

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ js/*: Skip # TODO(ahe): Make dart:js available.
1616
[ $arch == x64 && $compiler == dartk && $mode == debug && $runtime == vm ]
1717
mirrors/invocation_fuzz_test: Skip # Because it times out, issue 29439.
1818

19-
[ $arch == x64 && ($hot_reload || $hot_reload_rollback) ]
20-
convert/base64_test/01: Crash # http://dartbug.com/35948
21-
2219
[ $builder_tag == optimization_counter_threshold && $compiler == dartk ]
2320
mirrors/invocation_fuzz_test/emptyarray: Crash # Flaky on vm-kernel-optcounter-threshold-linux-release-x64, bug #31838
2421
mirrors/invocation_fuzz_test/false: Crash # Flaky on vm-kernel-optcounter-threshold-linux-release-x64, bug #31838
@@ -32,9 +29,6 @@ isolate/spawn_uri_nested_vm_test: Skip # Timeout, Issue 33385
3229
[ $compiler == dartk && $mode == debug && $runtime == vm ]
3330
mirrors/other_declarations_location_test: Crash # Issue 33325 (assertion error, TypeParameter not having position).
3431

35-
[ $compiler == dartk && $mode == debug && $hot_reload_rollback ]
36-
isolate/message3_test/constList_identical: Skip # Timeout
37-
3832
# ===== dartk + vm status lines =====
3933
[ $compiler == dartk && $runtime == vm ]
4034
html/*: SkipByDesign # dart:html not supported on VM.
@@ -45,14 +39,8 @@ isolate/static_function_test: Skip # Times out. Issue 31855. CompileTimeError. I
4539
mirrors/invocation_fuzz_test/smi: Crash
4640
mirrors/metadata_allowed_values_test/16: Skip # Flaky, crashes.
4741

48-
[ $compiler == dartk && $hot_reload_rollback ]
49-
isolate/pause_test: Skip # Timeout
50-
5142
[ $compiler == dartk && ($hot_reload || $hot_reload_rollback) ]
52-
isolate/message4_test: Crash # Timeout and sporadic crash (issue 33824)
5343
mirrors/dynamic_load_test: Skip # Reload has an effect similar to deleting the dynamically loaded library
54-
mirrors/immutable_collections_test: Pass, Slow
55-
mirrors/mirrors_reader_test: Pass, Slow
5644

5745
[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
5846
isolate/static_function_test: Skip # Flaky (https://github.com/dart-lang/sdk/issues/30063).

tests/standalone/standalone.status

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,4 @@ io/socket_many_connections_test: Skip # This test fails with "Too many open file
104104
deferred_transitive_import_error_test: Skip
105105

106106
[ $hot_reload || $hot_reload_rollback ]
107-
io/addlatexhash_test: Crash # Issue 31252
108-
io/many_directory_operations_test: SkipSlow
109-
io/many_file_operations_test: SkipSlow
110107
package/*: SkipByDesign # Launches VMs in interesting ways.
111-
typed_data_isolate_test: SkipSlow

tests/standalone/standalone_kernel.status

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ map_insert_remove_oom_test: Skip # Heap limit too low.
1515
[ $compiler == dartk && $mode == debug && $runtime == vm ]
1616
io/file_lock_test: Slow, Pass
1717

18-
[ $compiler == dartk && $mode == debug && $hot_reload ]
19-
io/web_socket_ping_test: Crash
20-
2118
[ $compiler == dartk && $runtime == vm ]
2219
no_support_debugger_test: Skip # kernel-service snapshot not compatible with flag disabled
2320

@@ -26,14 +23,6 @@ io/dart_std_io_pipe_test: Slow, Pass
2623
io/secure_builtin_roots_test: Skip # Issues 32137 and 32138.
2724
map_insert_remove_oom_test: Skip # Heap limit too low.
2825

29-
[ $compiler == dartk && $hot_reload ]
30-
io/http_no_reason_phrase_test: Crash
31-
io/http_outgoing_size_test: Crash
32-
33-
[ $compiler == dartk && $hot_reload_rollback ]
34-
io/directory_chdir_test: Skip # Timeout
35-
io/echo_server_stream_test: Slow, Pass
36-
3726
# Enabling of dartk for sim{arm,arm64} revealed these test failures, which
3827
# are to be triaged. Isolate tests are skipped on purpose due to the usage of
3928
# batch mode.
@@ -43,20 +32,6 @@ io/file_lock_test: Slow, Pass
4332
io/http_bind_test: Slow, Pass
4433
map_insert_remove_oom_test: Skip # Heap limit too low.
4534

46-
[ $compiler == dartk && ($hot_reload || $hot_reload_rollback) ]
47-
io/addlatexhash_test: Skip # Timeout
48-
io/http_advanced_test: Skip # Timeout
49-
io/http_auth_digest_test: Crash
50-
io/http_auth_test: Skip # Timeout
51-
io/http_proxy_advanced_test: Skip # Timeout
52-
io/http_read_test: Skip # Timeout
53-
io/pipe_server_test: Skip # Timeout
54-
io/socket_close_test: Skip # Timeout
55-
io/socket_many_connections_test: Skip # Timeout
56-
io/web_socket_compression_test: Skip # Timeout
57-
io/web_socket_test: Skip # Timeout
58-
regress_52715_test/measure: Skip # kernel-service interferes with measuring RSS
59-
6035
[ $compiler == dartkp && $mode == debug && $runtime == dart_precompiled ]
6136
io/raw_socket_test: Crash
6237
io/socket_finalizer_test: Crash
@@ -92,3 +67,6 @@ check_for_aot_snapshot_jit_test: SkipByDesign # Test relies on paths, requires J
9267

9368
[ $sanitizer == asan || $sanitizer == lsan || $sanitizer == msan || $sanitizer == tsan ]
9469
regress_52715_test/measure: Skip # Shadow memory and scudo quarantine interfere with measuring RSS
70+
71+
[ $hot_reload || $hot_reload_rollback ]
72+
regress_52715_test/measure: Skip # kernel-service interferes with measuring RSS

0 commit comments

Comments
 (0)