[element model] migrate deprecated_consistency

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ice1e43981098dee54483696ac79518ef6c752bf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393481
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -65,6 +65,7 @@ lib/src/rules/constant_identifier_names.dart
 lib/src/rules/control_flow_in_finally.dart
 lib/src/rules/curly_braces_in_flow_control_structures.dart
 lib/src/rules/dangling_library_doc_comments.dart
+lib/src/rules/deprecated_consistency.dart
 lib/src/rules/diagnostic_describe_all_properties.dart
 lib/src/rules/directives_ordering.dart
 lib/src/rules/discarded_futures.dart
@@ -499,7 +500,6 @@ test_data/rules/require_trailing_commas.dart
 test_data/rules/type_init_formals.dart
 test_data/rules/unawaited_futures.dart
 test_data/rules/unmocked/unsafe_html.dart
-test_data/rules/unnecessary_parenthesis.dart
 test_data/rules/void_checks.dart
 tool/benchmark.dart
 tool/changelog.dart

pkg/linter/lib/src/rules/deprecated_consistency.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
 
@@ -40,9 +40,9 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitConstructorDeclaration(ConstructorDeclaration node) {
-    var constructorElement = node.declaredElement;
+    var constructorElement = node.declaredFragment?.element;
     if (constructorElement != null &&
-        constructorElement.enclosingElement3.hasDeprecated &&
+        constructorElement.enclosingElement2.hasDeprecated &&
         !constructorElement.hasDeprecated) {
       var nodeToAnnotate = node.name ?? node.returnType;
       rule.reportLintForOffset(nodeToAnnotate.offset, nodeToAnnotate.length,
@@ -52,19 +52,28 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitFieldFormalParameter(FieldFormalParameter node) {
-    var declaredElement = node.declaredElement;
-    if (declaredElement is! FieldFormalParameterElement) return;
+    var declaredElement = node.declaredFragment?.element;
+    if (declaredElement is! FieldFormalParameterElement2) return;
 
-    var field = declaredElement.field;
+    var field = declaredElement.field2;
     if (field == null) return;
 
     if (field.hasDeprecated && !declaredElement.hasDeprecated) {
       rule.reportLint(node,
           errorCode: LinterLintCode.deprecated_consistency_field);
     }
     if (!field.hasDeprecated && declaredElement.hasDeprecated) {
-      rule.reportLintForOffset(field.nameOffset, field.nameLength,
+      var fieldFragment = field.firstFragment;
+      var nameOffset = fieldFragment.nameOffset2;
+      if (nameOffset == null) return;
+      var nameLength = fieldFragment.name2?.length;
+      if (nameLength == null) return;
+      rule.reportLintForOffset(nameOffset, nameLength,
           errorCode: LinterLintCode.deprecated_consistency_parameter);
     }
   }
 }
+
+extension on Annotatable {
+  bool get hasDeprecated => metadata2.hasDeprecated;
+}