Commit 5d84ffb
BREAKING CHANGE: Fix
Rewrite `parseIPv4Address` and `parseIPv6Address`
to not do so much unnecessary allocation and copying.
This is a breaking change if someone, somewhere,
depends on parsing IPv4 addresses with leading zeros.
Neither RFC 3986 or the WhatWG URL spec allows leading
zeros, so it wouldn't work anywhere else. Because of that,
it's not expected to be breaking in practice.
Fixes #61392.
BUG= https://dartbug.com/61392
Change-Id: I045353d5d1606795048e12ee12cd12b30dbf8ab3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447260
Commit-Queue: Lasse Nielsen <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>parseIPv4Address to not allow leading zeros.1 parent c1f4e21 commit 5d84ffb
File tree
4 files changed
+581
-182
lines changed- sdk/lib/core
- tests/corelib
4 files changed
+581
-182
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
93 | 103 | | |
94 | 104 | | |
95 | 105 | | |
| |||
0 commit comments