[dart2js] Add option to omit memory usage from the dart2js compilation summary.

Internally sometimes this query to get the memory usage will cause timeouts. So provide a way to disable it.

See b/427802111.

Change-Id: I1e6c97d0796b97f42e935e1b20e784796bed1281
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437660
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Ivan Inozemtsev <[email protected]>

Author: iinozemtsev

pkg/compiler/lib/src/commandline_options.dart

@@ -107,6 +107,7 @@ class Flags {
   static const String verbosity = '--verbosity';
   static const String progress = '--show-internal-progress';
   static const String version = '--version';
+  static const String omitMemorySummary = '--omit-memory-summary';
   static const String reportMetrics = '--report-metrics';
   static const String reportAllMetrics = '--report-all-metrics';
 

pkg/compiler/lib/src/dart2js.dart

@@ -537,6 +537,7 @@ Future<api.CompilationResult> compile(
     _OneOption('${Flags.verbosity}=.+', passThrough),
     _OneOption(Flags.disableDiagnosticByteCache, passThrough),
     _OneOption(Flags.enableDeferredLoadingEventLog, passThrough),
+    _OneOption(Flags.omitMemorySummary, passThrough),
 
     // Experimental features.
     // We don't provide documentation for these yet.
@@ -925,7 +926,9 @@ Future<api.CompilationResult> compile(
         break;
     }
 
-    final memoryUsed = await currentHeapCapacityInMb();
+    final memoryUsed = compilerOptions.omitMemorySummary
+        ? null
+        : await currentHeapCapacityInMb();
     final memoryUsedString = memoryUsed != null
         ? ' using $memoryUsed of memory'
         : '';

pkg/compiler/lib/src/dump_info.dart

@@ -1883,14 +1883,18 @@ class DumpInfoTask extends CompilerTask implements InfoReporter {
     result.info.deferredFiles = _dumpInfoData.fragmentDeferredMap;
     stopwatch.stop();
 
+    final ramUsage =
+        (options.omitMemorySummary ? null : await currentHeapCapacityInMb()) ??
+        'N/A MB';
+
     result.info.program = ProgramInfo(
       entrypoint:
           infoCollector.state.entityToInfo[closedWorld
                   .elementEnvironment
                   .mainFunction]
               as FunctionInfo,
       size: _dumpInfoData.programSize,
-      ramUsage: await currentHeapCapacityInMb() ?? 'N/A MB',
+      ramUsage: ramUsage,
       dart2jsVersion: options.hasBuildId ? options.buildId : null,
       compilationMoment: DateTime.now(),
       compilationDuration: measurer.elapsedWallClock,
@@ -1967,14 +1971,18 @@ class DumpInfoTask extends CompilerTask implements InfoReporter {
     result.info.deferredFiles = _dumpInfoData.fragmentDeferredMap;
     stopwatch.stop();
 
+    final ramUsage =
+        (options.omitMemorySummary ? null : await currentHeapCapacityInMb()) ??
+        'N/A MB';
+
     result.info.program = ProgramInfo(
       entrypoint:
           infoCollector.state.entityToInfo[closedWorld
                   .elementEnvironment
                   .mainFunction]
               as FunctionInfo,
       size: _dumpInfoData.programSize,
-      ramUsage: await currentHeapCapacityInMb() ?? 'N/A MB',
+      ramUsage: ramUsage,
       dart2jsVersion: options.hasBuildId ? options.buildId : null,
       compilationMoment: DateTime.now(),
       compilationDuration: measurer.elapsedWallClock,

pkg/compiler/lib/src/options.dart

@@ -621,6 +621,10 @@ class CompilerOptions implements DiagnosticOptions {
   /// during each phase of compilation.
   bool showInternalProgress = false;
 
+  /// Omit memory usage in the summary printed to the console at the end of
+  /// each compilation.
+  bool omitMemorySummary = false;
+
   /// Enable printing of metrics at end of compilation.
   // TODO(sra): Add command-line filtering of metrics.
   bool reportPrimaryMetrics = false;
@@ -948,6 +952,7 @@ class CompilerOptions implements DiagnosticOptions {
       ..useNewSourceInfo = _hasOption(options, Flags.useNewSourceInfo)
       ..useSimpleLoadIds = _hasOption(options, Flags.useSimpleLoadIds)
       ..verbose = _hasOption(options, Flags.verbose)
+      ..omitMemorySummary = _hasOption(options, Flags.omitMemorySummary)
       ..reportPrimaryMetrics = _hasOption(options, Flags.reportMetrics)
       ..reportSecondaryMetrics = _hasOption(options, Flags.reportAllMetrics)
       ..showInternalProgress = _hasOption(options, Flags.progress)

pkg/compiler/test/end_to_end/command_line_test.dart

@@ -567,6 +567,9 @@ main() {
 
     // JS Emitter stage
     await test(['${Flags.stage}=emit-js', 'foo.dart'], exitCode: 1);
+
+    // Omit memory summary.
+    await test(['--omit-memory-summary', 'foo.dart'], out: 'out.js');
   });
 }