Fine. Collect statistics for RequirementFailure kinds.

Requires dart-lang/tools#2250

Change-Id: I477b85d19edec7abdee6f9375a77a4e16dfab9ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463163
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

DEPS

@@ -147,7 +147,7 @@ vars = {
   "sync_http_rev": "6666fff944221891182e1f80bf56569338164d72",
   "tar_rev": "13479f7c2a18f499e840ad470cfcca8c579f6909",
   "test_rev": "80a49347e4a3dbc3ed70782df5e8c76a67f9256c",
-  "tools_rev": "37f82420f5060ca70af79b8a3ee98c91b66d250b",
+  "tools_rev": "30c418bdd4b46d462e29e9ea360bbf9d62296c3b",
   "vector_math_rev": "70a9a2cb610d040b247f3ca2cd70a94c1c6f6f23",
   "web_rev": "7b94cf8908d320179678fc24557f163e2924c830",
   "webdev_rev": "b9c39c00853dfad0e235bec3b265f86a0f4f328a",

pkg/analysis_server/lib/src/analytics/analytics_manager.dart

@@ -627,6 +627,11 @@ class AnalyticsManager {
             statistics.produceErrorsActualFileLineCount,
         produceErrorsDurationMs: statistics.produceErrorsMs,
         produceErrorsElementsDurationMs: statistics.produceErrorsElementsMs,
+        libraryDiagnosticsBundleFailures: statistics
+            .libraryDiagnosticsBundleRequirementsFailures
+            .entries
+            .map((e) => '${e.key.id}:${e.value}')
+            .join(','),
       ),
     );
 

pkg/analysis_server/lib/src/analytics/session_data.dart

@@ -4,6 +4,7 @@
 
 import 'package:analysis_server/src/analytics/percentile_calculator.dart';
 import 'package:analyzer/src/dart/analysis/status.dart';
+import 'package:analyzer/src/fine/requirement_failure.dart';
 
 /// Accumulated statistics over multiple analysis working periods.
 class AnalyticsAnalysisWorkingStatistics {
@@ -66,6 +67,10 @@ class AnalyticsAnalysisWorkingStatistics {
   /// The sum of line counts for [produceErrorsActualFileCount].
   int produceErrorsActualFileLineCount = 0;
 
+  /// The counts of requirement failures for library diagnostics bundles.
+  final Map<RequirementFailureKindId, int>
+  libraryDiagnosticsBundleRequirementsFailures = {};
+
   AnalyticsAnalysisWorkingStatistics({required this.withFineDependencies});
 
   void append(AnalysisStatusWorkingStatistics statistics) {
@@ -98,6 +103,15 @@ class AnalyticsAnalysisWorkingStatistics {
     produceErrorsActualFileCount += statistics.produceErrorsActualFileCount;
     produceErrorsActualFileLineCount +=
         statistics.produceErrorsActualFileLineCount;
+
+    for (var entry
+        in statistics.libraryDiagnosticsBundleRequirementsFailures.entries) {
+      libraryDiagnosticsBundleRequirementsFailures.update(
+        entry.key,
+        (value) => value + entry.value,
+        ifAbsent: () => entry.value,
+      );
+    }
   }
 }
 

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -1950,6 +1950,11 @@ class AnalysisDriver {
         ),
       );
       if (failure != null) {
+        performance.getDataInt(failure.statisticKey).increment();
+        _scheduler
+            ._workingStatistics
+            ?.libraryDiagnosticsBundleRequirementsFailures
+            .update(failure.kindId, (value) => value + 1, ifAbsent: () => 1);
         return null;
       }
 

pkg/analyzer/lib/src/dart/analysis/status.dart

@@ -4,6 +4,8 @@
 
 import 'dart:async';
 
+import 'package:analyzer/src/fine/requirement_failure.dart';
+
 /// The status of analysis.
 sealed class AnalysisStatus {
   const AnalysisStatus._();
@@ -81,6 +83,10 @@ class AnalysisStatusWorkingStatistics {
   /// The sum of line counts for [produceErrorsActualFileCount].
   int produceErrorsActualFileLineCount = 0;
 
+  /// The counts of requirement failures for library diagnostics bundles.
+  final Map<RequirementFailureKindId, int>
+  libraryDiagnosticsBundleRequirementsFailures = {};
+
   AnalysisStatusWorkingStatistics({
     required this.withFineDependencies,
     required this.changedFiles,