[ Observatory ] Remove Observatory from the Dart VM

Also cleans up some references to Observatory in various places.

Work towards #50233

TEST=N/A
CoreLibraryReviewExempt: Not modifying public core libraries.
Change-Id: I1f36b4e6f1fd9a59a579d719aafa599906eedb3f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429141
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

Author: bkonyi

BUILD.gn

@@ -218,18 +218,6 @@ group("dart2js_bot") {
   ]
 }
 
-# This rule and the compressed_observatory_archive rule are for the Fuchsia
-# bots that pre-build the Observatory. They copy the observatory tar files to
-# the root build output directory for convenient access by the Fuchsia buildbot
-# scripts.
-group("observatory_archive") {
-  deps = [ "runtime/observatory:copy_observatory_archive" ]
-}
-
-group("compressed_observatory_archive") {
-  deps = [ "runtime/observatory:copy_compressed_observatory_archive" ]
-}
-
 if (is_fuchsia) {
   import("third_party/fuchsia/gn-sdk/src/component.gni")
   import("third_party/fuchsia/gn-sdk/src/package.gni")

pkg/analysis_server/benchmark/perf/memory_tests.dart

@@ -225,7 +225,7 @@ class LspAnalysisServerMemoryUsageTest
     _vmServicePort = await ServiceProtocol._findAvailableSocketPort();
     vmArgs.addAll([
       '--enable-vm-service=$_vmServicePort',
-      '-DSILENT_OBSERVATORY=true',
+      '-DSILENT_VM_SERVICE=true',
       '--disable-service-auth-codes',
       '--disable-dart-dev',
       '--no-dds',

pkg/analysis_server/test/integration/support/integration_tests.dart

@@ -716,7 +716,7 @@ class Server {
   }
 
   /// Start the server. If [profileServer] is `true`, the server will be started
-  /// with "--observe" and "--pause-isolates-on-exit", allowing the observatory
+  /// with "--observe" and "--pause-isolates-on-exit", allowing Dart DevTools
   /// to be used.
   Future<void> start({
     required String dartSdkPath,

pkg/analysis_server/test/stress/utilities/server.dart

@@ -601,7 +601,7 @@ class Server {
   /// the specified port.
   ///
   /// If [profileServer] is `true`, the server will be started with "--observe"
-  /// and "--pause-isolates-on-exit", allowing the observatory to be used.
+  /// and "--pause-isolates-on-exit", allowing Dart DevTools to be used.
   ///
   /// If [useAnalysisHighlight2] is `true`, the server will use the new
   /// highlight APIs.

pkg/analyzer_plugin/doc/tutorial/debugging.md

@@ -49,15 +49,12 @@ that will be written to the instrumentation log file. Currently, the best choice
 for this is the `plugin.error` notification. Just be sure that `isFatal` has a
 value of `false`.
 
-## Using Observatory
+## Using Dart DevTools
 
 If the client you're using allows you to pass command-line flags to the VM, then
-you can also run the analysis server under the Observatory. Pass in both
+you can also run the analysis server under Dart DevTools. Pass in both
 `--observe` and `--pause-isolates-on-start`, then point your browser to
-`http://localhost:8181`. To learn more, see the
-[observatory][observatory] documentation.
+`http://localhost:8181`.
 
 If you're using IntelliJ as your client, open the "Registry..." dialog and edit
 the entry named "dart.server.vm.options".
-
-[observatory]: https://dart-lang.github.io/observatory/

pkg/compiler/README.md

@@ -367,7 +367,7 @@ functionality is publicly exposed.
     when run on very large apps.
 
   * `tool/dart2js_stress.dart` and `tool/dart2js_profile_many.dart`: other
-    helper wrappers to make it easier to profile dart2js with Observatory.
+    helper wrappers to make it easier to profile dart2js with Dart DevTools.
 
 * Source map tracking (`lib/src/io`): helpers used to track source information
   and to build source map files. _TODO: add details_.

pkg/compiler/tool/track_memory.dart

@@ -18,7 +18,7 @@ import 'dart:async';
 
 import 'dart:convert';
 
-/// Socket to connect to the vm observatory service.
+/// Socket to connect to the VM service.
 late WebSocket socket;
 
 Future<void> main(List<String> args) async {

pkg/dartdev/test/commands/run_test.dart

@@ -885,107 +885,6 @@ main() => print('b:b');
       );
     });
   });
-
-  group('Observatory', () {
-    void generateServedTest({
-      required bool serve,
-      required bool enableAuthCodes,
-      required bool explicitRun,
-      required bool withDds,
-    }) {
-      test(
-        '${serve ? 'served by default' : 'not served'} ${enableAuthCodes ? "with" : "without"} '
-        'auth codes, ${explicitRun ? 'explicit' : 'implicit'} run,${withDds ? ' ' : 'no'} DDS',
-        () async {
-          p = project(
-            mainSrc:
-                'void main() { print("ready"); int i = 0; while(true) { i++; } }',
-          );
-          Process process = await p.start([
-            if (explicitRun) 'run',
-            '--enable-vm-service=0',
-            if (!withDds) '--no-dds',
-            if (!enableAuthCodes) '--disable-service-auth-codes',
-            if (serve) '--serve-observatory',
-            p.relativeFilePath,
-          ]);
-
-          final completer = Completer<void>();
-
-          late final StreamSubscription<String> sub;
-          late final String uri;
-          sub = process.stdout.transform(utf8.decoder).listen((event) async {
-            if (event.contains(dartVMServiceRegExp)) {
-              uri = dartVMServiceRegExp.firstMatch(event)!.group(1)!;
-              await sub.cancel();
-              completer.complete();
-            }
-          });
-
-          // Wait for process to start.
-          await completer.future;
-          final client = HttpClient();
-
-          Future<String> makeServiceHttpRequest({String method = ''}) async {
-            var request = await client.getUrl(Uri.parse('$uri$method'));
-            var response = await request.close();
-            return await response.transform(utf8.decoder).join();
-          }
-
-          var content = await makeServiceHttpRequest();
-          const observatoryText = 'Dart VM Observatory';
-          expect(content.contains(observatoryText), serve);
-          if (!serve) {
-            if (withDds) {
-              expect(content.contains('DevTools'), true);
-            } else {
-              expect(
-                content,
-                'This VM does not have a registered Dart '
-                'Development Service (DDS) instance and is not currently serving '
-                'Dart DevTools.',
-              );
-            }
-          }
-
-          // Ensure we can always make VM service requests via HTTP.
-          content = await makeServiceHttpRequest(method: 'getVM');
-          expect(content.contains('"jsonrpc":"2.0"'), true);
-
-          // If Observatory isn't being served, ensure we can enable it.
-          if (!serve) {
-            content = await makeServiceHttpRequest(method: '_serveObservatory');
-            expect(content.contains('"type":"Success"'), true);
-
-            // Ensure Observatory is now being served.
-            content = await makeServiceHttpRequest();
-            expect(content.contains(observatoryText), true);
-          }
-
-          process.kill();
-        },
-      );
-    }
-
-    const flags = <bool>[true, false];
-    // TODO(jcollins):  Disabling serving no longer seems to produce
-    // the expected output.  Maybe this is because the web interface has
-    // changed?
-    for (final serve in [true]) {
-      for (final enableAuthCodes in flags) {
-        for (final explicitRun in flags) {
-          for (final withDds in flags) {
-            generateServedTest(
-              serve: serve,
-              enableAuthCodes: enableAuthCodes,
-              explicitRun: explicitRun,
-              withDds: withDds,
-            );
-          }
-        }
-      }
-    }
-  });
 }
 
 void residentRun() {

pkg/dartdev/test/smoke/invalid_smoke_test.dart

@@ -50,7 +50,7 @@ void main() {
             ],
           );
           expect(result.exitCode, 64);
-          expect(result.stdout, contains('Observatory listening'));
+          expect(result.stdout, contains('The Dart VM service is listening'));
           expect(
             result.stderr,
             contains(
@@ -100,7 +100,7 @@ void main() {
             ],
           );
           expect(result.exitCode, 254);
-          expect(result.stdout, contains('Observatory listening'));
+          expect(result.stdout, contains('The Dart VM service is listening'));
           expect(
             result.stderr,
             contains(

pkg/dds/test/devtools_observatory_connection_test.dart

@@ -35,7 +35,7 @@ void main() {
 
   defineTest({required bool authCodesEnabled}) {
     test(
-        'Ensure Observatory and DevTools assets are available with '
+        'Ensure DevTools assets are available with '
         '${authCodesEnabled ? '' : 'no'} auth codes', () async {
       dds = await DartDevelopmentService.startDartDevelopmentService(
         remoteVmServiceUri,
@@ -48,14 +48,6 @@ void main() {
 
       final client = HttpClient();
 
-      // Check that Observatory assets are accessible.
-      final observatoryRequest = await client.getUrl(dds!.uri!);
-      final observatoryResponse = await observatoryRequest.close();
-      expect(observatoryResponse.statusCode, 200);
-      final observatoryContent =
-          await observatoryResponse.transform(utf8.decoder).join();
-      expect(observatoryContent, startsWith('<!DOCTYPE html>'));
-
       // Check that DevTools assets are accessible.
       final devtoolsRequest = await client.getUrl(dds!.devToolsUri!);
       final devtoolsResponse = await devtoolsRequest.close();