[ddc] Bump language version to 3.8

* Reformat pkg/dev_compiler.
* Re-flow some comments to keep them within 80 characters.

Change-Id: I0849ce113ecf3dce4a2b4405c2b09a17dee4df76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433081
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Author: nshahan

pkg/dev_compiler/lib/ddc.dart

@@ -38,8 +38,10 @@ Future internalMain(List<String> args, [SendPort? sendPort]) async {
     var batch = _BatchHelper();
     await batch._runBatch(parsedArgs);
   } else if (parsedArgs.isExpressionCompiler) {
-    await ExpressionCompilerWorker.createAndStart(parsedArgs.rest,
-        sendPort: sendPort);
+    await ExpressionCompilerWorker.createAndStart(
+      parsedArgs.rest,
+      sendPort: sendPort,
+    );
   } else {
     var result = await compile(parsedArgs);
     exitCode = result.exitCode;
@@ -52,7 +54,7 @@ class _CompilerWorker extends AsyncWorkerLoop {
   final ParsedArguments _startupArgs;
 
   _CompilerWorker(this._startupArgs, AsyncWorkerConnection workerConnection)
-      : super(connection: workerConnection);
+    : super(connection: workerConnection);
 
   /// Keeps track of our last compilation result so it can potentially be
   /// re-used in a worker.
@@ -72,12 +74,17 @@ class _CompilerWorker extends AsyncWorkerLoop {
     }
 
     lastResult = await runZoned(
-        () => compile(args,
-            compilerState: context?.kernelState, inputDigests: inputDigests),
-        zoneSpecification:
-            ZoneSpecification(print: (self, parent, zone, message) {
-      output.writeln(message.toString());
-    }));
+      () => compile(
+        args,
+        compilerState: context?.kernelState,
+        inputDigests: inputDigests,
+      ),
+      zoneSpecification: ZoneSpecification(
+        print: (self, parent, zone, message) {
+          output.writeln(message.toString());
+        },
+      ),
+    );
     return WorkResponse()
       ..exitCode = lastResult!.success ? 0 : 1
       ..output = output.toString();
@@ -108,10 +115,13 @@ class _BatchHelper {
   Future _runBatch(ParsedArguments batchArgs) async {
     _workaroundForLeakingBug();
     if (leakTesting) {
-      var services =
-          await Service.controlWebServer(enable: true, silenceOutput: true);
-      File.fromUri(Directory.systemTemp.uri.resolve('./dart_leak_test_uri'))
-          .writeAsStringSync(services.serverUri!.toString());
+      var services = await Service.controlWebServer(
+        enable: true,
+        silenceOutput: true,
+      );
+      File.fromUri(
+        Directory.systemTemp.uri.resolve('./dart_leak_test_uri'),
+      ).writeAsStringSync(services.serverUri!.toString());
     }
 
     watch.start();
@@ -164,12 +174,18 @@ class _BatchHelper {
   void _workaroundForLeakingBug() {
     try {
       stdin.echoMode;
-    } catch (e) {/**/}
+    } catch (e) {
+      /**/
+    }
     try {
       stdout.writeln();
-    } catch (e) {/**/}
+    } catch (e) {
+      /**/
+    }
     try {
       stderr.writeln();
-    } catch (e) {/**/}
+    } catch (e) {
+      /**/
+    }
   }
 }

pkg/dev_compiler/lib/src/command/arguments.dart

@@ -59,15 +59,15 @@ class ParsedArguments {
     this.isExpressionCompiler = false,
   });
 
-  /// Preprocess arguments to determine whether DDK is used in batch mode or as a
-  /// persistent worker.
+  /// Preprocess arguments to determine whether DDK is used in batch mode or as
+  /// a persistent worker.
   ///
   /// When used in batch mode, we expect a `--batch` parameter.
   ///
   /// When used as a persistent bazel worker, the `--persistent_worker` might be
-  /// present, and an argument of the form `@path/to/file` might be provided. The
-  /// latter needs to be replaced by reading all the contents of the
-  /// file and expanding them into the resulting argument list.
+  /// present, and an argument of the form `@path/to/file` might be provided.
+  /// The `@latter needs to be replaced by reading all the contents of the file
+  /// and expanding them into the resulting argument list.
   factory ParsedArguments.from(List<String> args) {
     if (args.isEmpty) return ParsedArguments._(args);
 
@@ -101,12 +101,14 @@ class ParsedArguments {
         newArgs.add(arg);
       }
     }
-    return ParsedArguments._(newArgs,
-        isWorker: isWorker,
-        isBatch: isBatch,
-        reuseResult: reuseResult,
-        useIncrementalCompiler: useIncrementalCompiler,
-        isExpressionCompiler: isExpressionCompiler);
+    return ParsedArguments._(
+      newArgs,
+      isWorker: isWorker,
+      isBatch: isBatch,
+      reuseResult: reuseResult,
+      useIncrementalCompiler: useIncrementalCompiler,
+      isExpressionCompiler: isExpressionCompiler,
+    );
   }
 
   /// Whether the compiler is running in [isBatch] or [isWorker] mode.
@@ -128,12 +130,14 @@ class ParsedArguments {
     if (newArgs.isBatchOrWorker) {
       throw ArgumentError('cannot change batch or worker mode after startup.');
     }
-    return ParsedArguments._(rest.toList()..addAll(newArgs.rest),
-        isWorker: isWorker,
-        isBatch: isBatch,
-        reuseResult: reuseResult || newArgs.reuseResult,
-        useIncrementalCompiler:
-            useIncrementalCompiler || newArgs.useIncrementalCompiler);
+    return ParsedArguments._(
+      rest.toList()..addAll(newArgs.rest),
+      isWorker: isWorker,
+      isBatch: isBatch,
+      reuseResult: reuseResult || newArgs.reuseResult,
+      useIncrementalCompiler:
+          useIncrementalCompiler || newArgs.useIncrementalCompiler,
+    );
   }
 }