Skip to content

Commit 6129842

Browse files
munificentCommit Queue
authored andcommitted
Opt multitests out of formatting in standalone/.
The new formatter supports opting a region of code out from being formatted. I'm applying this marker to all of the multitests since those tests are often very sensitive to formatting and easily broken. This way, anyone touching a multitest (including me when I reformat the tests) doesn't have to remember to not run the formatter on it. Change-Id: I06928e08530ad658affd23e594702cff658d8035 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396181 Commit-Queue: Bob Nystrom <[email protected]> Commit-Queue: Brian Quinlan <[email protected]> Auto-Submit: Bob Nystrom <[email protected]> Reviewed-by: Brian Quinlan <[email protected]>
1 parent ad8c44f commit 6129842

12 files changed

+36
-0
lines changed

tests/standalone/deny_listed_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
// BSD-style license that can be found in the LICENSE file.
44
// Dart test checking that static/instance field shadowing do not conflict.
55

6+
// Formatting can break multitests, so don't format them.
7+
// dart format off
8+
69
// Test that certain interfaces/classes are denylisted from being
710
// implemented or extended (VM corelib only).
811

tests/standalone/io/dart_std_io_pipe_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
// VMOptions=--short_socket_write
1111
// VMOptions=--short_socket_read --short_socket_write
1212

13+
// Formatting can break multitests, so don't format them.
14+
// dart format off
15+
1316
import "package:expect/expect.dart";
1417
import "dart:io";
1518
import "process_test_util.dart";

tests/standalone/io/platform_resolved_executable_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
//
55
// Process test program to test process communication.
66

7+
// Formatting can break multitests, so don't format them.
8+
// dart format off
9+
710
library PlatformExecutableTest;
811

912
import "dart:io";

tests/standalone/io/signals_exception_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import "dart:io";
69

710
import "package:expect/expect.dart";

tests/standalone/io/socket_ipv6_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import 'dart:io';
69
import 'dart:async';
710

tests/standalone/package/invalid_uri_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
library invalid_uri_test;
69

710
// Should not contain "//".

tests/standalone/package/scenarios/empty_packages_file/empty_packages_file_discovery_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
// Packages=none
69

710
library empty_packages_file_discovery_test;

tests/standalone/package/scenarios/empty_packages_file/empty_packages_file_option_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
// Packages=.dart_tool/package_config.json
69

710
library empty_packages_file_option_test;

tests/standalone/package/scenarios/packages_file_strange_formatting/empty_package_dir_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
// Packages=empty_package_dir.packages
69

710
// This test verifies handling of legacy .packages file and cannot be run in

tests/standalone/regress_29350_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
* BSD-style license that can be found in the LICENSE file.
55
*/
66

7+
// Formatting can break multitests, so don't format them.
8+
// dart format off
9+
710
// 'covariant' when used incorrectly should report an error and not crash
811
// the VM.
912

0 commit comments

Comments
 (0)