Elements. Migrate ResolverVisitor.

Use the return type of the method element, not a fragment, as a result
report BODY_MIGHT_COMPLETE_NORMALLY in invalid fragments.

Change-Id: I5a07fcc21695695cf9aeacaf6d35949c69b4c817
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411480
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -458,11 +458,16 @@ final class ArgumentListImpl extends AstNodeImpl implements ArgumentList {
     _correspondingStaticParameters = parameters;
   }
 
-  List<FormalParameterElement?>? get correspondingStaticParameters2 =>
+  List<FormalParameterElementMixin?>? get correspondingStaticParameters2 =>
       _correspondingStaticParameters
           ?.map((parameter) => parameter?.asElement2)
           .toList();
 
+  set correspondingStaticParameters2(
+      List<FormalParameterElementMixin?>? value) {
+    _correspondingStaticParameters = value?.map((e) => e?.asElement).toList();
+  }
+
   @override
   Token get endToken => rightParenthesis;
 
@@ -3743,17 +3748,20 @@ base mixin CompoundAssignmentExpressionImpl
   @experimental
   @override
   Element2? get readElement2 {
-    if (readElement is Fragment) {
-      return (readElement as Fragment).element;
-    } else if (readElement is Element2) {
-      return readElement as Element2;
-    }
-    return null;
+    return readElement?.asElement2;
+  }
+
+  set readElement2(Element2? value) {
+    readElement = value?.asElement;
   }
 
   @experimental
   @override
   Element2? get writeElement2 => writeElement.asElement2;
+
+  set writeElement2(Element2? value) {
+    writeElement = value?.asElement;
+  }
 }
 
 /// A conditional expression.
@@ -5179,7 +5187,7 @@ final class DefaultFormalParameterImpl extends FormalParameterImpl
 
   @experimental
   @override
-  FormalParameterFragment? get declaredFragment => _parameter.declaredFragment;
+  ParameterElementImpl? get declaredFragment => _parameter.declaredFragment;
 
   @override
   ExpressionImpl? get defaultValue => _defaultValue;
@@ -5699,9 +5707,13 @@ final class EnumConstantDeclarationImpl extends DeclarationImpl
   ConstructorElement2? get constructorElement2 =>
       constructorElement?.asElement2;
 
+  set constructorElement2(ConstructorElement2? value) {
+    constructorElement = value?.asElement;
+  }
+
   @experimental
   @override
-  FieldFragment? get declaredFragment => declaredElement as FieldFragment?;
+  FieldElementImpl? get declaredFragment => declaredElement;
 
   @override
   Token get endToken => arguments?.endToken ?? name;
@@ -6738,8 +6750,7 @@ final class ExtensionOverrideImpl extends ExpressionImpl
   Token get beginToken => importPrefix?.name ?? name;
 
   @override
-  ExtensionElementImpl get element =>
-      element2.firstFragment;
+  ExtensionElementImpl get element => element2.firstFragment;
 
   @override
   Token get endToken => _argumentList.endToken;
@@ -7685,8 +7696,7 @@ sealed class FormalParameterImpl extends AstNodeImpl
 
   @experimental
   @override
-  FormalParameterFragment? get declaredFragment =>
-      declaredElement as FormalParameterFragment?;
+  ParameterElementImpl? get declaredFragment => declaredElement;
 
   @override
   bool get isNamed => kind.isNamed;
@@ -10260,6 +10270,10 @@ final class IndexExpressionImpl extends ExpressionImpl
   @override
   MethodElement2? get element => staticElement?.asElement2;
 
+  set element(MethodElement2? value) {
+    staticElement = value?.asElement;
+  }
+
   @override
   Token get endToken => rightBracket;
 

pkg/analyzer/lib/src/dart/resolver/invocation_inferrer.dart

@@ -284,7 +284,7 @@ abstract class FullInvocationInferrer<Node extends AstNodeImpl>
 
     var parameters = _storeResult(typeArgumentTypes, invokeType);
     if (parameters != null) {
-      argumentList.correspondingStaticParameters =
+      argumentList.correspondingStaticParameters2 =
           ResolverVisitor.resolveArgumentsToParameters(
         argumentList: argumentList,
         formalParameters: parameters,

pkg/analyzer/lib/src/generated/element_resolver.dart

@@ -248,7 +248,7 @@ class ElementResolver {
     var parameters =
         _resolveArgumentsToFunction(argumentList, invokedConstructor);
     if (parameters != null) {
-      argumentList.correspondingStaticParameters = parameters;
+      argumentList.correspondingStaticParameters2 = parameters;
     }
   }
 
@@ -323,7 +323,7 @@ class ElementResolver {
     var argumentList = node.argumentList;
     var parameters = _resolveArgumentsToFunction(argumentList, element);
     if (parameters != null) {
-      argumentList.correspondingStaticParameters = parameters;
+      argumentList.correspondingStaticParameters2 = parameters;
     }
   }
 
@@ -397,7 +397,7 @@ class ElementResolver {
       enclosingConstructor: node.thisOrAncestorOfType<ConstructorDeclaration>(),
     );
     if (parameters != null) {
-      argumentList.correspondingStaticParameters = parameters;
+      argumentList.correspondingStaticParameters2 = parameters;
     }
   }
 
@@ -440,7 +440,7 @@ class ElementResolver {
   /// the list of arguments. An error will be reported if any of the arguments
   /// cannot be matched to a parameter. Return the parameters that correspond to
   /// the arguments, or `null` if no correspondence could be computed.
-  List<ParameterElementMixin?>? _resolveArgumentsToFunction(
+  List<FormalParameterElementMixin?>? _resolveArgumentsToFunction(
     ArgumentList argumentList,
     ExecutableElement2? executableElement, {
     ConstructorDeclaration? enclosingConstructor,