[messages] Add GeneratedDiagnosticClassInfo.package field.

Adds the field `GeneratedDiagnosticClassInfo.package`, and its
associated enum type (`AnalyzerDiagnosticPackage`), which describes
which package an analyzer diagnostic code is being generated for
(analyzer, analysis_server, or linter).

This field is used to determine which analyzer messages should be
included in the `diagnosticCodeValues` list; the only messages that
should be included are those generated for the `analyzer` package.

Eventually each of these three packages will have its own
`diagnsticCodeValues` list.

With this change, the field
`GeneratedDiagnosticClassInfo.includeInDiagnosticCodeValues` is no
longer needed.

Change-Id: I6a6a69641591d0f25029490ced3e772b90c056c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458380
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: stereotype441

pkg/analyzer/tool/messages/generate.dart

@@ -132,7 +132,7 @@ part of ${json.encode(file.parentLibrary)};
 
         LocatedError.wrap(span: message.keySpan, () {
           if (message is! AliasMessage &&
-              diagnosticClass.includeInDiagnosticCodeValues) {
+              diagnosticClass.package == AnalyzerDiagnosticPackage.analyzer) {
             generatedCodes.add(diagnosticCode);
           }
           message.toAnalyzerCode(

pkg/analyzer_utilities/lib/analyzer_messages.dart

@@ -16,6 +16,10 @@ const codesFile = GeneratedDiagnosticFile(
   parentLibrary: 'package:analyzer/src/error/codes.dart',
 );
 
+/// Enum representing the packages into which analyzer diagnostics can be
+/// generated.
+enum AnalyzerDiagnosticPackage { analyzer, analysisServer, linter }
+
 /// Information about all the classes derived from `DiagnosticCode` that are
 /// code-generated based on the contents of the analyzer and front end
 /// `messages.yaml` files.
@@ -104,7 +108,7 @@ or revisited.
     name: 'TransformSetErrorCode',
     type: 'COMPILE_TIME_ERROR',
     severity: 'ERROR',
-    includeInDiagnosticCodeValues: false,
+    package: AnalyzerDiagnosticPackage.analysisServer,
     comment: '''
 An error code representing a problem in a file containing an encoding of a
 transform set.
@@ -135,6 +139,7 @@ const linterLintCodeInfo = GeneratedDiagnosticClassInfo(
   file: lintCodesFile,
   name: 'LinterLintCode',
   type: 'LINT',
+  package: AnalyzerDiagnosticPackage.linter,
 );
 
 const manifestWarningCodeFile = GeneratedDiagnosticFile(

pkg/analyzer_utilities/lib/messages.dart

@@ -579,9 +579,8 @@ class GeneratedDiagnosticClassInfo extends DiagnosticClassInfo {
   /// deprecation notice) after migration to camel case diagnostic codes.
   final Set<String> deprecatedSnakeCaseNames;
 
-  /// If `true` (the default), diagnostic codes of this class will be included
-  /// in the automatically-generated `diagnosticCodeValues` list.
-  final bool includeInDiagnosticCodeValues;
+  /// The package into which the diagnostic codes will be generated.
+  final AnalyzerDiagnosticPackage package;
 
   /// Documentation comment to generate for the diagnostic class.
   ///
@@ -594,7 +593,7 @@ class GeneratedDiagnosticClassInfo extends DiagnosticClassInfo {
     this.severity,
     required this.type,
     this.deprecatedSnakeCaseNames = const {},
-    this.includeInDiagnosticCodeValues = true,
+    this.package = AnalyzerDiagnosticPackage.analyzer,
     this.comment = '',
   });