DAS: Only yield libraries that provide an extension member with a given name

The `DartFixContext.librariesWithExtensions` utility function accepts
a `memberName` parameter but never did anything with it. This change
adds filtering in that function based on the member name.

This code depends on the set of exported extensions, which is provided
in an extension (`LibraryElementExtensions.exportedExtensions`) in the
analysis_server package, which must be moved to the analyzer package.

Change-Id: I06c8a9a0e11ceb70e75517b30c0b048321d6b024
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/418641
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/cider/fixes.dart

@@ -101,5 +101,5 @@ class _CiderDartFixContextImpl extends DartFixContext {
   }
 
   @override
-  Stream<LibraryElement2> librariesWithExtensions(String memberName) async* {}
+  Stream<LibraryElement2> librariesWithExtensions(Name memberName) async* {}
 }

pkg/analysis_server/lib/src/services/correction/dart/import_library.dart

@@ -6,7 +6,6 @@ import 'dart:collection';
 
 import 'package:analysis_server/src/services/correction/fix.dart';
 import 'package:analysis_server/src/services/correction/namespace.dart';
-import 'package:analysis_server/src/utilities/extensions/element.dart';
 import 'package:analysis_server/src/utilities/extensions/iterable.dart';
 import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analysis_server_plugin/edit/fix/dart_fix_context.dart';
@@ -21,6 +20,7 @@ import 'package:analyzer/source/source_range.dart';
 import 'package:analyzer/src/dart/ast/extensions.dart';
 import 'package:analyzer/src/dart/element/type.dart';
 import 'package:analyzer/src/dart/resolver/applicable_extensions.dart';
+import 'package:analyzer/utilities/extensions/element.dart';
 import 'package:analyzer/utilities/extensions/uri.dart';
 import 'package:analyzer_plugin/src/utilities/change_builder/change_builder_dart.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
@@ -508,7 +508,7 @@ class ImportLibrary extends MultiCorrectionProducer {
       dartFixContext.unitResult.libraryElement2,
       memberName,
     );
-    await for (var libraryToImport in librariesWithExtensions(memberName)) {
+    await for (var libraryToImport in librariesWithExtensions(name)) {
       names.addAll(
         _namesForExtensionInLibrary(libraryToImport, finalTargetType, name),
       );

pkg/analysis_server/lib/src/services/correction/dart/use_different_division_operator.dart

@@ -3,14 +3,14 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/src/services/correction/fix.dart';
-import 'package:analysis_server/src/utilities/extensions/element.dart';
 import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/type.dart';
 import 'package:analyzer/src/dart/resolver/applicable_extensions.dart';
+import 'package:analyzer/utilities/extensions/element.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
@@ -108,7 +108,7 @@ class _UseDifferentDivisionOperator extends ResolvedCorrectionProducer {
       otherOperator.lexeme,
     );
     var hasNoExtensionWithOtherDivisionOperator =
-        await librariesWithExtensions(otherOperator.lexeme).where((library) {
+        await librariesWithExtensions(name).where((library) {
           return library.exportedExtensions
               .havingMemberWithBaseName(name)
               .applicableTo(

pkg/analysis_server/lib/src/utilities/extensions/element.dart

@@ -87,13 +87,6 @@ extension FragmentExtensions on Fragment {
   }
 }
 
-extension LibraryElementExtensions on LibraryElement2 {
-  /// Return all extensions exported from this library.
-  Iterable<ExtensionElement2> get exportedExtensions {
-    return exportNamespace.definedNames2.values.whereType();
-  }
-}
-
 extension MethodElementExtensions on MethodElement2 {
   /// Return `true` if this element represents the method `cast` from either
   /// `Iterable`, `List`, `Map`, or `Set`.

pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart

@@ -779,7 +779,7 @@ sealed class _AbstractCorrectionProducer<T extends ParsedUnitResult> {
 
   /// Returns libraries with extensions that declare non-static public
   /// extension members with the [memberName].
-  Stream<LibraryElement2> librariesWithExtensions(String memberName) {
+  Stream<LibraryElement2> librariesWithExtensions(Name memberName) {
     return _context.dartFixContext!.librariesWithExtensions(memberName);
   }
 }

pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart

@@ -10,7 +10,9 @@ import 'package:analyzer/error/error.dart';
 import 'package:analyzer/instrumentation/service.dart';
 import 'package:analyzer/src/dart/analysis/driver_based_analysis_context.dart';
 import 'package:analyzer/src/dart/analysis/file_state_filter.dart';
+import 'package:analyzer/src/dart/resolver/applicable_extensions.dart';
 import 'package:analyzer/src/services/top_level_declarations.dart';
+import 'package:analyzer/utilities/extensions/element.dart';
 
 /// An object used to provide context information for Dart fix contributors.
 ///
@@ -61,8 +63,7 @@ class DartFixContext implements FixContext {
 
   /// Returns libraries with extensions that declare non-static public
   /// extension members with the [memberName].
-  // TODO(srawlins): The documentation above is wrong; `memberName` is unused.
-  Stream<LibraryElement2> librariesWithExtensions(String memberName) async* {
+  Stream<LibraryElement2> librariesWithExtensions(Name memberName) async* {
     var analysisContext = unitResult.session.analysisContext;
     if (analysisContext is! DriverBasedAnalysisContext) {
       return;
@@ -86,7 +87,11 @@ class DartFixContext implements FixContext {
         continue;
       }
 
-      yield elementResult.element2;
+      if (elementResult.element2.exportedExtensions
+          .havingMemberWithBaseName(memberName)
+          .isNotEmpty) {
+        yield elementResult.element2;
+      }
     }
   }
 }

pkg/analyzer/api.txt

@@ -5318,6 +5318,9 @@ package:analyzer/src/task/api/model.dart:
     source (getter: Source?)
 package:analyzer/src/workspace/workspace.dart:
   Workspace (non-public)
+package:analyzer/utilities/extensions/element.dart:
+  LibraryElement2Extensions (extension on LibraryElement2):
+    exportedExtensions (getter: Iterable<ExtensionElement2>)
 package:analyzer/utilities/extensions/uri.dart:
   UriExtension (extension on Uri):
     isImplementation (getter: bool)

pkg/analyzer/lib/utilities/extensions/element.dart

@@ -0,0 +1,12 @@
+// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:analyzer/dart/element/element2.dart';
+
+extension LibraryElement2Extensions on LibraryElement2 {
+  /// All extensions exported from this library.
+  Iterable<ExtensionElement2> get exportedExtensions {
+    return exportNamespace.definedNames2.values.whereType();
+  }
+}