Skip to content

Commit 63212a3

Browse files
stereotype441Commit Queue
authored andcommitted
[messages] Remove todo fields from linter/messages.yaml.
Converts the `todo:` fields in `pkg/linter/messages.yaml` to simple comments. There's no need for these TODO messages to be structured text. In a follow-up CL I will be reworking the logic that validates the contents of `messages.yaml` fields. Converting these fields to comments means there will be one less thing to worry about when reworking the validation logic. Change-Id: I6a6a6964af29142d6aa9947ed12a7e037b77ead4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458066 Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
1 parent 6b1a3d3 commit 63212a3

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

pkg/linter/messages.yaml

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4747,15 +4747,14 @@ LintCode:
47474747
<-- newline
47484748
```
47494749
erase_dart_type_extension_types:
4750+
# TODO(nshahan): Update.
47504751
parameters: none
47514752
problemMessage: "Unsafe use of 'DartType' in an 'is' check."
47524753
correctionMessage: "Ensure DartType extension types are erased by using a helper method."
47534754
state:
47544755
internal: "3.3"
47554756
categories: [errorProne]
47564757
hasPublishedDocs: false
4757-
todo: |-
4758-
TODO(nshahan): Update.
47594758
deprecatedDetails: |-
47604759
Experimental WIP lint to help ensure `DartType` accesses are safe in the dev_compiler.
47614760
@@ -8907,22 +8906,20 @@ LintCode:
89078906
}
89088907
```
89098908
prefer_contains_always_false:
8909+
# TODO(brianwilkerson): Should be warning rather than lint,
8910+
# as represents a bug rather than style preference.
89108911
parameters: none
89118912
sharedName: prefer_contains
89128913
problemMessage: "Always 'false' because 'indexOf' is always greater than or equal to -1."
89138914
categories: [style]
89148915
hasPublishedDocs: false
8915-
todo: |-
8916-
TODO(brianwilkerson): Should be warning rather than lint,
8917-
as represents a bug rather than style preference.
89188916
prefer_contains_always_true:
8917+
# TODO(brianwilkerson): Should be warning rather than lint,
8918+
# as represents a bug rather than style preference.
89198919
parameters: none
89208920
sharedName: prefer_contains
89218921
problemMessage: "Always 'true' because 'indexOf' is always greater than or equal to -1."
89228922
hasPublishedDocs: false
8923-
todo: |-
8924-
TODO(brianwilkerson): Should be warning rather than lint,
8925-
as represents a bug rather than style preference.
89268923
prefer_contains_use_contains:
89278924
parameters: none
89288925
sharedName: prefer_contains
@@ -10064,22 +10061,20 @@ LintCode:
1006410061
'Hello, ${person.name} from ${person.city}.'
1006510062
```
1006610063
prefer_is_empty_always_false:
10064+
# TODO(brianwilkerson): Should be warning rather than lint,
10065+
# as represents a bug rather than style preference.
1006710066
parameters: none
1006810067
sharedName: prefer_is_empty
1006910068
problemMessage: "The comparison is always 'false' because the length is always greater than or equal to 0."
1007010069
categories: [errorProne]
1007110070
hasPublishedDocs: false
10072-
todo: |-
10073-
TODO(brianwilkerson): Should be warning rather than lint,
10074-
as represents a bug rather than style preference.
1007510071
prefer_is_empty_always_true:
10072+
# TODO(brianwilkerson): Should be warning rather than lint,
10073+
# as represents a bug rather than style preference.
1007610074
parameters: none
1007710075
sharedName: prefer_is_empty
1007810076
problemMessage: "The comparison is always 'true' because the length is always greater than or equal to 0."
1007910077
hasPublishedDocs: false
10080-
todo: |-
10081-
TODO(brianwilkerson): Should be warning rather than lint,
10082-
as represents a bug rather than style preference.
1008310078
prefer_is_empty_use_is_empty:
1008410079
parameters: none
1008510080
sharedName: prefer_is_empty

0 commit comments

Comments
 (0)