[analyzer] Dot Shorthands: Store DotShorthandPropertyAccess in summary.

Testing - Language tests stop crashing, some passing (the failures are from other unimplemented things). Added a unit test for a top level dot shorthand.

Bug: #59835
Change-Id: I885cfc5c33b0b206aeae73438c765f73f4c9175f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422845
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -100,7 +100,7 @@ import 'package:meta/meta.dart';
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 452;
+  static const int DATA_VERSION = 453;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/summary2/ast_binary_reader.dart

@@ -65,6 +65,8 @@ class AstBinaryReader {
         return _readDeclaredIdentifier();
       case Tag.DefaultFormalParameter:
         return _readDefaultFormalParameter();
+      case Tag.DotShorthandPropertyAccess:
+        return _readDotShorthandPropertyAccess();
       case Tag.DottedName:
         return _readDottedName();
       case Tag.DoubleLiteral:
@@ -467,6 +469,16 @@ class AstBinaryReader {
     return node;
   }
 
+  DotShorthandPropertyAccess _readDotShorthandPropertyAccess() {
+    var propertyName = readNode() as SimpleIdentifierImpl;
+    var node = DotShorthandPropertyAccessImpl(
+      period: Tokens.period(),
+      propertyName: propertyName,
+    );
+    _readExpressionResolution(node);
+    return node;
+  }
+
   DottedName _readDottedName() {
     var components = _readNodeList<SimpleIdentifierImpl>();
     return DottedNameImpl(

pkg/analyzer/lib/src/summary2/ast_binary_tag.dart

@@ -47,6 +47,7 @@ class Tag {
   static const int DeclaredIdentifier = 90;
   static const int DefaultFormalParameter = 8;
   static const int DottedName = 47;
+  static const int DotShorthandPropertyAccess = 113;
   static const int DoubleLiteral = 9;
   static const int ExtensionOverride = 87;
   static const int FieldFormalParameter = 16;

pkg/analyzer/lib/src/summary2/ast_binary_writer.dart

@@ -228,6 +228,13 @@ class AstBinaryWriter extends ThrowingAstVisitor<void> {
     _writeOptionalNode(defaultValue);
   }
 
+  @override
+  void visitDotShorthandPropertyAccess(DotShorthandPropertyAccess node) {
+    _writeByte(Tag.DotShorthandPropertyAccess);
+    _writeNode(node.propertyName);
+    _storeExpression(node);
+  }
+
   @override
   void visitDottedName(DottedName node) {
     _writeByte(Tag.DottedName);

pkg/analyzer/lib/src/summary2/informative_data.dart

@@ -2314,6 +2314,12 @@ abstract class _OffsetsAstVisitor extends RecursiveAstVisitor<void> {
     node.name?.accept(this);
   }
 
+  @override
+  void visitDotShorthandPropertyAccess(DotShorthandPropertyAccess node) {
+    _tokenOrNull(node.period);
+    node.propertyName.accept(this);
+  }
+
   @override
   void visitDoubleLiteral(DoubleLiteral node) {
     _tokenOrNull(node.literal);

pkg/analyzer/test/src/summary/elements/const_test.dart

@@ -591,6 +591,104 @@ library
 ''');
   }
 
+  test_const_dotShorthand_property() async {
+    var library = await buildLibrary(r'''
+class A {
+  static const A a = A();
+  const A();
+}
+
+const A a = .a;
+''');
+    checkElementText(library, r'''
+library
+  reference: <testLibrary>
+  fragments
+    <testLibraryFragment>
+      element: <testLibrary>
+      classes
+        class A @6
+          reference: <testLibraryFragment>::@class::A
+          element: <testLibrary>::@class::A
+          fields
+            hasInitializer a @27
+              reference: <testLibraryFragment>::@class::A::@field::a
+              element: <testLibraryFragment>::@class::A::@field::a#element
+              initializer: expression_0
+                InstanceCreationExpression
+                  constructorName: ConstructorName
+                    type: NamedType
+                      name: A @31
+                      element2: <testLibrary>::@class::A
+                      type: A
+                    element: <testLibraryFragment>::@class::A::@constructor::new#element
+                  argumentList: ArgumentList
+                    leftParenthesis: ( @32
+                    rightParenthesis: ) @33
+                  staticType: A
+              getter2: <testLibraryFragment>::@class::A::@getter::a
+          constructors
+            const new
+              reference: <testLibraryFragment>::@class::A::@constructor::new
+              element: <testLibraryFragment>::@class::A::@constructor::new#element
+              typeName: A
+              typeNameOffset: 44
+          getters
+            synthetic get a
+              reference: <testLibraryFragment>::@class::A::@getter::a
+              element: <testLibraryFragment>::@class::A::@getter::a#element
+      topLevelVariables
+        hasInitializer a @60
+          reference: <testLibraryFragment>::@topLevelVariable::a
+          element: <testLibrary>::@topLevelVariable::a
+          initializer: expression_1
+            DotShorthandPropertyAccess
+              period: . @64
+              propertyName: SimpleIdentifier
+                token: a @65
+                element: <testLibraryFragment>::@class::A::@getter::a#element
+                staticType: A
+              staticType: A
+          getter2: <testLibraryFragment>::@getter::a
+      getters
+        synthetic get a
+          reference: <testLibraryFragment>::@getter::a
+          element: <testLibraryFragment>::@getter::a#element
+  classes
+    class A
+      reference: <testLibrary>::@class::A
+      firstFragment: <testLibraryFragment>::@class::A
+      fields
+        static const hasInitializer a
+          firstFragment: <testLibraryFragment>::@class::A::@field::a
+          type: A
+          constantInitializer
+            fragment: <testLibraryFragment>::@class::A::@field::a
+            expression: expression_0
+          getter: <testLibraryFragment>::@class::A::@getter::a#element
+      constructors
+        const new
+          firstFragment: <testLibraryFragment>::@class::A::@constructor::new
+      getters
+        synthetic static get a
+          firstFragment: <testLibraryFragment>::@class::A::@getter::a
+          returnType: A
+  topLevelVariables
+    const hasInitializer a
+      reference: <testLibrary>::@topLevelVariable::a
+      firstFragment: <testLibraryFragment>::@topLevelVariable::a
+      type: A
+      constantInitializer
+        fragment: <testLibraryFragment>::@topLevelVariable::a
+        expression: expression_1
+      getter: <testLibraryFragment>::@getter::a#element
+  getters
+    synthetic static get a
+      firstFragment: <testLibraryFragment>::@getter::a
+      returnType: A
+''');
+  }
+
   test_const_finalField_hasConstConstructor() async {
     var library = await buildLibrary(r'''
 class C {