DAS: report exceptions caught in plugin isolate as plugin exceptions

This change means that during `dart analyze`, an exception caught in a plugin isolate will be printed to the terminal, and the process will
exit (similar to the support for when the isolate has static errors).

Change-Id: I31b1ebe7a71a331274d4f1dc1ea1b94f33e2329b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415981
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/plugin/plugin_manager.dart

@@ -1057,6 +1057,17 @@ class PluginSession {
       completer,
     );
     channel.sendRequest(request);
+    completer.future.then((response) {
+      // If a RequestError is returned in the response, report this as an
+      // exception.
+      if (response.error case var error?) {
+        var stackTrace = StackTrace.fromString(error.stackTrace!);
+        var exception = PluginException(error.message);
+        info.reportException(
+          CaughtException.withMessage(error.message, exception, stackTrace),
+        );
+      }
+    });
     return completer.future;
   }
 

pkg/analysis_server/test/src/plugin/plugin_manager_test.dart

@@ -171,12 +171,7 @@ class DiscoveredPluginInfoTest with ResourceProviderMixin, _ContextRoot {
 
   Future<void> test_start_running() async {
     plugin.currentSession = PluginSession(plugin);
-    try {
-      await plugin.start('', '');
-      fail('Expected a StateError');
-    } on StateError {
-      // Expected.
-    }
+    expect(() => plugin.start('', ''), throwsStateError);
   }
 
   void test_stop_notRunning() {
@@ -764,6 +759,32 @@ class PluginSessionTest with ResourceProviderMixin {
     expect(result, same(response));
   }
 
+  Future<void> test_handleResponse_withError() async {
+    TestServerCommunicationChannel(session);
+    var response = Response(
+      '0' /* id */,
+      1 /* requestTime */,
+      error: RequestError(
+        RequestErrorCode.PLUGIN_ERROR,
+        'exception',
+        stackTrace: 'some stackTrace',
+      ),
+    );
+
+    var responseFuture = session.sendRequest(
+      PluginVersionCheckParams('', '', ''),
+    );
+    session.handleResponse(response);
+    await responseFuture;
+    expect(
+      notificationManager.pluginErrors,
+      equals([
+        'An error occurred while executing an analyzer plugin: exception\n'
+            'some stackTrace',
+      ]),
+    );
+  }
+
   void test_nextRequestId() {
     expect(session.requestId, 0);
     expect(session.nextRequestId, '0');
@@ -794,12 +815,7 @@ class PluginSessionTest with ResourceProviderMixin {
 
   Future<void> test_start_running() async {
     TestServerCommunicationChannel(session);
-    try {
-      await session.start('', '');
-      fail('Expected a StateError to be thrown');
-    } on StateError {
-      // Expected behavior
-    }
+    expect(() => session.start('', ''), throwsStateError);
   }
 
   void test_stop_notRunning() {