[analyzer] Adds new message for INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR

Fixes: #61680
Change-Id: I3f5e0e722125a05bcc0f7ff4f9f785c584b7d94b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453360
Auto-Submit: Felipe Morschel <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -1000,6 +1000,9 @@ CompileTimeErrorCode.INVALID_OVERRIDE_SETTER:
 CompileTimeErrorCode.INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR:
   status: noFix
   since: 2.17
+CompileTimeErrorCode.INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR_TEAROFF:
+  status: noFix
+  since: 2.17
 CompileTimeErrorCode.INVALID_REFERENCE_TO_THIS:
   status: noFix
 CompileTimeErrorCode.INVALID_SUPER_FORMAL_PARAMETER_LOCATION:

pkg/analyzer/lib/src/diagnostic/diagnostic_code_values.g.dart

@@ -325,6 +325,7 @@ const List<DiagnosticCode> diagnosticCodeValues = [
   CompileTimeErrorCode.invalidOverride,
   CompileTimeErrorCode.invalidOverrideSetter,
   CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructor,
+  CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructorTearoff,
   CompileTimeErrorCode.invalidReferenceToThis,
   CompileTimeErrorCode.invalidSuperFormalParameterLocation,
   CompileTimeErrorCode.invalidTypeArgumentInConstList,

pkg/analyzer/lib/src/error/codes.g.dart

@@ -4031,12 +4031,24 @@ class CompileTimeErrorCode extends DiagnosticCodeWithExpectedTypes {
   static const CompileTimeErrorWithoutArguments
   invalidReferenceToGenerativeEnumConstructor = CompileTimeErrorWithoutArguments(
     'INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR',
-    "Generative enum constructors can only be used as targets of redirection.",
+    "Generative enum constructors can only be used to create an enum constant.",
     correctionMessage: "Try using an enum value, or a factory constructor.",
     hasPublishedDocs: true,
     expectedTypes: [],
   );
 
+  /// No parameters.
+  static const CompileTimeErrorWithoutArguments
+  invalidReferenceToGenerativeEnumConstructorTearoff =
+      CompileTimeErrorWithoutArguments(
+        'INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR',
+        "Generative enum constructors can't be torn off.",
+        correctionMessage: "Try using an enum value, or a factory constructor.",
+        hasPublishedDocs: true,
+        uniqueName: 'INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR_TEAROFF',
+        expectedTypes: [],
+      );
+
   /// No parameters.
   static const CompileTimeErrorWithoutArguments invalidReferenceToThis =
       CompileTimeErrorWithoutArguments(

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -3860,10 +3860,20 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
         constructorElement.isGenerative &&
         constructorElement.enclosingElement is EnumElement) {
       if (_currentLibrary.featureSet.isEnabled(Feature.enhanced_enums)) {
-        diagnosticReporter.atNode(
-          node,
-          CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructor,
-        );
+        if (node.parent case ConstructorReference(
+          :var parent,
+        ) when parent is! InstanceCreationExpression) {
+          diagnosticReporter.atNode(
+            node,
+            CompileTimeErrorCode
+                .invalidReferenceToGenerativeEnumConstructorTearoff,
+          );
+        } else {
+          diagnosticReporter.atNode(
+            node,
+            CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructor,
+          );
+        }
       } else {
         diagnosticReporter.atNode(node, CompileTimeErrorCode.instantiateEnum);
       }

pkg/analyzer/messages.yaml

@@ -9079,7 +9079,7 @@ CompileTimeErrorCode:
     hasPublishedDocs: true
   INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR:
     parameters: none
-    problemMessage: Generative enum constructors can only be used as targets of redirection.
+    problemMessage: Generative enum constructors can only be used to create an enum constant.
     correctionMessage: Try using an enum value, or a factory constructor.
     hasPublishedDocs: true
     documentation: |-
@@ -9134,6 +9134,12 @@ CompileTimeErrorCode:
 
       E f() => E.c(2);
       ```
+  INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR_TEAROFF:
+    sharedName: INVALID_REFERENCE_TO_GENERATIVE_ENUM_CONSTRUCTOR
+    parameters: none
+    problemMessage: Generative enum constructors can't be torn off.
+    correctionMessage: Try using an enum value, or a factory constructor.
+    hasPublishedDocs: true
   INVALID_REFERENCE_TO_THIS:
     parameters: none
     problemMessage: "Invalid reference to 'this' expression."

pkg/analyzer/test/src/diagnostics/invalid_reference_to_generative_enum_constructor_test.dart

@@ -62,7 +62,8 @@ void f() {
 ''',
       [
         error(
-          CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructor,
+          CompileTimeErrorCode
+              .invalidReferenceToGenerativeEnumConstructorTearoff,
           58,
           7,
         ),
@@ -142,7 +143,8 @@ void f() {
 ''',
       [
         error(
-          CompileTimeErrorCode.invalidReferenceToGenerativeEnumConstructor,
+          CompileTimeErrorCode
+              .invalidReferenceToGenerativeEnumConstructorTearoff,
           29,
           5,
         ),