Fine. Add tests for most BaseNameMembers states and transitions.

No coverage yet for combinations with inherited constructors.

This set of tests relies on the fact that we iterate over declared executables in a specific order: constructors, methods, getters, setters.

Change-Id: I1631be49ea3388243819ba7a26b567662dbdc860
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424703
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -233,7 +233,11 @@ class LibraryManifestBuilder {
       var baseName = lookupName.asBaseName;
       switch (executable) {
         case MethodElementImpl2():
-          item.members.addInheritedMethod(baseName, id);
+          if (lookupName.isIndexEq) {
+            item.members.addInheritedIndexEq(baseName, id);
+          } else {
+            item.members.addInheritedMethod(baseName, id);
+          }
         case GetterElementImpl():
           item.members.addInheritedGetter(baseName, id);
         case SetterElementImpl():
@@ -257,19 +261,19 @@ class LibraryManifestBuilder {
     required InstanceElementImpl2 instanceElement,
     required InstanceItem instanceItem,
   }) {
-    for (var getter in instanceElement.getters2) {
-      _addInstanceElementGetter(
+    for (var method in instanceElement.methods2) {
+      _addInstanceElementMethod(
         encodingContext: encodingContext,
         instanceItem: instanceItem,
-        element: getter,
+        element: method,
       );
     }
 
-    for (var method in instanceElement.methods2) {
-      _addInstanceElementMethod(
+    for (var getter in instanceElement.getters2) {
+      _addInstanceElementGetter(
         encodingContext: encodingContext,
         instanceItem: instanceItem,
-        element: method,
+        element: getter,
       );
     }
 
@@ -855,7 +859,10 @@ class _LibraryMatch {
         _addMatchingElementItem(executable, item, matchContext);
         return true;
       case MethodElementImpl2():
-        var item = members[baseName]?.declaredMethod;
+        var item =
+            lookupName.isIndexEq
+                ? members[baseName]?.declaredIndexEq
+                : members[baseName]?.declaredMethod;
         if (item is! InstanceItemMethodItem) {
           return false;
         }