analyzer: For Deprecated.optional warnings, test indirect constructor invocations

In this CL we add tests that assert that redirected constructors are
not visited indirectly / transitively when checking for
`@Deprecated.optional` parameters. This is a follow-up from comments
in https://dart-review.googlesource.com/c/sdk/+/457120.


Change-Id: I00d489cc22f928fbb538f4fd3c0ca9fb5cb19b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458081
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: srawlins

pkg/analyzer/test/src/diagnostics/deprecated_optional_test.dart

@@ -290,6 +290,26 @@ class C {
     );
   }
 
+  test_argumentOmitted_redirectedConstructor_indirectlyDeprecated() async {
+    // This test asserts that we do _not_ report the `C.three` constructor.
+    // While the `C.two` constructor must deal with the deprecation of the
+    // optionality of `C.new`'s `p` parameter, there is nothing to do for
+    // `C.three`. (For example, we can't pass a positional argument to
+    // `this.two()`, because `C.two` does not accept a positional parameter.)
+    // Whether and how `C.three` must change depends on how `C.two` is changed
+    // to handle the deprecation.
+    await assertErrorsInCode(
+      r'''
+class C {
+  C([@Deprecated.optional() int? p]);
+  C.two() : this();
+  C.three() : this.two();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 60, 4)],
+    );
+  }
+
   test_argumentOmitted_redirectedConstructor_named() async {
     await assertErrorsInCode(
       r'''
@@ -378,6 +398,31 @@ class D extends C {
     );
   }
 
+  test_argumentOmitted_superInvocation_indirectlyDeprecated() async {
+    // This test asserts that we do _not_ report the `E.new` constructor. While
+    // the `D.new` constructor must deal with the deprecation of the optionality
+    // of `C.new`'s `p` parameter, there is nothing to do for `E.new`. (For
+    // example, we can't pass a positional argument to `super()`, because
+    // `D.new` does not accept a positional parameter.) Whether and how `E.new`
+    // must change depends on how `D.new` is changed to handle the deprecation.
+    await assertErrorsInCode(
+      r'''
+class C {
+  C([@Deprecated.optional() int? p]);
+}
+
+class D extends C {
+  D() : super();
+}
+
+class E extends D {
+  E() : super();
+}
+''',
+      [error(WarningCode.deprecatedOptional, 79, 5)],
+    );
+  }
+
   test_argumentOmitted_superInvocation_namedParameter() async {
     await assertErrorsInCode(
       r'''