[cfe] Make Factory/TypeAliasConstructor extend InternalExpression

This decouples these internal nodes from the ExpressionJudgment making a clearer distinction between pre- and post-inference nodes.

A lot of helpers have also been moved to the inference visitor since they are only used there.

Change-Id: I6c7278f5fc6cec6753169e6fd75d4307a9dcdf36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448384
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/builder/metadata_builder.dart

@@ -74,6 +74,7 @@ class MetadataBuilder {
     // store it in `_expression` of the corresponding [MetadataBuilder].
     Map<MetadataBuilder, int> parsedAnnotationBuilders = {};
 
+    List<int> indicesOfAnnotationsToBeInferred = [];
     for (int i = 0; i < metadata.length; ++i) {
       MetadataBuilder annotationBuilder = metadata[i];
       bool createFileUriExpression =
@@ -118,8 +119,9 @@ class MetadataBuilder {
           )..fileOffset = annotationBuilder.atOffset;
         }
         // Record the index of [annotation] in `parent.annotations`.
-        parsedAnnotationBuilders[annotationBuilder] =
-            annotatable.annotations.length;
+        int annotationIndex = annotatable.annotations.length;
+        parsedAnnotationBuilders[annotationBuilder] = annotationIndex;
+        indicesOfAnnotationsToBeInferred.add(annotationIndex);
         // It is important for the inference and backlog computations that the
         // annotation is already a child of [parent].
         annotatable.addAnnotation(annotation);
@@ -156,9 +158,11 @@ class MetadataBuilder {
       }
     }
     if (bodyBuilder != null) {
-      // TODO(johnniwinther): Avoid potentially inferring annotations multiple
-      // times.
-      bodyBuilder.inferAnnotations(annotatable, annotatable.annotations);
+      bodyBuilder.inferAnnotations(
+        annotatable,
+        annotatable.annotations,
+        indices: indicesOfAnnotationsToBeInferred,
+      );
       bodyBuilder.performBacklogComputations();
       for (MapEntry<MetadataBuilder, int> entry
           in parsedAnnotationBuilders.entries) {

pkg/front_end/lib/src/fragment/enum_element.dart

@@ -408,16 +408,14 @@ class EnumElementDeclaration
         _field!.initializer = bodyBuilder.buildUnresolvedError(
           fullConstructorNameForErrors,
           fileOffset,
-          arguments: arguments,
           kind: UnresolvedKind.Constructor,
         )..parent = _field;
       } else {
-        Expression initializer = bodyBuilder.buildStaticInvocation(
+        Expression initializer = bodyBuilder.buildConstructorInvocation(
           constructorBuilder.invokeTarget,
           arguments,
           constness: Constness.explicitConst,
-          charOffset: nameOffset,
-          isConstructorInvocation: true,
+          fileOffset: nameOffset,
         );
         ExpressionInferenceResult inferenceResult = bodyBuilder.typeInferrer
             .inferFieldInitializer(