Skip to content

Commit 67c6da2

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[vm, gc] Shorten extent of the freelist lock during scavenge.
Helps break a cycle for https://dart-review.googlesource.com/c/sdk/+/435241 TEST=ci Change-Id: I98994a3d2f5e11f0f9bb20e38d3c2b9fa9e48d08 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/436521 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 077e1be commit 67c6da2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

runtime/vm/heap/scavenger.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,7 @@ class ScavengerVisitor : public ObjectPointerVisitor,
320320
}
321321

322322
void ProcessWeak() {
323+
page_space_->ReleaseLock(freelist_);
323324
if (!scavenger_->abort_) {
324325
ASSERT(!HasWork());
325326

@@ -334,7 +335,6 @@ class ScavengerVisitor : public ObjectPointerVisitor,
334335
MournFinalizerEntries();
335336
scavenger_->IterateWeak();
336337
}
337-
page_space_->ReleaseLock(freelist_);
338338
thread_ = nullptr;
339339
}
340340

0 commit comments

Comments
 (0)