[messages] Use all lower case in lint_names.g.dart.

Now that lint name matching is case insensitive
(https://dart-review.googlesource.com/c/sdk/+/465964), it is no longer
necessary for the lint names `no_runtimeType_toString`,
`prefer_for_elements_to_map_fromIterable`, and
`prefer_iterable_whereType` to be in mixed case in
`lint_names.g.dart`.

This change adjusts them to all lower case, and renames the
corresponding declarations too. This paves the way for a follow-up CL
that will change the case conventions in `pkg/linter/messages.yaml`.

Change-Id: I6a6a6964381f9573dd735bde0ae8dfb103eef174
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465991
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: stereotype441

pkg/analysis_server/test/src/services/correction/assist/convert_to_for_element_test.dart

@@ -63,7 +63,7 @@ f(Iterable<int> i) {
   Future<void>
   test_mapFromIterable_differentParameterNames_usedInKey_conflictInValue_noAssistWithLint() async {
     createAnalysisOptionsFile(
-      lints: [LintNames.prefer_for_elements_to_map_fromIterable],
+      lints: [LintNames.prefer_for_elements_to_map_fromiterable],
     );
     verifyNoTestUnitErrors = false;
     await resolveTestCode('''

pkg/analysis_server/test/src/services/correction/fix/convert_to_for_element_test.dart

@@ -19,7 +19,7 @@ void main() {
 @reflectiveTest
 class ConvertToForElementBulkTest extends BulkFixProcessorTest {
   @override
-  String get lintCode => LintNames.prefer_for_elements_to_map_fromIterable;
+  String get lintCode => LintNames.prefer_for_elements_to_map_fromiterable;
 
   Future<void> test_singleFile() async {
     await resolveTestCode('''
@@ -51,7 +51,7 @@ class ConvertToForElementTest extends FixProcessorLintTest {
   FixKind get kind => DartFixKind.convertToForElement;
 
   @override
-  String get lintCode => LintNames.prefer_for_elements_to_map_fromIterable;
+  String get lintCode => LintNames.prefer_for_elements_to_map_fromiterable;
 
   /// More coverage in the `convert_to_for_element_line_test.dart` assist test.
   Future<void>

pkg/analysis_server/test/src/services/correction/fix/convert_to_where_type_test.dart

@@ -19,7 +19,7 @@ void main() {
 @reflectiveTest
 class ConvertToWhereTypeBulkTest extends BulkFixProcessorTest {
   @override
-  String get lintCode => LintNames.prefer_iterable_whereType;
+  String get lintCode => LintNames.prefer_iterable_wheretype;
 
   Future<void> test_singleFile() async {
     await resolveTestCode('''
@@ -49,7 +49,7 @@ class ConvertToWhereTypeTest extends FixProcessorLintTest {
   FixKind get kind => DartFixKind.convertToWhereType;
 
   @override
-  String get lintCode => LintNames.prefer_iterable_whereType;
+  String get lintCode => LintNames.prefer_iterable_wheretype;
 
   Future<void> test_default_declaredType() async {
     await resolveTestCode('''

pkg/linter/lib/src/lint_names.g.dart

@@ -310,7 +310,7 @@ abstract final class LintNames {
 
   static const String no_logic_in_create_state = 'no_logic_in_create_state';
 
-  static const String no_runtimeType_toString = 'no_runtimeType_toString';
+  static const String no_runtimetype_tostring = 'no_runtimetype_tostring';
 
   static const String no_self_assignments = 'no_self_assignments';
 
@@ -400,8 +400,8 @@ abstract final class LintNames {
 
   static const String prefer_final_parameters = 'prefer_final_parameters';
 
-  static const String prefer_for_elements_to_map_fromIterable =
-      'prefer_for_elements_to_map_fromIterable';
+  static const String prefer_for_elements_to_map_fromiterable =
+      'prefer_for_elements_to_map_fromiterable';
 
   static const String prefer_foreach = 'prefer_foreach';
 
@@ -432,7 +432,7 @@ abstract final class LintNames {
 
   static const String prefer_is_not_operator = 'prefer_is_not_operator';
 
-  static const String prefer_iterable_whereType = 'prefer_iterable_whereType';
+  static const String prefer_iterable_wheretype = 'prefer_iterable_wheretype';
 
   static const String prefer_mixin = 'prefer_mixin';
 

pkg/linter/lib/src/rules/no_runtimeType_toString.dart

@@ -19,7 +19,7 @@ const _desc = r'Avoid calling `toString()` on `runtimeType`.';
 
 class NoRuntimeTypeToString extends AnalysisRule {
   NoRuntimeTypeToString()
-    : super(name: LintNames.no_runtimeType_toString, description: _desc);
+    : super(name: LintNames.no_runtimetype_tostring, description: _desc);
 
   @override
   DiagnosticCode get diagnosticCode => diag.noRuntimetypeTostring;

pkg/linter/lib/src/rules/prefer_for_elements_to_map_fromIterable.dart

@@ -18,7 +18,7 @@ const _desc = r'Prefer `for` elements when building maps from iterables.';
 class PreferForElementsToMapFromIterable extends AnalysisRule {
   PreferForElementsToMapFromIterable()
     : super(
-        name: LintNames.prefer_for_elements_to_map_fromIterable,
+        name: LintNames.prefer_for_elements_to_map_fromiterable,
         description: _desc,
       );
 

pkg/linter/lib/src/rules/prefer_iterable_whereType.dart

@@ -18,7 +18,7 @@ const _desc = r'Prefer to use `whereType` on iterable.';
 
 class PreferIterableWhereType extends AnalysisRule {
   PreferIterableWhereType()
-    : super(name: LintNames.prefer_iterable_whereType, description: _desc);
+    : super(name: LintNames.prefer_iterable_wheretype, description: _desc);
 
   @override
   DiagnosticCode get diagnosticCode => diag.preferIterableWheretype;

pkg/linter/test/rules/no_runtimeType_toString_test.dart

@@ -16,7 +16,7 @@ void main() {
 @reflectiveTest
 class NoRuntimeTypeToStringTest extends LintRuleTest {
   @override
-  String get lintRule => LintNames.no_runtimeType_toString;
+  String get lintRule => LintNames.no_runtimetype_tostring;
 
   test_extension_onAbstractClass() async {
     await assertNoDiagnostics(r'''

pkg/linter/test/rules/prefer_for_elements_to_map_fromIterable_test.dart

@@ -19,7 +19,7 @@ class PreferForElementsToMapFromIterableTest extends LintRuleTest {
   // TODO(srawlins): Add tests with block-bodied closures.
 
   @override
-  String get lintRule => LintNames.prefer_for_elements_to_map_fromIterable;
+  String get lintRule => LintNames.prefer_for_elements_to_map_fromiterable;
 
   test_hasKeyAndValue_closuresAreSimple() async {
     await assertDiagnostics(

pkg/linter/test/rules/prefer_iterable_whereType_test.dart

@@ -17,7 +17,7 @@ void main() {
 @reflectiveTest
 class PreferIterableWhereTypeTest extends LintRuleTest {
   @override
-  String get lintRule => LintNames.prefer_iterable_whereType;
+  String get lintRule => LintNames.prefer_iterable_wheretype;
 
   test_closureWithIs() async {
     await assertDiagnostics(