Skip to content

Commit 6880ea8

Browse files
iinozemtsevCommit Queue
authored andcommitted
Remove unused variables in Windows code
Upstreaming internal changes required to enforce `-Wunused-variable` and `-Wunused-result` on Windows. Tested: ci Change-Id: I98d9ba8eeebf4dd8520b4263f4a57039c28020ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404840 Commit-Queue: Alexander Aprelev <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]> Auto-Submit: Ivan Inozemtsev <[email protected]>
1 parent afcfe1e commit 6880ea8

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

runtime/bin/eventhandler_win.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -852,7 +852,7 @@ intptr_t ClientSocket::disconnecting_ = 0;
852852
#endif
853853

854854
void ClientSocket::Shutdown(int how) {
855-
int rc = shutdown(socket(), how);
855+
shutdown(socket(), how);
856856
if (how == SD_RECEIVE) {
857857
MarkClosedRead();
858858
}

runtime/vm/native_symbol_win.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ const char* NativeSymbolResolver::LookupSymbolName(uword pc, uword* start) {
6363
const intptr_t kMaxNameLength = 2048;
6464
const intptr_t kSymbolInfoSize = sizeof(SYMBOL_INFO); // NOLINT.
6565
static char buffer[kSymbolInfoSize + kMaxNameLength];
66-
static char name_buffer[kMaxNameLength];
6766
MutexLocker lock(lock_);
6867
if (!running_) {
6968
return nullptr;

runtime/vm/os_win.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ intptr_t OS::ProcessId() {
3131
const int64_t kTimeEpoc = 116444736000000000LL;
3232

3333
static bool LocalTime(int64_t seconds_since_epoch, tm* tm_result) {
34-
time_t seconds = static_cast<time_t>(seconds_since_epoch);
3534
SYSTEMTIME systemTime;
3635
union {
3736
FILETIME fileTime;

0 commit comments

Comments
 (0)