Skip to content

Commit 69c62b1

Browse files
scheglovCommit Queue
authored andcommitted
Remove shipped features, and deprecated experiments from tests.
Change-Id: I428906a1d75a0dacedc8a5d5fd805f84ca8e3ce0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311156 Reviewed-by: Samuel Rawlins <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent f7e26c5 commit 69c62b1

File tree

6 files changed

+4
-51
lines changed

6 files changed

+4
-51
lines changed

pkg/analysis_server/test/abstract_context.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,8 @@ class AbstractContextTest with ResourceProviderMixin {
5555
/// Return a list of the experiments that are to be enabled for tests in this
5656
/// class, an empty list if there are no experiments that should be enabled.
5757
List<String> get experiments => [
58-
EnableString.class_modifiers,
58+
EnableString.inline_class,
5959
EnableString.macros,
60-
EnableString.patterns,
61-
EnableString.records,
62-
EnableString.sealed_class,
6360
];
6461

6562
String get latestLanguageVersion =>

pkg/analysis_server/test/analysis_server_base.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,8 @@ class PubPackageAnalysisServerTest extends ContextResolutionTest {
222222
// add `import 'package:analyzer/dart/analysis/features.dart';`
223223
// and list the necessary experiments here.
224224
List<String> get experiments => [
225-
Feature.class_modifiers.enableString,
225+
Feature.inline_class.enableString,
226226
Feature.macros.enableString,
227-
Feature.patterns.enableString,
228-
Feature.records.enableString,
229-
Feature.sealed_class.enableString,
230227
];
231228

232229
/// The path that is not in [workspaceRootPath], contains external packages.

pkg/analysis_server/test/lsp/hover_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ class HoverTest extends AbstractLspAnalysisServerTest {
2525
@override
2626
AnalysisServerOptions get serverOptions => AnalysisServerOptions()
2727
..enabledExperiments = [
28-
EnableString.records,
29-
EnableString.patterns,
28+
EnableString.inline_class,
29+
EnableString.macros,
3030
];
3131

3232
/// Checks whether the correct types of documentation are returned in a Hover

pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,38 +1285,6 @@ $code
12851285
// [AstTestFactory.identifier3('o')])));
12861286
}
12871287

1288-
void test_visitExtensionTypeDeclaration_empty() {
1289-
final code = 'extension type E on C {}';
1290-
final findNode = _parseStringToFindNode('''
1291-
$code
1292-
''');
1293-
_assertSource(code, findNode.extensionDeclaration(code));
1294-
}
1295-
1296-
void test_visitExtensionTypeDeclaration_multipleMember() {
1297-
final code = 'extension type E on C {static var a; static var b;}';
1298-
final findNode = _parseStringToFindNode('''
1299-
$code
1300-
''');
1301-
_assertSource(code, findNode.extensionDeclaration(code));
1302-
}
1303-
1304-
void test_visitExtensionTypeDeclaration_parameters() {
1305-
final code = 'extension type E<T> on C {}';
1306-
final findNode = _parseStringToFindNode('''
1307-
$code
1308-
''');
1309-
_assertSource(code, findNode.extensionDeclaration(code));
1310-
}
1311-
1312-
void test_visitExtensionTypeDeclaration_singleMember() {
1313-
final code = 'extension type E on C {static var a;}';
1314-
final findNode = _parseStringToFindNode('''
1315-
$code
1316-
''');
1317-
_assertSource(code, findNode.extensionDeclaration(code));
1318-
}
1319-
13201288
void test_visitFieldDeclaration_abstract() {
13211289
final code = 'abstract var a;';
13221290
final findNode = _parseStringToFindNode('''

pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -327,13 +327,9 @@ class PubPackageResolutionTest extends ContextResolutionTest {
327327
List<String> get collectionIncludedPaths => [workspaceRootPath];
328328

329329
List<String> get experiments => [
330-
EnableString.class_modifiers,
331330
EnableString.inference_update_2,
332331
EnableString.inline_class,
333332
EnableString.macros,
334-
EnableString.patterns,
335-
EnableString.records,
336-
EnableString.sealed_class,
337333
];
338334

339335
@override

pkg/analyzer/test/util/feature_sets.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,8 @@ class FeatureSets {
4747
static final FeatureSet latestWithExperiments = FeatureSet.fromEnableFlags2(
4848
sdkLanguageVersion: ExperimentStatus.currentVersion,
4949
flags: [
50-
Feature.class_modifiers.enableString,
51-
Feature.extension_types.enableString,
5250
Feature.inline_class.enableString,
5351
Feature.macros.enableString,
54-
Feature.patterns.enableString,
55-
Feature.records.enableString,
56-
Feature.sealed_class.enableString,
5752
],
5853
);
5954

0 commit comments

Comments
 (0)