Elements. Use impl types in a few places to avoid casts.

Change-Id: Ie33893b896d6259a8604d1768cd21f7d44a6fefd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401120
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -914,7 +914,7 @@ class AnalysisDriver {
         }
 
         var unitResult = await getUnitElement(file.path);
-        if (unitResult is UnitElementResult) {
+        if (unitResult is UnitElementResultImpl) {
           return LibraryElementResultImpl(unitResult.element.library);
         }
 

pkg/analyzer/lib/src/dart/analysis/library_context.dart

@@ -9,8 +9,7 @@ import 'dart:collection';
 import 'dart:typed_data';
 
 import 'package:analyzer/dart/analysis/declared_variables.dart';
-import 'package:analyzer/dart/element/element.dart'
-    show CompilationUnitElement, LibraryElement;
+import 'package:analyzer/dart/element/element.dart' show CompilationUnitElement;
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/context/context.dart';
 import 'package:analyzer/src/dart/analysis/analysis_options_map.dart';
@@ -116,8 +115,8 @@ class LibraryContext {
     return keys;
   }
 
-  /// Get the [LibraryElement] for the given library.
-  LibraryElement getLibraryElement(Uri uri) {
+  /// Get the [LibraryElementImpl] for the given library.
+  LibraryElementImpl getLibraryElement(Uri uri) {
     _createElementFactoryTypeProvider();
     return elementFactory.libraryOfUri2(uri);
   }

pkg/analyzer/lib/src/dart/analysis/results.dart

@@ -14,6 +14,7 @@ import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/source/line_info.dart';
 import 'package:analyzer/src/dart/analysis/file_state.dart';
+import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/type_system.dart';
 import 'package:analyzer/src/generated/engine.dart';
 
@@ -266,12 +267,12 @@ class FileResultImpl extends AnalysisResultImpl implements FileResult {
 
 class LibraryElementResultImpl implements LibraryElementResult {
   @override
-  final LibraryElement element;
+  final LibraryElementImpl element;
 
   LibraryElementResultImpl(this.element);
 
   @override
-  LibraryElement2 get element2 => element as LibraryElement2;
+  LibraryElementImpl get element2 => element;
 }
 
 class ParsedLibraryResultImpl extends AnalysisResultImpl
@@ -486,8 +487,9 @@ class ResolvedUnitResultImpl extends FileResultImpl
   bool get exists => fileState.exists;
 
   @override
-  LibraryElement get libraryElement {
-    return unit.declaredElement!.library;
+  LibraryElementImpl get libraryElement {
+    var element = unit.declaredElement as CompilationUnitElementImpl;
+    return element.library;
   }
 
   @override
@@ -500,13 +502,13 @@ class ResolvedUnitResultImpl extends FileResultImpl
   TypeProvider get typeProvider => libraryElement.typeProvider;
 
   @override
-  TypeSystemImpl get typeSystem => libraryElement.typeSystem as TypeSystemImpl;
+  TypeSystemImpl get typeSystem => libraryElement.typeSystem;
 }
 
 class UnitElementResultImpl extends FileResultImpl
     implements UnitElementResult {
   @override
-  final CompilationUnitElement element;
+  final CompilationUnitElementImpl element;
 
   UnitElementResultImpl({
     required super.session,
@@ -515,5 +517,5 @@ class UnitElementResultImpl extends FileResultImpl
   });
 
   @override
-  LibraryFragment get fragment => element as LibraryFragment;
+  LibraryFragment get fragment => element;
 }

pkg/analyzer/lib/src/dart/analysis/search.dart

@@ -1331,7 +1331,7 @@ class _FindDeclarations {
           (performance) async {
             var result = await analysisDriver.getLibraryByUri('$uri');
             if (result is LibraryElementResultImpl) {
-              return result.element as LibraryElementImpl;
+              return result.element;
             }
             return null;
           },

pkg/analyzer/lib/src/dart/micro/analysis_context.dart

@@ -19,7 +19,6 @@ import 'package:analyzer/src/dart/element/inheritance_manager3.dart';
 import 'package:analyzer/src/dart/micro/resolve_file.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/summary2/linked_element_factory.dart';
-import 'package:analyzer/src/utilities/extensions/element.dart';
 
 MicroContextObjects createMicroContextObjects({
   required FileResolver fileResolver,
@@ -163,7 +162,7 @@ class _MicroAnalysisSessionImpl extends AnalysisSessionImpl {
     var element = await analysisContext.fileResolver.getLibraryByUri2(
       uriStr: uriStr,
     );
-    return LibraryElementResultImpl(element.asElement);
+    return LibraryElementResultImpl(element);
   }
 
   @override

pkg/analyzer/lib/src/dart/micro/resolve_file.dart

@@ -8,7 +8,6 @@ import 'package:analyzer/dart/analysis/declared_variables.dart';
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/element/element.dart';
-import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/source/line_info.dart';
@@ -28,6 +27,7 @@ import 'package:analyzer/src/dart/analysis/performance_logger.dart';
 import 'package:analyzer/src/dart/analysis/results.dart';
 import 'package:analyzer/src/dart/analysis/search.dart';
 import 'package:analyzer/src/dart/analysis/unlinked_unit_store.dart';
+import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/micro/analysis_context.dart';
 import 'package:analyzer/src/dart/micro/utils.dart';
 import 'package:analyzer/src/dart/resolver/flow_analysis_visitor.dart';
@@ -390,7 +390,7 @@ class FileResolver {
     return fsState.getFilesWithTopLevelDeclarations(name);
   }
 
-  Future<LibraryElement2> getLibraryByUri2({
+  Future<LibraryElementImpl> getLibraryByUri2({
     required String uriStr,
     OperationPerformanceImpl? performance,
   }) async {

pkg/analyzer/test/src/dart/resolution/context_collection_resolution.dart

@@ -5,7 +5,6 @@
 import 'package:analyzer/dart/analysis/analysis_context.dart';
 import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/dart/analysis/context_root.dart';
-import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/sdk/build_sdk_summary.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
@@ -308,7 +307,7 @@ abstract class ContextResolutionTest
     var uriStr = uri.toString();
     var libraryResult = await analysisSession.getLibraryByUri(uriStr);
     libraryResult as LibraryElementResultImpl;
-    return libraryResult.element2 as LibraryElementImpl;
+    return libraryResult.element2;
   }
 
   @override
@@ -321,10 +320,11 @@ abstract class ContextResolutionTest
   }
 
   @override
-  Future<ResolvedUnitResult> resolveFile(File file) async {
+  Future<ResolvedUnitResultImpl> resolveFile(File file) async {
     var analysisContext = contextFor(fileForContextSelection ?? file);
     var session = analysisContext.currentSession;
-    return await session.getResolvedUnit(file.path) as ResolvedUnitResult;
+    var result = await session.getResolvedUnit(file.path);
+    return result as ResolvedUnitResultImpl;
   }
 
   @mustCallSuper

pkg/analyzer/test/src/summary/macro_test.dart

@@ -19352,7 +19352,7 @@ elementFactory
 
     // Check that it has `class B2 {}`, as requested.
     result2 as LibraryElementResultImpl;
-    _assertMacroCode(result2.element as LibraryElementImpl, r'''
+    _assertMacroCode(result2.element, r'''
 part of 'package:test/test.dart';
 
 class B2 {}

pkg/analyzer/test/src/utilities/extensions/analysis_session_test.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/analysis/session.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/results.dart';
+import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/test_utilities/test_code_format.dart';
 import 'package:analyzer/src/utilities/extensions/analysis_session.dart';
 import 'package:test/test.dart';
@@ -91,9 +92,9 @@ class LocateElementTest extends PubPackageResolutionTest {
 }
 
 class _MockAnalysisSession implements AnalysisSession {
-  final _libraries = <String, LibraryElement>{};
+  final _libraries = <String, LibraryElementImpl>{};
 
-  void addLibrary(LibraryElement library) =>
+  void addLibrary(LibraryElementImpl library) =>
       _libraries[library.identifier] = library;
 
   @override