[vm/shared] LoadAcquire/StoreRelease for shared static fields.

BUG=#61025
TEST=ci

Change-Id: I383de4369226028a1dd1019fb364e1ffac3a9ff9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440547
Reviewed-by: Ryan Macnak <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Author: aam

runtime/vm/compiler/backend/il.cc

@@ -4547,8 +4547,21 @@ void LoadStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
           : compiler::target::Thread::field_table_values_offset();
   const intptr_t field_offset = compiler::target::FieldTable::OffsetOf(field());
 
-  __ LoadMemoryValue(result, THR, static_cast<int32_t>(field_table_offset));
-  __ LoadMemoryValue(result, result, static_cast<int32_t>(field_offset));
+  if (field().is_shared()) {
+#if defined(TARGET_ARCH_RISCV32) || defined(TARGET_ARCH_RISCV64)
+    const auto field_table_offset_reg = TMP;
+#else
+    const auto field_table_offset_reg = result;
+#endif
+    __ LoadMemoryValue(field_table_offset_reg, THR,
+                       static_cast<int32_t>(field_table_offset));
+    __ LoadAcquire(result,
+                   compiler::Address(field_table_offset_reg,
+                                     static_cast<int32_t>(field_offset)));
+  } else {
+    __ LoadMemoryValue(result, THR, static_cast<int32_t>(field_table_offset));
+    __ LoadMemoryValue(result, result, static_cast<int32_t>(field_offset));
+  }
 
   if (does_throw_access_error_or_call_initializer()) {
     if (calls_initializer() && throw_exception_on_initialization()) {

runtime/vm/compiler/backend/il_arm64.cc

@@ -2523,8 +2523,14 @@ void StoreStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
           ? compiler::target::Thread::shared_field_table_values_offset()
           : compiler::target::Thread::field_table_values_offset());
   // Note: static fields ids won't be changed by hot-reload.
-  __ StoreToOffset(value, temp,
-                   compiler::target::FieldTable::OffsetOf(field()));
+  if (field().is_shared()) {
+    __ StoreRelease(value,
+                    compiler::Address(
+                        temp, compiler::target::FieldTable::OffsetOf(field())));
+  } else {
+    __ StoreToOffset(value, temp,
+                     compiler::target::FieldTable::OffsetOf(field()));
+  }
 }
 
 LocationSummary* InstanceOfInstr::MakeLocationSummary(Zone* zone,

runtime/vm/compiler/backend/il_ia32.cc

@@ -2168,9 +2168,15 @@ void StoreStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
                   ? compiler::target::Thread::shared_field_table_values_offset()
                   : compiler::target::Thread::field_table_values_offset()));
   // Note: static fields ids won't be changed by hot-reload.
-  __ movl(
-      compiler::Address(temp, compiler::target::FieldTable::OffsetOf(field())),
-      in);
+  if (field().is_shared()) {
+    __ StoreRelease(
+        in, compiler::Address(temp,
+                              compiler::target::FieldTable::OffsetOf(field())));
+  } else {
+    __ movl(compiler::Address(temp,
+                              compiler::target::FieldTable::OffsetOf(field())),
+            in);
+  }
 }
 
 LocationSummary* InstanceOfInstr::MakeLocationSummary(Zone* zone,

runtime/vm/compiler/backend/il_riscv.cc

@@ -2716,7 +2716,14 @@ void StoreStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
           ? compiler::target::Thread::shared_field_table_values_offset()
           : compiler::target::Thread::field_table_values_offset());
   // Note: static fields ids won't be changed by hot-reload.
-  __ StoreToOffset(value, TMP, compiler::target::FieldTable::OffsetOf(field()));
+  if (field().is_shared()) {
+    __ StoreRelease(value,
+                    compiler::Address(
+                        TMP, compiler::target::FieldTable::OffsetOf(field())));
+  } else {
+    __ StoreToOffset(value, TMP,
+                     compiler::target::FieldTable::OffsetOf(field()));
+  }
 }
 
 LocationSummary* InstanceOfInstr::MakeLocationSummary(Zone* zone,

runtime/vm/compiler/backend/il_x64.cc

@@ -2499,9 +2499,15 @@ void StoreStaticFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
                   ? compiler::target::Thread::shared_field_table_values_offset()
                   : compiler::target::Thread::field_table_values_offset()));
   // Note: static fields ids won't be changed by hot-reload.
-  __ movq(
-      compiler::Address(temp, compiler::target::FieldTable::OffsetOf(field())),
-      value);
+  if (field().is_shared()) {
+    __ movq(compiler::Address(temp,
+                              compiler::target::FieldTable::OffsetOf(field())),
+            value);
+  } else {
+    __ StoreRelease(value,
+                    compiler::Address(
+                        temp, compiler::target::FieldTable::OffsetOf(field())));
+  }
 }
 
 LocationSummary* InstanceOfInstr::MakeLocationSummary(Zone* zone,