[ CLI ] Support --suppress-analytics before CLI commands and for dart test

Fixes #56842

TEST=pkg/dartdev/test/commands/test_test.dart

Change-Id: I1692352e3847c977c72a948d26be8ef8311ec69e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390900
Commit-Queue: Ben Konyi <[email protected]>
Auto-Submit: Ben Konyi <[email protected]>
Reviewed-by: Derek Xu <[email protected]>
Commit-Queue: Derek Xu <[email protected]>

Author: bkonyi

pkg/dartdev/lib/src/commands/test.dart

@@ -63,13 +63,16 @@ Run "${runner!.executableName} help" to see global options.''');
     try {
       final testExecutable = await getExecutableForCommand('test:test',
           nativeAssets: nativeAssets);
-      final argsRestNoExperiment = args.rest
-          .where((e) => !e.startsWith('--$experimentFlagName='))
+      final argsRestNoExperimentOrSuppressAnalytics = args.rest
+          .where((e) =>
+              !e.startsWith('--$experimentFlagName=') &&
+              e != '--suppress-analytics')
           .toList();
-      log.trace('dart $testExecutable ${argsRestNoExperiment.join(' ')}');
+      log.trace(
+          'dart $testExecutable ${argsRestNoExperimentOrSuppressAnalytics.join(' ')}');
       VmInteropHandler.run(
         testExecutable.executable,
-        argsRestNoExperiment,
+        argsRestNoExperimentOrSuppressAnalytics,
         packageConfigOverride: testExecutable.packageConfig!,
         // TODO(bkonyi): remove once DartDev moves to AOT and this flag can be
         // provided directly to the process spawned by `dart run` and

pkg/dartdev/test/commands/test_test.dart

@@ -207,6 +207,42 @@ void main() {
     expect(vm.systemIsolates!.where((e) => e.name == 'main'), isNotEmpty);
   });
 
+  // Regression tests for https://github.com/dart-lang/sdk/issues/56842
+  group('properly handles --suppress-analytics', () {
+    void suppressAnalyticsTest({required bool beforeCommand}) {
+      test('${beforeCommand ? 'before' : 'after'} command', () async {
+        final p = project(pubspecExtras: {
+          'dev_dependencies': {'test': 'any'}
+        });
+        p.file('test/foo_test.dart', '''
+          import 'package:test/test.dart';
+
+          void main() {
+            test('', () {
+              expect(1,1);
+            });
+          }
+          ''');
+
+        // An implicit `pub get` will happen.
+        final result = await p.run([
+          if (beforeCommand) '--suppress-analytics',
+          'test',
+          '--no-color',
+          '--reporter',
+          'expanded',
+          if (!beforeCommand) '--suppress-analytics',
+        ]);
+        expect(result.stderr, isEmpty);
+        expect(result.stdout, contains('All tests passed!'));
+        expect(result.exitCode, 0);
+      });
+    }
+
+    suppressAnalyticsTest(beforeCommand: true);
+    suppressAnalyticsTest(beforeCommand: false);
+  });
+
   group('--enable-experiment', () {
     late TestProject p;
     Future<ProcessResult> runTestWithExperimentFlag(String? flag) async {

runtime/bin/main_options.cc

@@ -550,6 +550,9 @@ bool Options::ParseArguments(int argc,
       } else if (IsOption(argv[i], "disable-telemetry")) {
         disable_dartdev_analytics = true;
         skipVmOption = true;
+      } else if (IsOption(argv[i], "suppress-analytics")) {
+        dart_options->AddArgument("--suppress-analytics");
+        skipVmOption = true;
       } else if (IsOption(argv[i], "no-analytics")) {
         // Just add this option even if we don't go to dartdev.
         // It is irrelevant for the vm.