Skip to content

Commit 6b6b587

Browse files
DanTupCommit Queue
authored andcommitted
[dds/dap] Enable verbose logging for all of debug_exceptions_test
Some failures - such as https://dart-ci.appspot.com/log/pkg-linux-release/unittest-asserts-release-linux-x64/30375/pkg/dds/test/dap/integration/debug_exceptions_test are in tests that weren't originally made verbose. This makes the whole test suite verbose. Change-Id: I8e90a4db72d89fc9f4d9291529e7e4f1a07d50cf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/411682 Commit-Queue: Derek Xu <[email protected]> Reviewed-by: Derek Xu <[email protected]> Reviewed-by: Jessy Yameogo <[email protected]>
1 parent 25bd38b commit 6b6b587

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

pkg/dds/test/dap/integration/debug_exceptions_test.dart

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@ main() {
1212
group('debug mode', () {
1313
late DapTestSession dap;
1414
setUp(() async {
15-
dap = await DapTestSession.setUp();
15+
// Temporarily enable verbose logging to help track down
16+
// https://github.com/dart-lang/sdk/issues/55685
17+
dap = await DapTestSession.setUp(forceVerboseLogging: true);
1618
});
1719
tearDown(() => dap.tearDown());
1820

@@ -73,20 +75,6 @@ main() {
7375
exceptionPauseMode: 'All',
7476
);
7577
});
76-
// These tests can be slow due to starting up the external server process.
77-
}, timeout: Timeout.none);
78-
79-
group('debug mode (verbose)', () {
80-
late DapTestSession dap;
81-
setUp(() async {
82-
dap = await DapTestSession.setUp(
83-
// This boolean is temporarily set to `true` to aid debugging
84-
// this test and will be reverted (and this additional group removed)
85-
// soon.
86-
forceVerboseLogging: true,
87-
);
88-
});
89-
tearDown(() => dap.tearDown());
9078

9179
test('parses line/column information from stack traces', () async {
9280
final client = dap.client;

0 commit comments

Comments
 (0)