[cfe] Remove _BodyBuilderCloner

Cloning is only performed on fully inferred expressions so we no longer need the specialized cloner.

`_BodyBuilderCloner` is removed along with the unused `isOrphaned` method and `_FindChildVisitor`.

Change-Id: I9fa2ca519af95d5d6bb2c116da3163eb552792f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448201
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -279,7 +279,7 @@ class BodyBuilder extends StackListenerImpl
 
   final LocalStack<LabelScope?> _switchScopes = new LocalStack([]);
 
-  late _BodyBuilderCloner _cloner = new _BodyBuilderCloner(this);
+  late CloneVisitorNotMembers _simpleCloner = new CloneVisitorNotMembers();
 
   @override
   ConstantContext constantContext = ConstantContext.none;
@@ -1381,7 +1381,7 @@ class BodyBuilder extends StackListenerImpl
             i,
           );
           if (tearOffParameter != null) {
-            Expression tearOffInitializer = _cloner.cloneInContext(
+            Expression tearOffInitializer = _simpleCloner.cloneInContext(
               initializer!,
             );
             tearOffParameter.initializer = tearOffInitializer
@@ -1785,7 +1785,9 @@ class BodyBuilder extends StackListenerImpl
         for (int i = 1; i < variables.length; i++) {
           VariableDeclaration variable = variables[i];
           for (int i = 0; i < annotations.length; i++) {
-            variable.addAnnotation(_cloner.cloneInContext(annotations[i]));
+            variable.addAnnotation(
+              _simpleCloner.cloneInContext(annotations[i]),
+            );
           }
         }
       }

pkg/front_end/lib/src/kernel/body_builder_helpers.dart

@@ -402,105 +402,6 @@ class ForInElements {
       (explicitVariableDeclaration ?? syntheticVariableDeclaration)!;
 }
 
-class _BodyBuilderCloner extends CloneVisitorNotMembers {
-  final BodyBuilder bodyBuilder;
-
-  _BodyBuilderCloner(this.bodyBuilder);
-
-  @override
-  // Coverage-ignore(suite): Not run.
-  TreeNode visitStaticInvocation(StaticInvocation node) {
-    if (node is FactoryConstructorInvocation) {
-      FactoryConstructorInvocation result = new FactoryConstructorInvocation(
-        node.target,
-        clone(node.arguments),
-        isConst: node.isConst,
-      )..hasBeenInferred = node.hasBeenInferred;
-      return result;
-    } else if (node is TypeAliasedFactoryInvocation) {
-      TypeAliasedFactoryInvocation result = new TypeAliasedFactoryInvocation(
-        node.typeAliasBuilder,
-        node.target,
-        clone(node.arguments),
-        isConst: node.isConst,
-      )..hasBeenInferred = node.hasBeenInferred;
-      return result;
-    }
-    return super.visitStaticInvocation(node);
-  }
-
-  @override
-  TreeNode visitConstructorInvocation(ConstructorInvocation node) {
-    if (node is TypeAliasedConstructorInvocation) {
-      // Coverage-ignore-block(suite): Not run.
-      TypeAliasedConstructorInvocation result =
-          new TypeAliasedConstructorInvocation(
-            node.typeAliasBuilder,
-            node.target,
-            clone(node.arguments),
-            isConst: node.isConst,
-          )..hasBeenInferred = node.hasBeenInferred;
-      return result;
-    }
-    return super.visitConstructorInvocation(node);
-  }
-
-  @override
-  TreeNode visitArguments(Arguments node) {
-    if (node is ArgumentsImpl) {
-      return ArgumentsImpl.clone(
-        node,
-        node.positional.map(clone).toList(),
-        node.named.map(clone).toList(),
-        node.types.map(visitType).toList(),
-      );
-    }
-    return super.visitArguments(node);
-  }
-}
-
-// Coverage-ignore(suite): Not run.
-/// Returns `true` if [node] is not part of its parent member.
-///
-/// This computation is costly and should only be used in assertions to verify
-/// that [node] has been removed from the AST.
-bool isOrphaned(TreeNode node) {
-  TreeNode? parent = node;
-  Member? member;
-  while (parent != null) {
-    if (parent is Member) {
-      member = parent;
-      break;
-    }
-    parent = parent.parent;
-  }
-  if (member == null) {
-    return true;
-  }
-  _FindChildVisitor visitor = new _FindChildVisitor(node);
-  member.accept(visitor);
-  return !visitor.foundNode;
-}
-
-// Coverage-ignore(suite): Not run.
-class _FindChildVisitor extends VisitorDefault<void> with VisitorVoidMixin {
-  final TreeNode soughtNode;
-  bool foundNode = false;
-
-  _FindChildVisitor(this.soughtNode);
-
-  @override
-  void defaultNode(Node node) {
-    if (!foundNode) {
-      if (identical(node, soughtNode)) {
-        foundNode = true;
-      } else {
-        node.visitChildren(this);
-      }
-    }
-  }
-}
-
 class Condition {
   final Expression expression;
   final PatternGuard? patternGuard;

pkg/front_end/lib/src/kernel/internal_ast.dart

@@ -436,6 +436,7 @@ class ArgumentsImpl extends Arguments {
   /// super-positional, the field is null.
   Set<String>? namedSuperParameterNames;
 
+  // Coverage-ignore(suite): Not run.
   ArgumentsImpl.internal({
     required List<Expression> positional,
     required List<DartType>? types,
@@ -503,6 +504,7 @@ class ArgumentsImpl extends Arguments {
            ..addAll(_normalizeTypeArguments(typeParameterCount, typeArguments)),
        );
 
+  // Coverage-ignore(suite): Not run.
   static ArgumentsImpl clone(
     ArgumentsImpl node,
     List<Expression> positional,