[test_runner] Use relative paths in commands.

This makes it easier to copy commands between checkouts or between the bot and local development.

Change-Id: I8e127cfc6f97e14b315d34dea08f32ffc22cadea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438380
Commit-Queue: Ryan Macnak <[email protected]>
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

pkg/test_runner/lib/src/compiler_configuration.dart

@@ -1428,8 +1428,7 @@ abstract mixin class VMKernelCompilerMixin {
 
   Command computeCompileToKernelCommand(String tempDir, List<String> arguments,
       Map<String, String> environmentOverrides) {
-    var pkgVmDir = Platform.script.resolve('../../../pkg/vm').toFilePath();
-    var genKernel = '$pkgVmDir/tool/gen_kernel$shellScriptExtension';
+    var genKernel = 'pkg/vm/tool/gen_kernel$shellScriptExtension';
 
     var kernelBinariesFolder = _configuration.buildDirectory;
     if (_useSdk) {

pkg/test_runner/lib/src/runtime_configuration.dart

@@ -542,9 +542,9 @@ class DartkFuchsiaEmulatorRuntimeConfiguration
     }
 
     // Rewrite paths on the host to paths in the Fuchsia package.
+    arguments[arguments.length - 1] = "pkg/data/${arguments[arguments.length - 1]}";
     arguments = arguments
-        .map((argument) =>
-            argument.replaceAll(Directory.current.path, "pkg/data"))
+        .map((argument) => argument.replaceAll("--packages=", "--packages=pkg/data/"))
         .toList();
 
     var component = "dart_test_component.cm";

pkg/test_runner/lib/src/test_suite.dart

@@ -226,7 +226,6 @@ abstract class TestSuite {
 
     TestUtils.mkdirRecursive(Path('.'), generatedTestPath);
     return File(generatedTestPath.toNativePath())
-        .absolute
         .path
         .replaceAll('\\', '/');
   }
@@ -344,7 +343,7 @@ class VMTestSuite extends TestSuite {
             configuration.architecture == Architecture.x64c
         ? '$buildDir/gen/kernel-service.dart.snapshot'
         : '$buildDir/gen/kernel_service.dill';
-    var dfePath = Path(filename).absolute.toNativePath();
+    var dfePath = Path(filename).toNativePath();
     final experiments = [...configuration.experiments];
     var args = [
       ...initialTargetArguments,
@@ -955,8 +954,7 @@ class StandardTestSuite extends TestSuite {
         var nameFromModuleRoot = testFile.path.relativeTo(Repository.dir);
         var nameFromModuleRootNoExt =
             "${nameFromModuleRoot.directoryPath}/$nameNoExt";
-        var jsDir =
-            Path(compilationTempDir).relativeTo(Repository.dir).toString();
+        var jsDir = Path(compilationTempDir).toString();
         var nativeNonNullAsserts =
             testFile.ddcOptions.contains('--native-null-assertions');
         var jsInteropNonNullAsserts =
@@ -1032,15 +1030,16 @@ class StandardTestSuite extends TestSuite {
       args.add('--format=json');
     }
 
-    args.add(testFile.path.toNativePath());
+    args.add(testFile.path.relativeTo(Repository.dir).toNativePath());
 
     return args;
   }
 
   String? packagesArgument(String? packages) {
     // If this test is inside a package, we will check if there is a
     // pubspec.yaml file and if so, create a custom package root for it.
-    packages ??= Path(configuration.packages).toNativePath();
+    packages ??=
+        Path(configuration.packages).relativeTo(Repository.dir).toNativePath();
 
     if (packages == 'none') {
       return null;

tests/standalone/io/process_non_ascii_test.dart

@@ -26,12 +26,14 @@ main() {
   var nonAsciiTxtFile = new File('${nonAsciiDir.path}/æøå.txt');
   nonAsciiTxtFile.writeAsStringSync('æøå');
   var script = nonAsciiFile.path;
+  var absolutePackages = Uri.parse(Platform.packageConfig!).toFilePath();
   // Note: we prevent this child process from using Crashpad handler because
   // this introduces an issue with deleting the temporary directory.
   Process.run(
     executable,
     []
       ..addAll(Platform.executableArguments)
+      ..add("--packages=$absolutePackages")
       ..add(script),
     workingDirectory: nonAsciiDir.path,
     environment: {'DART_CRASHPAD_HANDLER': ''},

tests/standalone/io/regress_7679_test.dart

@@ -35,12 +35,14 @@ main() {
 }
 """);
   String executable = new File(Platform.executable).resolveSymbolicLinksSync();
+  String absolutePackages = Uri.parse(Platform.packageConfig!).toFilePath();
   // Note: we prevent this child process from using Crashpad handler because
   // this introduces an issue with deleting the temporary directory.
   Process.run(
     executable,
     []
       ..addAll(Platform.executableArguments)
+      ..add("--packages=$absolutePackages")
       ..add('script.dart'),
     workingDirectory: temp.path,
     environment: {'DART_CRASHPAD_HANDLER': ''},