Fine. Record LibraryElementImpl.isSynthetic

Flag `hasPartOfDirective` was not used, and so removed.

Change-Id: Id73615d0b06be65d59ad76bdd4cb3da8daa1b220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449922
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 556;
+  static const int DATA_VERSION = 557;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6211,14 +6211,6 @@ class LibraryElementImpl extends ElementImpl
     _getters = value;
   }
 
-  bool get hasPartOfDirective {
-    return hasModifier(Modifier.HAS_PART_OF_DIRECTIVE);
-  }
-
-  set hasPartOfDirective(bool hasPartOfDirective) {
-    setModifier(Modifier.HAS_PART_OF_DIRECTIVE, hasPartOfDirective);
-  }
-
   @override
   @trackedIndirectly
   String get identifier => '$uri';
@@ -6243,7 +6235,9 @@ class LibraryElementImpl extends ElementImpl
   }
 
   @override
+  @trackedDirectly
   bool get isSynthetic {
+    globalResultRequirements?.record_library_isSynthetic(element: this);
     return hasModifier(Modifier.SYNTHETIC);
   }
 
@@ -8581,11 +8575,6 @@ enum Modifier {
   /// initializer.
   HAS_INITIALIZER,
 
-  /// A flag used for libraries indicating that the defining compilation unit
-  /// has a `part of` directive, meaning that this unit should be a part,
-  /// but is used as a library.
-  HAS_PART_OF_DIRECTIVE,
-
   /// Indicates that the value of [FragmentImpl.sinceSdkVersion] was computed.
   HAS_SINCE_SDK_VERSION_COMPUTED,
 

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -24,6 +24,7 @@ import 'package:collection/collection.dart';
 /// The manifest of a single library.
 class LibraryManifest {
   final String? name;
+  final bool isSynthetic;
   final Uint8List featureSet;
   final ManifestLibraryLanguageVersion languageVersion;
   final LibraryMetadataItem libraryMetadata;
@@ -53,6 +54,7 @@ class LibraryManifest {
 
   LibraryManifest({
     required this.name,
+    required this.isSynthetic,
     required this.featureSet,
     required this.languageVersion,
     required this.libraryMetadata,
@@ -75,6 +77,7 @@ class LibraryManifest {
   factory LibraryManifest.read(SummaryDataReader reader) {
     return LibraryManifest(
       name: reader.readOptionalStringUtf8(),
+      isSynthetic: reader.readBool(),
       featureSet: reader.readUint8List(),
       languageVersion: ManifestLibraryLanguageVersion.read(reader),
       libraryMetadata: LibraryMetadataItem.read(reader),
@@ -157,6 +160,7 @@ class LibraryManifest {
 
   void write(BufferedSink sink) {
     sink.writeOptionalStringUtf8(name);
+    sink.writeBool(isSynthetic);
     sink.writeUint8List(featureSet);
     languageVersion.write(sink);
     libraryMetadata.write(sink);
@@ -877,6 +881,7 @@ class LibraryManifestBuilder {
 
       var newManifest = LibraryManifest(
         name: libraryElement.name.nullIfEmpty,
+        isSynthetic: libraryElement.isSynthetic,
         featureSet: (libraryElement.featureSet as ExperimentStatus).toStorage(),
         languageVersion: ManifestLibraryLanguageVersion.encode(
           libraryElement.languageVersion,
@@ -1103,6 +1108,7 @@ class LibraryManifestBuilder {
     return inputManifests[uri] ??
         LibraryManifest(
           name: null,
+          isSynthetic: false,
           featureSet: Uint8List(0),
           languageVersion: ManifestLibraryLanguageVersion.empty(),
           libraryMetadata: LibraryMetadataItem.empty(),

pkg/analyzer/lib/src/fine/requirement_failure.dart

@@ -334,6 +334,24 @@ class LibraryFeatureSetMismatch extends RequirementFailure {
   }
 }
 
+class LibraryIsSyntheticMismatch extends RequirementFailure {
+  final Uri libraryUri;
+  final bool expected;
+  final bool actual;
+
+  LibraryIsSyntheticMismatch({
+    required this.libraryUri,
+    required this.expected,
+    required this.actual,
+  });
+
+  @override
+  String toString() {
+    return 'LibraryIsSyntheticMismatch(libraryUri: $libraryUri, '
+        'expected: $expected, actual: $actual)';
+  }
+}
+
 class LibraryLanguageVersionMismatch extends RequirementFailure {
   final Uri libraryUri;
   final ManifestLibraryLanguageVersion expected;

pkg/analyzer/lib/src/fine/requirements.dart

@@ -372,6 +372,7 @@ class LibraryExportRequirements {
 
 class LibraryRequirements {
   String? name;
+  bool? isSynthetic;
   Uint8List? featureSet;
   ManifestLibraryLanguageVersion? languageVersion;
   ManifestItemId? libraryMetadataId;
@@ -417,6 +418,7 @@ class LibraryRequirements {
 
   LibraryRequirements({
     required this.name,
+    required this.isSynthetic,
     required this.featureSet,
     required this.languageVersion,
     required this.libraryMetadataId,
@@ -451,6 +453,7 @@ class LibraryRequirements {
   factory LibraryRequirements.empty() {
     return LibraryRequirements(
       name: null,
+      isSynthetic: null,
       featureSet: null,
       languageVersion: null,
       libraryMetadataId: null,
@@ -486,6 +489,7 @@ class LibraryRequirements {
   factory LibraryRequirements.read(SummaryDataReader reader) {
     return LibraryRequirements(
       name: reader.readOptionalStringUtf8(),
+      isSynthetic: reader.readOptionalBool(),
       featureSet: reader.readOptionalUint8List(),
       languageVersion: ManifestLibraryLanguageVersion.readOptional(reader),
       libraryMetadataId: ManifestItemId.readOptional(reader),
@@ -529,6 +533,7 @@ class LibraryRequirements {
 
   void write(BufferedSink sink) {
     sink.writeOptionalStringUtf8(name);
+    sink.writeOptionalBool(isSynthetic);
     sink.writeOptionalUint8List(featureSet);
     sink.writeOptionalObject(languageVersion, (it) => it.write(sink));
     libraryMetadataId.writeOptional(sink);
@@ -726,6 +731,17 @@ class RequirementsManifest {
         }
       }
 
+      if (libraryRequirements.isSynthetic case var expected?) {
+        var actual = libraryManifest.isSynthetic;
+        if (expected != actual) {
+          return LibraryIsSyntheticMismatch(
+            libraryUri: libraryUri,
+            expected: expected,
+            actual: actual,
+          );
+        }
+      }
+
       if (libraryRequirements.featureSet case var expected?) {
         var actual = libraryManifest.featureSet;
         if (!const ListEquality<int>().equals(expected, actual)) {
@@ -2046,6 +2062,20 @@ class RequirementsManifest {
     requirements.requestedDeclaredTypeAliases[lookupName] = id;
   }
 
+  void record_library_isSynthetic({required LibraryElementImpl element}) {
+    if (_recordingLockLevel != 0) {
+      return;
+    }
+
+    var manifest = element.manifest;
+    if (manifest == null) {
+      return;
+    }
+
+    var requirements = _getLibraryRequirements(element);
+    requirements.isSynthetic = manifest.isSynthetic;
+  }
+
   void record_library_languageVersion({required LibraryElementImpl element}) {
     if (_recordingLockLevel != 0) {
       return;

pkg/analyzer/lib/src/summary2/element_builder.dart

@@ -1645,10 +1645,7 @@ class FragmentBuilder extends ThrowingAstVisitor<void> {
   }
 
   @override
-  void visitPartOfDirective(PartOfDirective node) {
-    var libraryElement = _libraryBuilder.element;
-    libraryElement.hasPartOfDirective = true;
-  }
+  void visitPartOfDirective(PartOfDirective node) {}
 
   @override
   void visitRecordTypeAnnotation(RecordTypeAnnotation node) {

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -31848,6 +31848,75 @@ typedef C = int;
     );
   }
 
+  test_dependency_libraryElement_isSynthetic() async {
+    configuration
+      ..withGetErrorsEvents = false
+      ..withStreamResolvedUnitResults = false;
+
+    _ManualRequirements.install((state) {
+      var library = state.singleUnit.importedLibraries.first;
+      library.isSynthetic;
+    });
+
+    newFile('$testPackageLibPath/test.dart', r'''
+import 'a.dart';
+''');
+
+    await _runChangeScenario(
+      operation: _FineOperationTestFileGetErrors(),
+      expectedInitialEvents: r'''
+[status] working
+[operation] linkLibraryCycle SDK
+[operation] linkLibraryCycle
+  package:test/a.dart
+    flags: isSynthetic
+  requirements
+[operation] linkLibraryCycle
+  package:test/test.dart
+  requirements
+[operation] analyzeFile
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+  requirements
+    libraries
+      package:test/a.dart
+        isSynthetic: true
+        libraryMetadataId: #M0
+[status] idle
+''',
+      updateFiles: () {
+        var a = newFile('$testPackageLibPath/a.dart', '');
+        return [a];
+      },
+      expectedUpdatedEvents: r'''
+[status] working
+[operation] linkLibraryCycle
+  package:test/a.dart
+  requirements
+[operation] reuseLinkedBundle
+  package:test/test.dart
+[operation] checkLibraryDiagnosticsRequirements
+  library: /home/test/lib/test.dart
+  libraryIsSyntheticMismatch
+    libraryUri: package:test/a.dart
+    expected: true
+    actual: false
+[operation] analyzeFile
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+  requirements
+    libraries
+      package:test/a.dart
+        libraryMetadataId: #M0
+[status] idle
+''',
+    );
+  }
+
   test_dependency_libraryElement_languageVersion() async {
     configuration
       ..withGetErrorsEvents = false
@@ -32013,6 +32082,7 @@ library;
 [operation] linkLibraryCycle SDK
 [operation] linkLibraryCycle
   package:test/test.dart
+    flags: isSynthetic
   requirements
 [operation] analyzeFile
   file: /home/test/lib/test.dart

pkg/analyzer/test/src/dart/analysis/result_printer.dart

@@ -62,6 +62,11 @@ class BundleRequirementsPrinter {
           if (libraryRequirements.name case var name?) {
             sink.writelnWithIndent('name: $name');
           }
+          if (libraryRequirements.isSynthetic case var value?) {
+            if (value) {
+              sink.writelnWithIndent('isSynthetic: $value');
+            }
+          }
           if (libraryRequirements.featureSet != null) {
             sink.writelnWithIndent('featureSet: <not-null>');
           }
@@ -666,6 +671,13 @@ class DriverEventsPrinter {
       case LibraryFeatureSetMismatch():
         sink.writelnWithIndent('libraryFeatureSetMismatch');
         sink.writeProperties({'libraryUri': failure.libraryUri});
+      case LibraryIsSyntheticMismatch():
+        sink.writelnWithIndent('libraryIsSyntheticMismatch');
+        sink.writeProperties({
+          'libraryUri': failure.libraryUri,
+          'expected': failure.expected,
+          'actual': failure.actual,
+        });
       case ExportCountMismatch():
         sink.writelnWithIndent('exportCountMismatch');
         sink.writeProperties({
@@ -1147,6 +1159,7 @@ class LibraryManifestPrinter {
     if (manifest.name case var name?) {
       sink.writelnWithIndent('name: $name');
     }
+    sink.writeFlags({'isSynthetic': manifest.isSynthetic});
 
     var libraryMetadata = manifest.libraryMetadata;
     if (!libraryMetadata.isEmpty) {