analyzer: deprecate reportLintForToken; migrate all SDK callers

Change-Id: I23c5d3d3f7ee1657f17b3d507e1d4edf1afd65d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424701
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -359,7 +359,7 @@ abstract class LintRule {
     errorCode: errorCode,
   );
 
-  // TODO(srawlins): Deprecate this in favor of [reportToken].
+  @Deprecated('Use reportAtToken')
   void reportLintForToken(
     Token token, {
     List<Object> arguments = const [],

pkg/analyzer/test/src/diagnostics/unignorable_ignore_test.dart

@@ -115,7 +115,7 @@ class _AvoidIntVisitor extends SimpleAstVisitor {
   @override
   void visitNamedType(NamedType node) {
     if (node.name2.lexeme == 'int') {
-      rule.reportLintForToken(node.name2);
+      rule.reportAtToken(node.name2);
     }
   }
 }

pkg/analyzer/test/src/lint/lint_rule_test.dart

@@ -26,7 +26,7 @@ main() {
         );
         rule.reporter = reporter;
 
-        rule.reportLintForToken(
+        rule.reportAtToken(
           SimpleToken(TokenType.SEMICOLON, 0),
           errorCode: customCode,
         );
@@ -40,7 +40,7 @@ main() {
         );
         rule.reporter = reporter;
 
-        rule.reportLintForToken(SimpleToken(TokenType.SEMICOLON, 0));
+        rule.reportAtToken(SimpleToken(TokenType.SEMICOLON, 0));
         expect(reporter.code, rule.lintCode);
       });
       test('reportLint (custom)', () {

pkg/linter/lib/src/rules/always_declare_return_types.dart

@@ -42,7 +42,7 @@ class _Visitor extends SimpleAstVisitor<void> {
   @override
   void visitFunctionDeclaration(FunctionDeclaration node) {
     if (!node.isSetter && node.returnType == null && !node.isAugmentation) {
-      rule.reportLintForToken(
+      rule.reportAtToken(
         node.name,
         arguments: [node.name.lexeme],
         errorCode: LinterLintCode.always_declare_return_types_of_functions,
@@ -53,7 +53,7 @@ class _Visitor extends SimpleAstVisitor<void> {
   @override
   void visitFunctionTypeAlias(FunctionTypeAlias node) {
     if (node.returnType == null) {
-      rule.reportLintForToken(
+      rule.reportAtToken(
         node.name,
         arguments: [node.name.lexeme],
         errorCode: LinterLintCode.always_declare_return_types_of_functions,
@@ -75,7 +75,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       }
     }
 
-    rule.reportLintForToken(
+    rule.reportAtToken(
       node.name,
       arguments: [node.name.lexeme],
       errorCode: LinterLintCode.always_declare_return_types_of_methods,

pkg/linter/lib/src/rules/always_put_control_body_on_new_line.dart

@@ -71,7 +71,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     var lineInfo = unit.lineInfo;
     if (lineInfo.getLocation(controlEnd).lineNumber ==
         lineInfo.getLocation(offsetFirstStatement).lineNumber) {
-      rule.reportLintForToken(node.beginToken);
+      rule.reportAtToken(node.beginToken);
     }
   }
 }

pkg/linter/lib/src/rules/always_put_required_named_parameters_first.dart

@@ -45,7 +45,7 @@ class _Visitor extends SimpleAstVisitor<void> {
         if (nonRequiredSeen) {
           var name = param.name;
           if (name != null) {
-            rule.reportLintForToken(name);
+            rule.reportAtToken(name);
           }
         }
       } else {

pkg/linter/lib/src/rules/always_specify_types.dart

@@ -57,7 +57,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   void checkLiteral(TypedLiteral literal) {
     if (literal.typeArguments == null) {
-      rule.reportLintForToken(
+      rule.reportAtToken(
         literal.beginToken,
         errorCode: LinterLintCode.always_specify_types_add_type,
       );
@@ -71,13 +71,13 @@ class _Visitor extends SimpleAstVisitor<void> {
       var element = node.declaredElement2;
       if (element is VariableElement2) {
         if (keyword.keyword == Keyword.VAR) {
-          rule.reportLintForToken(
+          rule.reportAtToken(
             keyword,
             arguments: [keyword.lexeme, element!.type],
             errorCode: LinterLintCode.always_specify_types_replace_keyword,
           );
         } else {
-          rule.reportLintForToken(
+          rule.reportAtToken(
             keyword,
             arguments: [element!.type],
             errorCode: LinterLintCode.always_specify_types_specify_type,
@@ -94,13 +94,13 @@ class _Visitor extends SimpleAstVisitor<void> {
       var keyword = node.keyword;
       var tokenToLint = keyword ?? node.name;
       if (keyword != null && keyword.keyword == Keyword.VAR) {
-        rule.reportLintForToken(
+        rule.reportAtToken(
           tokenToLint,
           arguments: [keyword.lexeme, type],
           errorCode: LinterLintCode.always_specify_types_replace_keyword,
         );
       } else {
-        rule.reportLintForToken(
+        rule.reportAtToken(
           tokenToLint,
           arguments: [type],
           errorCode: LinterLintCode.always_specify_types_specify_type,
@@ -147,13 +147,13 @@ class _Visitor extends SimpleAstVisitor<void> {
         if (keyword.type == Keyword.VAR &&
             type != null &&
             type is! DynamicType) {
-          rule.reportLintForToken(
+          rule.reportAtToken(
             keyword,
             arguments: [keyword.lexeme, type],
             errorCode: LinterLintCode.always_specify_types_replace_keyword,
           );
         } else {
-          rule.reportLintForToken(
+          rule.reportAtToken(
             keyword,
             errorCode: LinterLintCode.always_specify_types_add_type,
           );
@@ -217,11 +217,7 @@ class _Visitor extends SimpleAstVisitor<void> {
           errorCode = LinterLintCode.always_specify_types_add_type;
         }
       }
-      rule.reportLintForToken(
-        keyword,
-        arguments: arguments,
-        errorCode: errorCode,
-      );
+      rule.reportAtToken(keyword, arguments: arguments, errorCode: errorCode);
     }
   }
 

pkg/linter/lib/src/rules/analyzer_use_new_elements.dart

@@ -147,7 +147,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (_isOldModelElement(node.element2)) {
-      rule.reportLintForToken(node.name2);
+      rule.reportAtToken(node.name2);
     }
   }
 

pkg/linter/lib/src/rules/annotate_overrides.dart

@@ -42,7 +42,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
     var member = context.inheritanceManager.overriddenMember(element);
     if (member != null) {
-      rule.reportLintForToken(target, arguments: [member.name3!]);
+      rule.reportAtToken(target, arguments: [member.name3!]);
     }
   }
 

pkg/linter/lib/src/rules/annotate_redeclares.dart

@@ -56,7 +56,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (extensionType == null) return;
 
     if (_redeclaresMember(element, extensionType)) {
-      rule.reportLintForToken(node.name, arguments: [element.displayName]);
+      rule.reportAtToken(node.name, arguments: [element.displayName]);
     }
   }