Skip to content

Commit 6f69ee3

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[test] Don't rely on try-catch to prevent inlining.
Change-Id: I21926e63c226196c92acf5e32515ce5b1ada8eb8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/397482 Reviewed-by: Siva Annamalai <[email protected]> Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
1 parent 7f44c72 commit 6f69ee3

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

tests/language/canonicalize/hashing_memoize_array_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,9 @@ const list2_97 = <Object?>[list2_96, list2_96];
207207
const list2_98 = <Object?>[list2_97, list2_97];
208208
const list2_99 = <Object?>[list2_98, list2_98];
209209

210+
@pragma("vm:never-inline")
211+
@pragma("vm:entry-point")
212+
@pragma("dart2js:noInline")
210213
confuse(x) {
211214
try {
212215
throw x;

tests/language/canonicalize/hashing_memoize_instance_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,9 @@ const box2_97 = Box(box2_96, box2_96);
213213
const box2_98 = Box(box2_97, box2_97);
214214
const box2_99 = Box(box2_98, box2_98);
215215

216+
@pragma("vm:never-inline")
217+
@pragma("vm:entry-point")
218+
@pragma("dart2js:noInline")
216219
confuse(x) {
217220
try {
218221
throw x;

tests/language/canonicalize/hashing_shallow_collision_array_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20018,6 +20018,9 @@ const list1 = [
2001820018

2001920019
// dart format on
2002020020

20021+
@pragma("vm:never-inline")
20022+
@pragma("vm:entry-point")
20023+
@pragma("dart2js:noInline")
2002120024
confuse(x) {
2002220025
try {
2002320026
throw x;

tests/language/canonicalize/hashing_shallow_collision_instance_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20018,6 +20018,9 @@ const list2 = [
2001820018
Box(Box(9999)),
2001920019
];
2002020020

20021+
@pragma("vm:never-inline")
20022+
@pragma("vm:entry-point")
20023+
@pragma("dart2js:noInline")
2002120024
confuse(x) {
2002220025
try {
2002320026
throw x;

tests/language/vm/allocation_sinking_vm_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ test1x4(c, x, y, z, w) {
7878
return d * d;
7979
}
8080

81+
@pragma("vm:never-inline")
82+
@pragma("vm:entry-point")
83+
@pragma("dart2js:noInline")
8184
effects() {
8285
// This function should not be inlinable.
8386
try {} catch (e) {}

0 commit comments

Comments
 (0)